Commit Graph

28909 Commits

Author SHA1 Message Date
Andy 81df5313d7 Simplify getOccurrencesAtPosition (#21977) 2018-02-15 13:02:32 -08:00
Anders Hejlsberg 0f697c376b Merge pull request #21947 from Microsoft/fixKeyofWildcard
Fix issue with 'keyof T' and conditional types
2018-02-15 12:44:51 -08:00
Nathan Shively-Sanders 54a89ac026 Simplify bindPropertyAssignment inner loop 2018-02-15 12:25:55 -08:00
Nathan Shively-Sanders d180117d21 Move skipParentheses to utilities
Makes typingsInstaller compile without adding dependencies
2018-02-15 11:12:36 -08:00
Nathan Shively-Sanders 8bfcf331d5 Add symbols for just-added test 2018-02-15 10:47:04 -08:00
Nathan Shively-Sanders 8f98c77217 Merge branch 'master' into js-object-literal-assignments-as-declarations 2018-02-15 10:28:25 -08:00
Nathan Shively-Sanders 0191b70d62 Further cleanup 2018-02-15 09:54:55 -08:00
Nathan Shively-Sanders d2b933e0d6 Cleanup in binder: rename and move 2018-02-15 09:36:48 -08:00
Andy a133cec246 Fix bug: Interface type parameter merged with property is not unused (#21966) 2018-02-15 09:30:58 -08:00
Andy 1b6aa1386f Handle non-preserved const enums in debug messages (#21945) 2018-02-15 09:21:33 -08:00
Nathan Shively-Sanders 4fdef85608 Naming and duplication cleanup 2018-02-15 09:13:06 -08:00
Nathan Shively-Sanders 0cadfcf6df Clean up js decl code in checker+utilities 2018-02-14 15:48:20 -08:00
Andy 8518343dc8 Add isStringLiteralLike helper (#21953) 2018-02-14 13:25:04 -08:00
Andy 2ee92948d8 Support @param tag on property declaration initializer (#21907)
* Support @param tag on property declaration initializer

* Update test

* Finish updating test
2018-02-14 10:12:38 -08:00
Anders Hejlsberg 9b227fc520 Accept new baselines 2018-02-14 09:20:21 -08:00
Anders Hejlsberg 3de1cd6f2d Add regression tests 2018-02-14 09:20:13 -08:00
Anders Hejlsberg 3a61f638ba Instantiation of 'keyof T' for wildcard type produces wildcard type 2018-02-14 09:19:47 -08:00
Andy 47d84f87ce assertItemInCompletionList: Fix error messages (#21908)
* assertItemInCompletionList: Fix error messages

* Fix lint
2018-02-14 08:11:38 -08:00
Priyantha Lankapura 80464e8ff1 fix typo in intellisense (#21914) 2018-02-13 18:52:33 -08:00
Nathan Shively-Sanders bad155f072 Clean up bindPropertyAssignment
The add-intermediate-container-symbols loop is still quite confusing,
but it's not as bad as before.
2018-02-13 16:50:53 -08:00
Andrew Casey 9e6d862bf4 Merge pull request #21927 from amcasey/JakeLint
Fix jake lint on Windows
2018-02-13 16:29:39 -08:00
Andrew Casey 9d39ee7302 Fix jake lint on Windows
We need to pass `windowsVerbatimArguments: true` to `jake.exec` or it
parses the arguments incorrectly and doesn't actually lint.
2018-02-13 16:07:49 -08:00
Nathan Shively-Sanders 76a9ac4434 Restrict declaration initializers too 2018-02-13 15:52:35 -08:00
Nathan Shively-Sanders 88c67fa777 Refactor binder and update baselines.
Also improve assert message in fourslash.
2018-02-13 15:44:15 -08:00
Andy 8c2756fdf6 Support getting string literal completions based on a type argument constraint (#21168)
* Support getting string literal completions based on a type argument constraint

* Fix bug: look for require call before argument info

* Code review

* @sandersn code review

* Remove test cast

* Reduce completions.ts diff

* @weswigham review

* Remove getTypeArgumentConstraint's dependence on checkTypeArgumentConstraints

* Remove TODO
2018-02-13 15:18:26 -08:00
Nathan Shively-Sanders fc08e20da8 Correctly merge JS decls
Turns out merging was incorrect even for non-nested declarations, but
tests didn't catch it before.
2018-02-13 14:17:46 -08:00
Anders Hejlsberg f8a378a1d7 Merge pull request #21919 from Microsoft/mappedTypeModifiers
Improved control over mapped type modifiers
2018-02-13 11:21:07 -08:00
Anders Hejlsberg 57fe3473d1 Accept new baselines 2018-02-13 06:48:21 -08:00
Anders Hejlsberg 23162c2638 Add tests 2018-02-13 06:48:03 -08:00
Anders Hejlsberg 2cc1d735ec Add Required<T> to lib.d.ts 2018-02-13 06:47:52 -08:00
Anders Hejlsberg ebdd566c09 Accept baseline changes 2018-02-13 06:28:52 -08:00
Sheetal Nandi 274bb5dab4 Merge pull request #21910 from Microsoft/projectUpdateOnFileOpenClose
Fix for No Default project scenario
2018-02-13 06:21:05 -08:00
Sheetal Nandi d9d98cf11a Handle the delayed updates due to user action correctly when ensuring the project structure is upto date
Fixes #20629
2018-02-12 16:53:47 -08:00
Anders Hejlsberg a629acd8fd Allow +/- to prefix 'readonly' and '?' modifiers in mapped types 2018-02-12 16:20:49 -08:00
Andy 74f01abfcf Clean up findPrecedingToken and avoid returning whitespace-only jsx text token (#21903) 2018-02-12 14:42:16 -08:00
Anders Hejlsberg d07523e9e5 Merge pull request #21866 from Microsoft/fixIndexedAccessWildcard
Fix indexed access issue with conditional types
2018-02-12 14:18:44 -08:00
Adrian Leonhard 6ab5d97a5d Changed "Duplicate Identifier" to "enum cannot be merged..." (#18579)
* Changed "Duplicate Identifier" to "enum can only be merged..."
when either declaration of the identifier is an enum.

Partial (?) fix for #529

Not sure if the new test is necessary, all the cases seem to have been covered by others tests.

* picked a nit
2018-02-12 13:38:08 -08:00
Ron Buckton 2ff8fae5da Merge pull request #21900 from Microsoft/fix21620
Fix emit when binder treats exported const as namespace
2018-02-12 13:34:54 -08:00
Sheetal Nandi e702d90cfe Repro scenario for finding no project of #20629 2018-02-12 13:12:55 -08:00
Sheetal Nandi 6ca65b71b4 Refactoring project updates in openFile 2018-02-12 13:12:55 -08:00
Andy 458c12fa78 importFixes: Fix bug by using replaceNode and removing changeIdentifierToPropertyAccess (#21898) 2018-02-12 13:05:40 -08:00
Andy 20a6be67a0 Clarify assumptions in verifyImportFixAtPosition (#21899) 2018-02-12 13:05:13 -08:00
Ron Buckton 7a6a0673df Merge pull request #21897 from Microsoft/fix21626
Fix duplicate label in es2017 async function
2018-02-12 13:04:39 -08:00
Ron Buckton c84b7caa25 Fix emit when binder treats exported const as namespace 2018-02-12 13:02:47 -08:00
Ron Buckton 641f787006 Merge pull request #21896 from Microsoft/fix21878
Revert BOM emit change
2018-02-12 12:31:12 -08:00
Ron Buckton 6736ced51d Fix duplicate label in es2017 async function 2018-02-12 12:30:29 -08:00
Sheetal Nandi 2305f7b22a Merge pull request #21895 from Microsoft/jsxTagCompletion
Fix completion of jsx attributes in self closing element
2018-02-12 12:28:57 -08:00
Ron Buckton ea8f5158c2 Revert BOM emit change 2018-02-12 12:02:34 -08:00
Sheetal Nandi d6d9953f6d Fix completion of jsx attributes in self closing element
Fixes #21844
2018-02-12 11:57:20 -08:00
Andy fca3db440c Give MethodDeclaration and MethodSignature parent types (#21892)
* Give MethodDeclaration and MethodSignature parent types
* And fix code that used MethodDeclaration for parameter that might be a MethodSignature

* Move type check back inside checkGrammarArrowFunction
2018-02-12 11:56:44 -08:00