Since it's for telemetry, it prefers to return a stale value rather than
triggering file IO (though it will load the file if not even a stale
value is available).
* Initial version, doesn't work for primitives yet.
Need to find out why.
* Primitives now work, plus improve error message
null and void don't even parse without parameter names so they are not
tested.
* Codefix: Add names to nameless parameters
* Improve error wording
* Add detail to error message
Previously, type checking was turned off for all assignment
declarations. This is a problem when the declarations are annotated with
jsdoc types.
This PR checks assignment declarations, *except* for expando
initialisers. Expando initialisers are
1. Empty object types.
2. Function types.
3. Class types.
4. Non-empty object types when the assignment declaration kind is
prototype assignment or module.exports assignment.
* string|number inferences are low priority
Also, refactor unifyFromContext to explicitly handle priorities
* string/number/strnum are not mutually exclusive
* Assert that high/low can't apply to same element
* Slightly improve missing property errors
* Add missing quote
* Fix jsx case
* Add related span
* Fix crash (why can declarations be undefined)
* Only skip top elaboration when no variant message is provided
Fixes#20703 with solution suggested in https://github.com/Microsoft/TypeScript/issues/20703#issuecomment-361434795
Previously, `--isolatedModules` gave an error for any ambient const enum, which
meant that some third-party libraries would always give errors even if the
ambient const enums they declare were never used. Now, we only give an error
when an ambient const enum is referenced, which allows such libraries to still
be used as long as the const enums are never accessed.
Some nuances:
* As before, the error is only surfaced for *ambient* const enums. With
non-ambient const enums, we know that an `isolatedModules` build will emit the
enum and produce a plain reference rather than inlining the constant, so
everything will still work.
* I originally planned to do this check in the code path that inlines the
constant, but that code is only exercised at emit time, so, for example, the
TS language service wasn't giving an error in my editor. Instead, I do the
check at typecheck time next to another const-enum-related check.
* This can be a breaking change when using `skipLibCheck` because the error is
typically moved from a .d.ts file to a .ts file.
Testing done:
I ran this TS build on a large project of mine that previously had disabled
`isolatedModules` so I could use the `chalk` library. With `isolatedModules`
enabled, there was no longer an error in the chalk typedefs, and a reference to
the `Level` const enum produced an error in my editor.
Andrew Casey
Wesley Wigham
Klaus Meinhardt
Nathan Shively-Sanders
Andy
Daniel Rosenwasser
Aziz Khambati
TypeScript Bot
AnyhowStep
Sheetal Nandi
Alexander T
Caleb Sander
Daniel Rosenwasser
Michael Tang
Kagami Sascha Rosylight
Alan Pierce