330e33cdda
Ignore related info in diagnostic deduplication ( #50309 )
...
* Ignore related info in diagnostic deduplication
* Add another test
2022-08-16 09:28:59 -07:00
f24f74eb89
🔨 Fix missing "Implement interface" code fix for mapped types with implicit keyof T in their definition ( #49999 )
...
* ⚗️ Add test to verify code fix works when implementing a mapped type with indirect keyof
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com >
* 🔨 Add property as implementation for symbols that has no declaration
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com >
diff --git a/src/services/codefixes/helpers.ts b/src/services/codefixes/helpers.ts
index 94b64e57..a4c11fd5 100644
--- a/src/services/codefixes/helpers.ts
+++ b/src/services/codefixes/helpers.ts
@@ -60,21 +60,19 @@ namespace ts.codefix {
isAmbient = false,
): void {
const declarations = symbol.getDeclarations();
- if (!(declarations && declarations.length)) {
- return undefined;
- }
+ const declaration = declarations ? declarations[0] : undefined;
const checker = context.program.getTypeChecker();
const scriptTarget = getEmitScriptTarget(context.program.getCompilerOptions());
- const declaration = declarations[0];
+ const kind = declaration?.kind ?? SyntaxKind.PropertySignature;
const name = getSynthesizedDeepClone(getNameOfDeclaration(declaration), /*includeTrivia*/ false) as PropertyName;
- const visibilityModifier = createVisibilityModifier(getEffectiveModifierFlags(declaration));
+ const visibilityModifier = createVisibilityModifier(declaration ? getEffectiveModifierFlags(declaration) : ModifierFlags.None);
const modifiers = visibilityModifier ? factory.createNodeArray([visibilityModifier]) : undefined;
const type = checker.getWidenedType(checker.getTypeOfSymbolAtLocation(symbol, enclosingDeclaration));
const optional = !!(symbol.flags & SymbolFlags.Optional);
const ambient = !!(enclosingDeclaration.flags & NodeFlags.Ambient) || isAmbient;
const quotePreference = getQuotePreference(sourceFile, preferences);
- switch (declaration.kind) {
+ switch (kind) {
case SyntaxKind.PropertySignature:
case SyntaxKind.PropertyDeclaration:
const flags = quotePreference === QuotePreference.Single ? NodeBuilderFlags.UseSingleQuotesForStringLiteralType : undefined;
@@ -88,13 +86,16 @@ namespace ts.codefix {
}
addClassElement(factory.createPropertyDeclaration(
modifiers,
- name,
+ declaration ? name : symbol.getName(),
optional && (preserveOptional & PreserveOptionalFlags.Property) ? factory.createToken(SyntaxKind.QuestionToken) : undefined,
typeNode,
/*initializer*/ undefined));
break;
case SyntaxKind.GetAccessor:
case SyntaxKind.SetAccessor: {
+ if (!declarations) {
+ break;
+ }
let typeNode = checker.typeToTypeNode(type, enclosingDeclaration, /*flags*/ undefined, getNoopSymbolTrackerWithResolver(context));
const allAccessors = getAllAccessorDeclarations(declarations, declaration as AccessorDeclaration);
const orderedAccessors = allAccessors.secondAccessor
@@ -138,6 +139,10 @@ namespace ts.codefix {
// If there is more than one overload but no implementation signature
// (eg: an abstract method or interface declaration), there is a 1-1
// correspondence of declarations and signatures.
+ if (!declarations) {
+ break;
+ }
+
const signatures = checker.getSignaturesOfType(type, SignatureKind.Call);
if (!some(signatures)) {
break;
* 🔨 Improve code readability
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com >
diff --git a/src/services/codefixes/helpers.ts b/src/services/codefixes/helpers.ts
index 2f5c8703ab..aea0206a8a 100644
--- a/src/services/codefixes/helpers.ts
+++ b/src/services/codefixes/helpers.ts
@@ -60,7 +60,7 @@ namespace ts.codefix {
isAmbient = false,
): void {
const declarations = symbol.getDeclarations();
- const declaration = declarations ? declarations[0] : undefined;
+ const declaration = declarations?.[0];
const checker = context.program.getTypeChecker();
const scriptTarget = getEmitScriptTarget(context.program.getCompilerOptions());
const kind = declaration?.kind ?? SyntaxKind.PropertySignature;
@@ -93,9 +93,7 @@ namespace ts.codefix {
break;
case SyntaxKind.GetAccessor:
case SyntaxKind.SetAccessor: {
- if (!declarations) {
- break;
- }
+ Debug.assertIsDefined(declarations);
let typeNode = checker.typeToTypeNode(type, enclosingDeclaration, /*flags*/ undefined, getNoopSymbolTrackerWithResolver(context));
const allAccessors = getAllAccessorDeclarations(declarations, declaration as AccessorDeclaration);
const orderedAccessors = allAccessors.secondAccessor
@@ -139,10 +137,7 @@ namespace ts.codefix {
// If there is more than one overload but no implementation signature
// (eg: an abstract method or interface declaration), there is a 1-1
// correspondence of declarations and signatures.
- if (!declarations) {
- break;
- }
-
+ Debug.assertIsDefined(declarations);
const signatures = type.isUnion() ? flatMap(type.types, t => t.getCallSignatures()) : type.getCallSignatures();
if (!some(signatures)) {
break;
* 📜 Add comment regarding mapped type children's missing declaration
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com >
Signed-off-by: Babak K. Shandiz <babak.k.shandiz@gmail.com >
Co-authored-by: Andrew Branch <andrew@wheream.io >
2022-08-16 09:27:29 -07:00
90fa1c70c1
Update baseline after out-of-order merge ( #50320 )
2022-08-16 08:54:55 -07:00
9767f51758
Update package-lock.json
2022-08-16 06:06:30 +00:00
4e33e0eb6c
Make literal types not comparable to weak object types without property overlap ( #49865 )
2022-08-15 17:10:11 -07:00
64ee1e88e0
Strip literal freshness of contextually typed literals ( #49884 )
...
* Strip literal freshness of contextually typed literals
* Add more tests
2022-08-15 17:04:09 -07:00
9c1baeede6
On windows handle the long paths in realpathSync.native ( #50306 )
...
Fixes #49470
2022-08-15 16:57:47 -07:00
e989d840f1
Forward intersectionState flag when comparing indexed access constraints ( #50261 )
2022-08-15 16:10:32 -07:00
8a873de5cf
fix(49149): remove unneeded array overload to Object.freeze ( #50029 )
...
* fix(49149): remove unneeded array overload to Object.freeze
* chore: commit baseline changes
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com >
Co-authored-by: Andrew Branch <andrew@wheream.io >
2022-08-15 16:10:02 -07:00
61d8a8d7f3
fix(49629): fix crash in find-all-refs when using module.exports/export= with arrays/primitives ( #50291 )
2022-08-15 15:14:26 -07:00
bc52ff6f4b
Make React import fix not block component import fix ( #50307 )
...
* Stop React import fix from blocking component import fixes
* Add additional promote-type-only test
2022-08-15 13:13:41 -07:00
fd3c46b2f0
Fix export = error message to not have redundant language ( #50308 )
2022-08-15 13:13:33 -07:00
9f7c0cbad7
Run ESLint over our JS files, fix all lints ( #50172 )
2022-08-15 08:42:26 -07:00
03b12a6a45
LEGO: Merge pull request 50298
...
LEGO: Merge pull request 50298
2022-08-14 03:10:53 -07:00
656d6a57d2
Update package-lock.json
2022-08-14 06:06:50 +00:00
7f5600eec5
LEGO: Merge pull request 50295
...
LEGO: Merge pull request 50295
2022-08-13 05:07:02 -07:00
adf26ffa4b
Revert "Fixed an issue with contextual type for intersection properties ( #48668 )" ( #50279 )
...
This reverts commit 9236e39374
2022-08-12 10:24:50 -07:00
8783da8726
Update package-lock.json
2022-08-12 06:06:46 +00:00
b19741c65d
Report aggregate statistics for solution as well as some solution perf numbers ( #50267 )
...
* Report aggregate statistics for solution as well as some solution perf numbers
This change under --extendedDiagnostics aggregates the diagnostics from all projects built and reports it at the end. Apart from that it also outputs some measurements for work that happens in tsc --build like finding if projects are uptodate etc.
Also removes unnecessary node count per suggestion
* Apply suggestions from code review
Co-authored-by: Ron Buckton <ron.buckton@microsoft.com >
* Fix condition
* Remove extra time
Co-authored-by: Ron Buckton <ron.buckton@microsoft.com >
2022-08-11 13:20:48 -07:00
075ee3d4b6
refactor: follow gh-50257 JSX.IntrinsicClassAttributes logic ( #50271 )
2022-08-11 09:32:31 -07:00
9189e42b1c
Update package-lock.json
2022-08-11 06:06:47 +00:00
e2fbe19adf
fix: produceLKG does not work on Windows ( #50140 )
2022-08-10 20:12:17 -07:00
924c68ca95
use cache for program creation on watch mode. ( #49958 )
2022-08-10 16:56:54 -07:00
90cfbaee37
Make build info tolerant to json errors ( #50265 )
...
* Make build info tolerant to json errors
Fixes #49754
* Fix incorrect code
2022-08-10 16:44:35 -07:00
8a24fe75c9
Fix up code so we don't crash when TS itself is emitted with let/const ( #50151 )
2022-08-10 13:38:38 -07:00
b56483feb8
Remove shims project ( #50049 )
2022-08-10 11:49:59 -07:00
7f1dc78f54
Simplify normalizeSlashes ( #50154 )
2022-08-10 11:20:00 -07:00
5fbf3b04dc
Don't treat object properties as potential JS contructors without JSDoc class tag ( #49735 )
2022-08-10 11:19:19 -07:00
382f0c3af3
fix: crashes when JSX.IntrinsicClassAttributes is an alias type close GH-50254 ( #50257 )
2022-08-10 10:41:12 -07:00
3c3909b8d0
update baseline ( #50252 )
2022-08-10 01:52:59 -07:00
5f64ae878e
Update package-lock.json
2022-08-10 06:07:48 +00:00
35c6fbfee0
JSDoc @type tag optional parameters ( #48132 )
...
* JSDoc @type tag optional parameters
* Don't repeat isInJSFile() condition
* Exclude variable initializers
* Add tests for class methods
* Don't contextually type JS function declarations
* Update Baselines and/or Applied Lint Fixes
* Reword comment
Co-authored-by: TypeScript Bot <typescriptbot@microsoft.com >
2022-08-09 17:03:30 -07:00
2513a2d98c
Use binary search in file system cache ( #50163 )
...
* Use binary search in file system cache
Previously, we were linear searching a linear number of times, resulting in too many `toLowerCaseFileName` calls on Windows.
* Use SortedArray types for clarity
* Use insertSorted after making it return a flat
* Drop redundant undefined
* Correct copy-paste error
2022-08-09 16:47:07 -07:00
af90e703ab
feat(49903): omit declare on type declarations ( #49925 )
2022-08-09 16:38:42 -07:00
b94b299a11
fix CFA for BindingElement. #49759 ( #49836 )
...
* fix CFA for BindingElement. #49759
* fix Parameter
* fix controlFlowBindingPatternOrder
* fix bindParameterFlow
* add tests
* refactor
* refactor
* refactor
2022-08-09 16:37:39 -07:00
dd98c17b10
Merge multiple symbols even when re-exported ( #49987 )
...
* Merge multiple symbols even when re-exported
As far as I remember, the target of `mergeSymbol` needs to be a merged
symbol, not a symbol with a mergeId that points to mergedSymbol.
However, mergeSymbolTable didn't check for this.
I can't remember if symbol tables may contain
symbols-with-mergeId. If they can, then mergeSymbolTable needs to call
getMergedSymbol on the individual targets of the merge. That's what I
did in this PR.
* Call getMergeSymbol eagerly
On the source, not target, of mergeSymbolTable's contents
2022-08-09 16:36:53 -07:00
abc2a350e6
Fix System module export import = ( #49788 )
...
* Add more SystemJS test case
* Fix System module `export import =`
* Update test case
2022-08-09 16:31:02 -07:00
e5b400c162
Fix misleading Date constructor documentation (addresses #49350 ) ( #49649 )
...
* Update month parameter to monthIndex and add docs for Date constructor
Signed-off-by: jmorrison152 <jmorrison152@bloomberg.net >
* Add baseline changes
Signed-off-by: jmorrison152 <jmorrison152@bloomberg.net >
* Fix misleading Date constructor documentation (addresses #49350 ) (#73 )
* Update month parameter to monthIndex and add docs for Date constructor
Signed-off-by: jmorrison152 <jmorrison152@bloomberg.net >
* Add baseline changes
Signed-off-by: jmorrison152 <jmorrison152@bloomberg.net >
* Update baselines
2022-08-09 16:21:56 -07:00
f70cb769ef
feat(49928): Provide quick fix for a missing callback function ( #49930 )
...
* feat(49928): provide quick fix for a missing callback function
* remove addFunctionDeclarationFromSignature. fix formatting
* add tests
2022-08-09 15:28:03 -07:00
a123fc5ce4
feat(lib/es2015): Add typed overloads to Reflect ( #35608 )
...
Co-authored-by: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com >
2022-08-09 15:05:33 -07:00
19e2a310c0
feat(49834): Suggestion: filter enum member ids from their own jsdocs ( #49843 )
...
* feat(49834): omit self-referenced enum declaration in JsDoc
* change code style
2022-08-09 15:02:45 -07:00
6aa9b87f54
Bump version to 4.9. ( #50239 )
2022-08-09 13:33:52 -07:00
6d163dc736
Update package-lock.json
2022-08-09 06:06:46 +00:00
0e17dc7769
Fixed a false positive related to binding patterns and spread expressions ( #49684 )
...
* Fixed a false positive related to binding patterns and spread expressions
* Improve ancestor lookup when checking if an expression is spread into an object
* Fixed ancestor lookup for more node types
* Remove equality check for contextual types
* Reformat code
* Use `isWithinSpreadAssignment` flag + `objectsWithinSpread` cache instead of ancestor traversal
* Revert "Use `isWithinSpreadAssignment` flag + `objectsWithinSpread` cache instead of ancestor traversal"
This reverts commit be387e3bbf
2022-08-08 17:01:50 -07:00
71e8529228
LEGO: Merge pull request 50219
...
LEGO: Merge pull request 50219
2022-08-08 03:00:51 -07:00
4a98087e25
Update package-lock.json
2022-08-08 06:06:51 +00:00
363099482a
LEGO: Merge pull request 50212
...
LEGO: Merge pull request 50212
2022-08-07 04:59:36 -07:00
7e4259121b
Update package-lock.json
2022-08-07 06:06:32 +00:00
96fe0396a4
Update package-lock.json
2022-08-06 06:08:54 +00:00
bdb8514b82
Fix contextual typing on yield and return expressions in generator function ( #49736 )
...
* add tests and initial fix
* fix contextual return type in generator funcs
* fix return statement contextual typing
* filter using getiterationtypeofgeneratorfunctionreturntype
* update baselines
2022-08-05 11:24:43 -07:00
Andrew Branch
Babak K. Shandiz
TypeScript Bot
Sheetal Nandi
Wesley Wigham
Nicolas Rodriguez
Oleksandr T
Jake Bailey
Alex Hsu
Ryan Cavanaugh
Jack Works
Jack Bates
Andrew Casey
Zzzen
Nathan Shively-Sanders
magic-akari
Jack Morrison
ExE Boss
Daniel Rosenwasser
Mateusz Burzyński
Gabriela Araujo Britto