331b9bcfde
Use the correct source when skipping trivia
...
A custom `SourceMapSource` can optionally provide its own `skipTrivia`
function. If this is not provided then the compiler will use the default
function designed for TypeScript source files.
Previously, when calling this default function we were passing the current
`sourceMapSource` rather than the specified `source` whose trivia needs
to be skipped. This resulted in the `pos` being incorrectly calculated for
external source files that need mapping.
**Side note:**
There are actually two possible constructors available for creating
`SourceMapSource` objects. One of them defaults to an identity function
for the `skipTrivia` function if it is not provided (see
https://github.com/Microsoft/TypeScript/blob/49689894d747714d6b2b8461b9033020efec9625/src/compiler/utilities.ts#L6972-L6976 )
and the other one leaves the `skipTrivia` field `undefined` (see
https://github.com/Microsoft/TypeScript/blob/5fc8f1dd801dbacfe7e2d624f80b7a6a3868d180/src/services/services.ts#L776-L797 )
Unfortunately, it appears that the second of these two constructors is the
one available when importing the "typescript" module in node.js code.
2019-01-24 10:28:10 +00:00
d7601b755f
fix trailing comma should not allowed in dynamic import argument
2019-01-24 18:16:34 +08:00
2f6c65e691
Merge pull request #26653 from Kingwl/improve_type_arguments_parser_1
...
parse less than token rather than left shift in context of type argum…
2019-01-23 16:21:12 -08:00
ebebc9fdb6
Merge pull request #29546 from chrisrpatterson/update-badge-url
...
Updating badge url
2019-01-23 12:49:42 -08:00
41568ba7c6
Updating badge url
...
Updating the badge url to use the new url format.
2019-01-23 14:16:23 -05:00
73fe3fc0f5
Merge pull request #29532 from Microsoft/umdModuleGlobalMerge
...
Handle find all references for symbol merged with UMD module and global var
2019-01-23 11:13:58 -08:00
d42185373a
PR feedback
2019-01-23 10:48:17 -08:00
5ec1201e3a
exclude nested functions and classes at containingThis check
2019-01-23 19:36:00 +01:00
e1477b41b7
Fix lint error
2019-01-22 16:28:00 -08:00
c2e74ae96e
Merge pull request #29534 from Microsoft/fix29355
...
Fix crash in signatureHelp
2019-01-22 16:16:42 -08:00
60487dc7cb
Enable debug info by default when debugging the language server
2019-01-22 15:41:22 -08:00
76b78a4df5
Fix crash in signatureHelp
2019-01-22 15:02:30 -08:00
f0227ecb2c
Handle find all references for symbol merged with UMD module and global var
...
Fixes #29093
2019-01-22 14:52:39 -08:00
60639ce5a8
Replace most instances of getTextOfPropertyName in checker
2019-01-22 14:24:21 -08:00
b4b6e144ef
Merge branch 'master' into PropertyDeclarationExclamationToken
2019-01-22 23:36:43 +08:00
dbd58599f4
do not provide refactoring when it contains this
...
because this behaves differently in arrow than in function
2019-01-22 05:42:01 +01:00
52e94d2b80
Merge remote-tracking branch 'upstream/master' into m-lambda-to-fn
2019-01-22 05:10:32 +01:00
2ea0251709
Accept new baselines
2019-01-20 08:21:49 -08:00
cf479fc384
Add regression test for #29168
2019-01-20 08:21:41 -08:00
dbea08f9c8
Accept new baselines
2019-01-20 08:21:26 -08:00
60e7528ee6
No union type reductions in contextual types
2019-01-20 08:20:40 -08:00
dbfef5356c
Accept baseline changes
2019-01-19 10:34:48 -08:00
2e94f47602
Add tests
2019-01-19 10:34:38 -08:00
980a6817b3
Accept baseline API changes
2019-01-19 10:34:29 -08:00
ec30c20ec9
Validate const assertion operand
2019-01-19 10:25:41 -08:00
e38ac0d5a4
fix api
2019-01-20 02:17:09 +08:00
e8497096d8
Merge branch 'master' into improve_type_arguments_parser_1
2019-01-20 01:54:49 +08:00
bd290e6eed
add test for convert to named parameters refactoring
2019-01-18 16:54:57 -08:00
919ed79f3a
implement new parameter creation
2019-01-18 16:49:11 -08:00
3a2f6a3ed1
Merge pull request #29470 from amcasey/InterfaceImplementations
...
Don't treat interfaces as implementations
2019-01-18 16:28:49 -08:00
beb02703b8
Support '<const> xxx' and 'xxx as const'
2019-01-18 16:16:45 -08:00
0b1da02a62
Add missing return statements (ugh)
2019-01-18 16:02:13 -08:00
d38c616e29
Fix resolution of properties from prototype assignment in JS ( #29302 )
...
* fix type derived from prototype assignment
* accept new baselines
* remove direct intersection with object literal assigned to prototype
* add tests
* change webpack submodule commit
* fix submodule commits
* comment and simplify getJSDocTypeReference
* remove circularity guards that aren't hit anymore
2019-01-18 16:00:18 -08:00
0b366ce751
Address CR feedback
2019-01-18 14:47:58 -08:00
20285e66e9
Include all flow nodes made within try blocks as antecedents for catch or finally blocks ( #29466 )
...
* Include all flow nodes made within `try` blocks as antecedents for `catch` or `finally` blocks
* Fix typo
2019-01-18 14:43:31 -08:00
ef89d26dc8
Accept new baselines
2019-01-18 09:34:47 -08:00
2200d35385
Add tests
2019-01-18 09:34:38 -08:00
b317334c2a
Merge pull request #29447 from Microsoft/fixGulp
...
Fix gulp builds not building some targets, use LKG by default
2019-01-17 17:19:42 -08:00
c809002bd3
Accept new baselines
2019-01-17 17:17:03 -08:00
4163d2dee4
Add tests
2019-01-17 17:16:52 -08:00
bb1c91fac6
Remove literal freshness when contextual type is a literal type
2019-01-17 17:04:29 -08:00
737fda928c
Don't treat interfaces as implementations
...
...even if they're in ambient contexts. Same for type aliases.
2019-01-17 15:45:01 -08:00
addeff325b
Make the relationship between partial mapped types and the empty object not apply for subtype relationship ( #29384 )
2019-01-17 15:42:58 -08:00
b6ae492009
Add missing arity check on second inference pass ( #29386 )
2019-01-17 15:21:17 -08:00
da9feca0b0
Accept new baselines
2019-01-17 14:38:04 -08:00
1b4bce236e
Infer contextual types from return types through generic functions
2019-01-17 14:37:31 -08:00
9bd23652ef
Merge pull request #29161 from Microsoft/incrementalBuild
...
Supports incremental build in tsc --b --w mode
2019-01-17 13:44:48 -08:00
900d6f7c90
renames
2019-01-17 12:29:23 -08:00
5651789629
Fix #29457
...
Use allTypesAssignableToKind instead of isTypeAssignableToKind to
account for union types.
2019-01-17 20:03:46 +00:00
dbae2cba47
add missing type annotation
2019-01-17 11:54:43 -08:00
Pete Bacon Darwin
xiaofa
Ryan Cavanaugh
Chris Patterson
Sheetal Nandi
BigAru
Ron Buckton
kingwl
Anders Hejlsberg
Gabriela Britto
Andrew Casey
Pranav Senthilnathan
Wesley Wigham
Andrew Casey
Jack Williams