From f5f2d243720a73c177c07d41cec3f82f99ce5cbc Mon Sep 17 00:00:00 2001
From: Nathan Shively-Sanders <nathansa@microsoft.com>
Date: Wed, 7 Jun 2017 11:28:26 -0700
Subject: [PATCH] Add tests for JS-inferred rest parameters

---
 .../argumentsObjectCreatesRestForJs.ts        | 20 ++++++++++++++++++
 .../jsSelfReferencingArgumentsFunction.ts     |  8 +++++++
 .../signatureHelpCallExpressionJs.ts          | 21 ++++++++++++++-----
 3 files changed, 44 insertions(+), 5 deletions(-)
 create mode 100644 tests/cases/compiler/argumentsObjectCreatesRestForJs.ts
 create mode 100644 tests/cases/compiler/jsSelfReferencingArgumentsFunction.ts

diff --git a/tests/cases/compiler/argumentsObjectCreatesRestForJs.ts b/tests/cases/compiler/argumentsObjectCreatesRestForJs.ts
new file mode 100644
index 00000000000..4c3ca335d1d
--- /dev/null
+++ b/tests/cases/compiler/argumentsObjectCreatesRestForJs.ts
@@ -0,0 +1,20 @@
+// @checkJs: true
+// @allowJs: true
+// @Filename: main.js
+// @noemit: true
+function allRest() { arguments; }
+allRest();
+allRest(1, 2, 3);
+function someRest(x, y) { arguments; }
+someRest(); // x and y are still optional because they are in a JS file
+someRest(1, 2, 3);
+
+/**
+ * @param {number} x - a thing
+ */
+function jsdocced(x) { arguments; }
+jsdocced(1);
+
+function dontDoubleRest(x, ...y) { arguments; }
+dontDoubleRest(1, 2, 3);
+
diff --git a/tests/cases/compiler/jsSelfReferencingArgumentsFunction.ts b/tests/cases/compiler/jsSelfReferencingArgumentsFunction.ts
new file mode 100644
index 00000000000..386b88c9cd1
--- /dev/null
+++ b/tests/cases/compiler/jsSelfReferencingArgumentsFunction.ts
@@ -0,0 +1,8 @@
+// @Filename: foo.js
+// @noEmit: true
+// @allowJs: true
+// Test #16139
+function Foo() {
+    arguments;
+    return new Foo();
+}
diff --git a/tests/cases/fourslash/signatureHelpCallExpressionJs.ts b/tests/cases/fourslash/signatureHelpCallExpressionJs.ts
index e425196bd07..17045a74717 100644
--- a/tests/cases/fourslash/signatureHelpCallExpressionJs.ts
+++ b/tests/cases/fourslash/signatureHelpCallExpressionJs.ts
@@ -4,14 +4,25 @@
 // @allowJs: true
 
 // @Filename: main.js
-////function fnTest() { arguments; }
-////fnTest(/*1*/);
-////fnTest(1, 2, 3);
+////function allOptional() { arguments; }
+////allOptional(/*1*/);
+////allOptional(1, 2, 3);
+////function someOptional(x, y) { arguments; }
+////someOptional(/*2*/);
+////someOptional(1, 2, 3);
+////someOptional(); // no error here; x and y are optional in JS
 
 goTo.marker('1');
 verify.signatureHelpCountIs(1);
 verify.currentSignatureParameterCountIs(1);
-verify.currentSignatureHelpIs('fnTest(...args: any[]): void');
+verify.currentSignatureHelpIs('allOptional(...args: any[]): void');
 verify.currentParameterHelpArgumentNameIs('args');
 verify.currentParameterSpanIs("...args: any[]");
-verify.numberOfErrorsInCurrentFile(0);
\ No newline at end of file
+
+goTo.marker('2');
+verify.signatureHelpCountIs(1);
+verify.currentSignatureParameterCountIs(3);
+verify.currentSignatureHelpIs('someOptional(x: any, y: any, ...args: any[]): void');
+verify.currentParameterHelpArgumentNameIs('x');
+verify.currentParameterSpanIs("x: any");
+verify.numberOfErrorsInCurrentFile(0);