Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix comments on pull request

Browse Source
This commit is contained in:
Ryan Clarke
2018-11-07 21:43:02 -05:00
parent 2dc3c8e49f
commit ecb88f5a3e
10 changed files with 29 additions and 48 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/services/codefixes/addConvertToUnknownForNonOverlappingTypes.ts
+5 -20
View File
@@ -14,25 +14,10 @@ namespace ts.codefix {
function makeChange(changeTracker: textChanges.ChangeTracker, sourceFile: SourceFile, pos: number) {
const token = getTokenAtPosition(sourceFile, pos);
const asExpression = findAncestor<AsExpression>(token, isAsExpression)!;
if (!!asExpression) {
const nodeBeingConverted = asExpression.getChildAt(0);
const expressionBeingConverted = findAncestor<Expression>(nodeBeingConverted, isExpression)!;
Debug.assert(!!expressionBeingConverted, "Expected position to be owned by an expression.");
const replacement = createAsExpression(expressionBeingConverted, createKeywordTypeNode(SyntaxKind.UnknownKeyword));
changeTracker.replaceNode(sourceFile, expressionBeingConverted, replacement);
}
const typeAssertion = findAncestor<TypeAssertion>(token, isTypeAssertion)!;
if (!!typeAssertion) {
const nodeBeingConverted = typeAssertion.getLastToken();
const expressionBeingConverted = findAncestor<Expression>(nodeBeingConverted, isExpression)!;
Debug.assert(!!expressionBeingConverted, "Expected position to be owned by an expression.");
const replacement = createTypeAssertion(createKeywordTypeNode(SyntaxKind.UnknownKeyword), expressionBeingConverted);
changeTracker.replaceNode(sourceFile, expressionBeingConverted, replacement);
}
const assertion = Debug.assertDefined(findAncestor(token, (n): n is AsExpression | TypeAssertion => isAsExpression(n) || isTypeAssertion(n)));
const replacement = isAsExpression(assertion)
? createAsExpression(assertion.expression, createKeywordTypeNode(SyntaxKind.UnknownKeyword))
: createTypeAssertion(createKeywordTypeNode(SyntaxKind.UnknownKeyword), assertion.expression);
changeTracker.replaceNode(sourceFile, assertion.expression, replacement);
}
}