From e4e9fe741f69edf73e7e65753e9d5f05813b0cad Mon Sep 17 00:00:00 2001 From: Jake Bailey <5341706+jakebailey@users.noreply.github.com> Date: Tue, 24 Jun 2025 14:51:46 -0700 Subject: [PATCH] Fix bad JSON syntax in tests, use JSON.parse first for perf (#61901) --- src/compiler/utilities.ts | 15 ++++++++++++--- ...nFallback(moduleresolution=node16).errors.txt | 5 +++-- ...allback(moduleresolution=nodenext).errors.txt | 5 +++-- ...ionalPackageExports(module=node16).errors.txt | 5 +++-- ...JsConditionalPackageExports(module=node16).js | 5 +++-- ...ionalPackageExports(module=node18).errors.txt | 5 +++-- ...JsConditionalPackageExports(module=node18).js | 5 +++-- ...nalPackageExports(module=nodenext).errors.txt | 5 +++-- ...ConditionalPackageExports(module=nodenext).js | 5 +++-- ...ckagePatternExports(module=node16).errors.txt | 5 +++-- ...llowJsPackagePatternExports(module=node16).js | 5 +++-- ...ckagePatternExports(module=node18).errors.txt | 5 +++-- ...llowJsPackagePatternExports(module=node18).js | 5 +++-- ...agePatternExports(module=nodenext).errors.txt | 5 +++-- ...owJsPackagePatternExports(module=nodenext).js | 5 +++-- ...ternExportsTrailers(module=node16).errors.txt | 5 +++-- ...ckagePatternExportsTrailers(module=node16).js | 5 +++-- ...ternExportsTrailers(module=node18).errors.txt | 5 +++-- ...ckagePatternExportsTrailers(module=node18).js | 5 +++-- ...rnExportsTrailers(module=nodenext).errors.txt | 5 +++-- ...agePatternExportsTrailers(module=nodenext).js | 5 +++-- ...ionalPackageExports(module=node16).errors.txt | 5 +++-- ...esConditionalPackageExports(module=node16).js | 5 +++-- ...ionalPackageExports(module=node18).errors.txt | 5 +++-- ...esConditionalPackageExports(module=node18).js | 5 +++-- ...nalPackageExports(module=nodenext).errors.txt | 5 +++-- ...ConditionalPackageExports(module=nodenext).js | 5 +++-- ...ckagePatternExports(module=node16).errors.txt | 5 +++-- ...odulesPackagePatternExports(module=node16).js | 5 +++-- ...ckagePatternExports(module=node18).errors.txt | 5 +++-- ...odulesPackagePatternExports(module=node18).js | 5 +++-- ...agePatternExports(module=nodenext).errors.txt | 5 +++-- ...ulesPackagePatternExports(module=nodenext).js | 5 +++-- ...ternExportsTrailers(module=node16).errors.txt | 5 +++-- ...ckagePatternExportsTrailers(module=node16).js | 5 +++-- ...ternExportsTrailers(module=node18).errors.txt | 5 +++-- ...ckagePatternExportsTrailers(module=node18).js | 5 +++-- ...rnExportsTrailers(module=nodenext).errors.txt | 5 +++-- ...agePatternExportsTrailers(module=nodenext).js | 5 +++-- ...sTypesVersionPackageExports(module=node16).js | 7 ++++--- ...sTypesVersionPackageExports(module=node18).js | 7 ++++--- ...ypesVersionPackageExports(module=nodenext).js | 7 ++++--- .../reference/reactJsxReactResolvedNodeNext.js | 2 +- .../compiler/reactJsxReactResolvedNodeNext.tsx | 2 +- .../conditionalExportsResolutionFallback.ts | 4 ++-- .../selfNameModuleAugmentation.ts | 16 ++++++++-------- ...odeModulesAllowJsConditionalPackageExports.ts | 4 ++-- .../nodeModulesAllowJsPackagePatternExports.ts | 4 ++-- ...odulesAllowJsPackagePatternExportsTrailers.ts | 4 ++-- .../node/nodeModulesConditionalPackageExports.ts | 4 ++-- .../node/nodeModulesPackagePatternExports.ts | 4 ++-- .../nodeModulesPackagePatternExportsTrailers.ts | 4 ++-- .../nodeModulesTypesVersionPackageExports.ts | 6 +++--- ...nsPackageJsonExportsBundlerNoNodeCondition.ts | 2 +- ...pletionsPackageJsonExportsCustomConditions.ts | 2 +- ...nsPackageJsonImportsBundlerNoNodeCondition.ts | 2 +- ...pletionsPackageJsonImportsCustomConditions.ts | 2 +- 57 files changed, 169 insertions(+), 119 deletions(-) diff --git a/src/compiler/utilities.ts b/src/compiler/utilities.ts index d637d6919ee..cd7339cf8f9 100644 --- a/src/compiler/utilities.ts +++ b/src/compiler/utilities.ts @@ -7692,9 +7692,18 @@ export function base64decode(host: { base64decode?(input: string): string; } | u export function readJsonOrUndefined(path: string, hostOrText: { readFile(fileName: string): string | undefined; } | string): object | undefined { const jsonText = isString(hostOrText) ? hostOrText : hostOrText.readFile(path); if (!jsonText) return undefined; - // gracefully handle if readFile fails or returns not JSON - const result = parseConfigFileTextToJson(path, jsonText); - return !result.error ? result.config : undefined; + // Try strictly parsing first, then fall back to our (slower) + // parser that is resilient to comments/trailing commas. + // package.json files should never have these, but we + // have no way to communicate these issues in the first place. + let result = tryParseJson(jsonText); + if (result === undefined) { + const looseResult = parseConfigFileTextToJson(path, jsonText); + if (!looseResult.error) { + result = looseResult.config; + } + } + return result; } /** @internal */ diff --git a/tests/baselines/reference/conditionalExportsResolutionFallback(moduleresolution=node16).errors.txt b/tests/baselines/reference/conditionalExportsResolutionFallback(moduleresolution=node16).errors.txt index 0303c9003ce..e205e8b437d 100644 --- a/tests/baselines/reference/conditionalExportsResolutionFallback(moduleresolution=node16).errors.txt +++ b/tests/baselines/reference/conditionalExportsResolutionFallback(moduleresolution=node16).errors.txt @@ -10,7 +10,7 @@ error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolut ".": { "import": "./dist/index.mjs", "require": "./dist/index.js", - "types": "./dist/index.d.ts", + "types": "./dist/index.d.ts" } } } @@ -26,4 +26,5 @@ error TS5110: Option 'module' must be set to 'Node16' when option 'moduleResolut // Should be an untyped resolution to dep/dist/index.mjs, // but the first search is only for TS files, and when // there's no dist/index.d.mts, it continues looking for - // matching conditions and resolves via `types`. \ No newline at end of file + // matching conditions and resolves via `types`. + \ No newline at end of file diff --git a/tests/baselines/reference/conditionalExportsResolutionFallback(moduleresolution=nodenext).errors.txt b/tests/baselines/reference/conditionalExportsResolutionFallback(moduleresolution=nodenext).errors.txt index 5d08c641198..85cf980ae49 100644 --- a/tests/baselines/reference/conditionalExportsResolutionFallback(moduleresolution=nodenext).errors.txt +++ b/tests/baselines/reference/conditionalExportsResolutionFallback(moduleresolution=nodenext).errors.txt @@ -10,7 +10,7 @@ error TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResol ".": { "import": "./dist/index.mjs", "require": "./dist/index.js", - "types": "./dist/index.d.ts", + "types": "./dist/index.d.ts" } } } @@ -26,4 +26,5 @@ error TS5110: Option 'module' must be set to 'NodeNext' when option 'moduleResol // Should be an untyped resolution to dep/dist/index.mjs, // but the first search is only for TS files, and when // there's no dist/index.d.mts, it continues looking for - // matching conditions and resolves via `types`. \ No newline at end of file + // matching conditions and resolves via `types`. + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node16).errors.txt b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node16).errors.txt index af5e14950e1..0988bb97664 100644 --- a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node16).errors.txt +++ b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node16).errors.txt @@ -126,7 +126,7 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -134,4 +134,5 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import } } } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node16).js b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node16).js index 89094051db9..62fb2abec91 100644 --- a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node16).js +++ b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node16).js @@ -112,7 +112,7 @@ export const cjsSource = true; "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -120,7 +120,8 @@ export const cjsSource = true; } } } -} +} + //// [index.mjs] // esm format file diff --git a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node18).errors.txt b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node18).errors.txt index af5e14950e1..0988bb97664 100644 --- a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node18).errors.txt +++ b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node18).errors.txt @@ -126,7 +126,7 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -134,4 +134,5 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import } } } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node18).js b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node18).js index 89094051db9..62fb2abec91 100644 --- a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node18).js +++ b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=node18).js @@ -112,7 +112,7 @@ export const cjsSource = true; "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -120,7 +120,8 @@ export const cjsSource = true; } } } -} +} + //// [index.mjs] // esm format file diff --git a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=nodenext).errors.txt b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=nodenext).errors.txt index 643335c3830..fc4e33b7310 100644 --- a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=nodenext).errors.txt +++ b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=nodenext).errors.txt @@ -120,7 +120,7 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -128,4 +128,5 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import } } } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=nodenext).js b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=nodenext).js index 89094051db9..62fb2abec91 100644 --- a/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=nodenext).js +++ b/tests/baselines/reference/nodeModulesAllowJsConditionalPackageExports(module=nodenext).js @@ -112,7 +112,7 @@ export const cjsSource = true; "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -120,7 +120,8 @@ export const cjsSource = true; } } } -} +} + //// [index.mjs] // esm format file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node16).errors.txt b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node16).errors.txt index 37254a32db0..fb9aef2c45c 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node16).errors.txt +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node16).errors.txt @@ -64,7 +64,7 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -75,4 +75,5 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ "./mjs/*": "./*.mjs", "./js/*": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node16).js b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node16).js index 79669dc7d4d..0c82c6e77b0 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node16).js +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node16).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*": "./*.mjs", "./js/*": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node18).errors.txt b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node18).errors.txt index 37254a32db0..fb9aef2c45c 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node18).errors.txt +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node18).errors.txt @@ -64,7 +64,7 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -75,4 +75,5 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ "./mjs/*": "./*.mjs", "./js/*": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node18).js b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node18).js index 79669dc7d4d..0c82c6e77b0 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node18).js +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=node18).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*": "./*.mjs", "./js/*": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=nodenext).errors.txt b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=nodenext).errors.txt index ec89adcd2ff..17ac25641f9 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=nodenext).errors.txt +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=nodenext).errors.txt @@ -55,7 +55,7 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -66,4 +66,5 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import "./mjs/*": "./*.mjs", "./js/*": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=nodenext).js b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=nodenext).js index 79669dc7d4d..0c82c6e77b0 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=nodenext).js +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExports(module=nodenext).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*": "./*.mjs", "./js/*": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node16).errors.txt b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node16).errors.txt index dbaadfd82f5..d2ca255ec35 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node16).errors.txt +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node16).errors.txt @@ -64,7 +64,7 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -75,4 +75,5 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node16).js b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node16).js index b23d73a88c0..5c434e98472 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node16).js +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node16).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node18).errors.txt b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node18).errors.txt index dbaadfd82f5..d2ca255ec35 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node18).errors.txt +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node18).errors.txt @@ -64,7 +64,7 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -75,4 +75,5 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node18).js b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node18).js index b23d73a88c0..5c434e98472 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node18).js +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=node18).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).errors.txt b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).errors.txt index 6c025f4ba77..20a391524c9 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).errors.txt +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).errors.txt @@ -55,7 +55,7 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -66,4 +66,5 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).js b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).js index b23d73a88c0..5c434e98472 100644 --- a/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).js +++ b/tests/baselines/reference/nodeModulesAllowJsPackagePatternExportsTrailers(module=nodenext).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node16).errors.txt b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node16).errors.txt index 41703e1cf0c..06c79e025ad 100644 --- a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node16).errors.txt +++ b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node16).errors.txt @@ -126,7 +126,7 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -134,4 +134,5 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import } } } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node16).js b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node16).js index 8bf4f316a59..7948f14a955 100644 --- a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node16).js +++ b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node16).js @@ -112,7 +112,7 @@ export const cjsSource = true; "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -120,7 +120,8 @@ export const cjsSource = true; } } } -} +} + //// [index.mjs] // esm format file diff --git a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node18).errors.txt b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node18).errors.txt index 41703e1cf0c..06c79e025ad 100644 --- a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node18).errors.txt +++ b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node18).errors.txt @@ -126,7 +126,7 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -134,4 +134,5 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import } } } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node18).js b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node18).js index 8bf4f316a59..7948f14a955 100644 --- a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node18).js +++ b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=node18).js @@ -112,7 +112,7 @@ export const cjsSource = true; "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -120,7 +120,8 @@ export const cjsSource = true; } } } -} +} + //// [index.mjs] // esm format file diff --git a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=nodenext).errors.txt b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=nodenext).errors.txt index d078baf601f..9065db099d6 100644 --- a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=nodenext).errors.txt +++ b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=nodenext).errors.txt @@ -120,7 +120,7 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -128,4 +128,5 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import } } } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=nodenext).js b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=nodenext).js index 8bf4f316a59..7948f14a955 100644 --- a/tests/baselines/reference/nodeModulesConditionalPackageExports(module=nodenext).js +++ b/tests/baselines/reference/nodeModulesConditionalPackageExports(module=nodenext).js @@ -112,7 +112,7 @@ export const cjsSource = true; "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -120,7 +120,8 @@ export const cjsSource = true; } } } -} +} + //// [index.mjs] // esm format file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExports(module=node16).errors.txt b/tests/baselines/reference/nodeModulesPackagePatternExports(module=node16).errors.txt index 624ebe11778..41f789f7b29 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExports(module=node16).errors.txt +++ b/tests/baselines/reference/nodeModulesPackagePatternExports(module=node16).errors.txt @@ -64,7 +64,7 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -75,4 +75,5 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ "./mjs/*": "./*.mjs", "./js/*": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExports(module=node16).js b/tests/baselines/reference/nodeModulesPackagePatternExports(module=node16).js index f710ad1fe43..16d7442eb7f 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExports(module=node16).js +++ b/tests/baselines/reference/nodeModulesPackagePatternExports(module=node16).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*": "./*.mjs", "./js/*": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExports(module=node18).errors.txt b/tests/baselines/reference/nodeModulesPackagePatternExports(module=node18).errors.txt index 624ebe11778..41f789f7b29 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExports(module=node18).errors.txt +++ b/tests/baselines/reference/nodeModulesPackagePatternExports(module=node18).errors.txt @@ -64,7 +64,7 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -75,4 +75,5 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ "./mjs/*": "./*.mjs", "./js/*": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExports(module=node18).js b/tests/baselines/reference/nodeModulesPackagePatternExports(module=node18).js index f710ad1fe43..16d7442eb7f 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExports(module=node18).js +++ b/tests/baselines/reference/nodeModulesPackagePatternExports(module=node18).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*": "./*.mjs", "./js/*": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExports(module=nodenext).errors.txt b/tests/baselines/reference/nodeModulesPackagePatternExports(module=nodenext).errors.txt index af540307689..8fb721949b1 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExports(module=nodenext).errors.txt +++ b/tests/baselines/reference/nodeModulesPackagePatternExports(module=nodenext).errors.txt @@ -55,7 +55,7 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -66,4 +66,5 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import "./mjs/*": "./*.mjs", "./js/*": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExports(module=nodenext).js b/tests/baselines/reference/nodeModulesPackagePatternExports(module=nodenext).js index f710ad1fe43..16d7442eb7f 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExports(module=nodenext).js +++ b/tests/baselines/reference/nodeModulesPackagePatternExports(module=nodenext).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*": "./*.mjs", "./js/*": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node16).errors.txt b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node16).errors.txt index 0ec3660afe0..489a0cf39f7 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node16).errors.txt +++ b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node16).errors.txt @@ -64,7 +64,7 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -75,4 +75,5 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node16).js b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node16).js index 18a9e37f040..7e40184e6af 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node16).js +++ b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node16).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node18).errors.txt b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node18).errors.txt index 0ec3660afe0..489a0cf39f7 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node18).errors.txt +++ b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node18).errors.txt @@ -64,7 +64,7 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -75,4 +75,5 @@ node_modules/inner/index.d.ts(3,22): error TS1479: The current file is a CommonJ "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node18).js b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node18).js index 18a9e37f040..7e40184e6af 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node18).js +++ b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=node18).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=nodenext).errors.txt b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=nodenext).errors.txt index 60c35df075b..33adbe04581 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=nodenext).errors.txt +++ b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=nodenext).errors.txt @@ -55,7 +55,7 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import { "name": "package", "private": true, - "type": "module", + "type": "module" } ==== node_modules/inner/package.json (0 errors) ==== { @@ -66,4 +66,5 @@ node_modules/inner/index.d.ts(2,13): error TS2303: Circular definition of import "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } - } \ No newline at end of file + } + \ No newline at end of file diff --git a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=nodenext).js b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=nodenext).js index 18a9e37f040..7e40184e6af 100644 --- a/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=nodenext).js +++ b/tests/baselines/reference/nodeModulesPackagePatternExportsTrailers(module=nodenext).js @@ -52,7 +52,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -63,7 +63,8 @@ export { type }; "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=node16).js b/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=node16).js index fe34ab0566b..0a09964a041 100644 --- a/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=node16).js +++ b/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=node16).js @@ -34,7 +34,7 @@ export const futureVersionApplied = true; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -47,9 +47,10 @@ export const futureVersionApplied = true; "types": "./old-types.d.ts", "import": "./index.mjs", "node": "./index.js" - }, + } } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=node18).js b/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=node18).js index fe34ab0566b..0a09964a041 100644 --- a/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=node18).js +++ b/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=node18).js @@ -34,7 +34,7 @@ export const futureVersionApplied = true; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -47,9 +47,10 @@ export const futureVersionApplied = true; "types": "./old-types.d.ts", "import": "./index.mjs", "node": "./index.js" - }, + } } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=nodenext).js b/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=nodenext).js index fe34ab0566b..0a09964a041 100644 --- a/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=nodenext).js +++ b/tests/baselines/reference/nodeModulesTypesVersionPackageExports(module=nodenext).js @@ -34,7 +34,7 @@ export const futureVersionApplied = true; { "name": "package", "private": true, - "type": "module", + "type": "module" } //// [package.json] { @@ -47,9 +47,10 @@ export const futureVersionApplied = true; "types": "./old-types.d.ts", "import": "./index.mjs", "node": "./index.js" - }, + } } -} +} + //// [index.js] // esm format file diff --git a/tests/baselines/reference/reactJsxReactResolvedNodeNext.js b/tests/baselines/reference/reactJsxReactResolvedNodeNext.js index f36fdc66c2a..4c003789871 100644 --- a/tests/baselines/reference/reactJsxReactResolvedNodeNext.js +++ b/tests/baselines/reference/reactJsxReactResolvedNodeNext.js @@ -7,7 +7,7 @@ export const a =
; "name": "@types/react", "version": "0.0.1", "main": "", - "types": "index.d.ts", + "types": "index.d.ts" } //// [index.d.ts] declare namespace JSX { diff --git a/tests/cases/compiler/reactJsxReactResolvedNodeNext.tsx b/tests/cases/compiler/reactJsxReactResolvedNodeNext.tsx index 0cc64eda70a..d240e627360 100644 --- a/tests/cases/compiler/reactJsxReactResolvedNodeNext.tsx +++ b/tests/cases/compiler/reactJsxReactResolvedNodeNext.tsx @@ -8,7 +8,7 @@ export const a = ; "name": "@types/react", "version": "0.0.1", "main": "", - "types": "index.d.ts", + "types": "index.d.ts" } // @filename: node_modules/@types/react/index.d.ts declare namespace JSX { diff --git a/tests/cases/conformance/moduleResolution/conditionalExportsResolutionFallback.ts b/tests/cases/conformance/moduleResolution/conditionalExportsResolutionFallback.ts index 26fe08e88fb..2076f434272 100644 --- a/tests/cases/conformance/moduleResolution/conditionalExportsResolutionFallback.ts +++ b/tests/cases/conformance/moduleResolution/conditionalExportsResolutionFallback.ts @@ -15,7 +15,7 @@ ".": { "import": "./dist/index.mjs", "require": "./dist/index.js", - "types": "./dist/index.d.ts", + "types": "./dist/index.d.ts" } } } @@ -31,4 +31,4 @@ import {} from "dep"; // Should be an untyped resolution to dep/dist/index.mjs, // but the first search is only for TS files, and when // there's no dist/index.d.mts, it continues looking for -// matching conditions and resolves via `types`. \ No newline at end of file +// matching conditions and resolves via `types`. diff --git a/tests/cases/conformance/moduleResolution/selfNameModuleAugmentation.ts b/tests/cases/conformance/moduleResolution/selfNameModuleAugmentation.ts index a602cb2e284..c4f12e77d58 100644 --- a/tests/cases/conformance/moduleResolution/selfNameModuleAugmentation.ts +++ b/tests/cases/conformance/moduleResolution/selfNameModuleAugmentation.ts @@ -4,6 +4,14 @@ // @noEmit: true // @traceResolution: true +// The correct behavior for this test would be for both the module augmentation +// and the import to resolve to `walk.mjs` (triggering at least one implicit any +// error, I think?). However, https://github.com/microsoft/TypeScript/issues/50762 +// causes the import to resolve through the `default` condition, replacing `.js` +// with `.d.ts` to find `walk.d.ts`. While this is incorrect, it's important that +// the module augmentation, which resolves through self-name resolution, resolves +// to the same module as the external import. + // @Filename: /node_modules/acorn-walk/package.json { "name": "acorn-walk", @@ -23,14 +31,6 @@ } } -// The correct behavior for this test would be for both the module augmentation -// and the import to resolve to `walk.mjs` (triggering at least one implicit any -// error, I think?). However, https://github.com/microsoft/TypeScript/issues/50762 -// causes the import to resolve through the `default` condition, replacing `.js` -// with `.d.ts` to find `walk.d.ts`. While this is incorrect, it's important that -// the module augmentation, which resolves through self-name resolution, resolves -// to the same module as the external import. - // @Filename: /node_modules/acorn-walk/dist/walk.d.ts export {}; declare module 'acorn-walk' { diff --git a/tests/cases/conformance/node/allowJs/nodeModulesAllowJsConditionalPackageExports.ts b/tests/cases/conformance/node/allowJs/nodeModulesAllowJsConditionalPackageExports.ts index 46244891913..790eb8f985f 100644 --- a/tests/cases/conformance/node/allowJs/nodeModulesAllowJsConditionalPackageExports.ts +++ b/tests/cases/conformance/node/allowJs/nodeModulesAllowJsConditionalPackageExports.ts @@ -115,7 +115,7 @@ export const cjsSource = true; "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -123,4 +123,4 @@ export const cjsSource = true; } } } -} \ No newline at end of file +} diff --git a/tests/cases/conformance/node/allowJs/nodeModulesAllowJsPackagePatternExports.ts b/tests/cases/conformance/node/allowJs/nodeModulesAllowJsPackagePatternExports.ts index 8579530d195..74555b43239 100644 --- a/tests/cases/conformance/node/allowJs/nodeModulesAllowJsPackagePatternExports.ts +++ b/tests/cases/conformance/node/allowJs/nodeModulesAllowJsPackagePatternExports.ts @@ -55,7 +55,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } // @filename: node_modules/inner/package.json { @@ -66,4 +66,4 @@ export { type }; "./mjs/*": "./*.mjs", "./js/*": "./*.js" } -} \ No newline at end of file +} diff --git a/tests/cases/conformance/node/allowJs/nodeModulesAllowJsPackagePatternExportsTrailers.ts b/tests/cases/conformance/node/allowJs/nodeModulesAllowJsPackagePatternExportsTrailers.ts index 9fd48761935..ff46df8d4cf 100644 --- a/tests/cases/conformance/node/allowJs/nodeModulesAllowJsPackagePatternExportsTrailers.ts +++ b/tests/cases/conformance/node/allowJs/nodeModulesAllowJsPackagePatternExportsTrailers.ts @@ -55,7 +55,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } // @filename: node_modules/inner/package.json { @@ -66,4 +66,4 @@ export { type }; "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } -} \ No newline at end of file +} diff --git a/tests/cases/conformance/node/nodeModulesConditionalPackageExports.ts b/tests/cases/conformance/node/nodeModulesConditionalPackageExports.ts index 1ccd7940cd0..8250d95ca41 100644 --- a/tests/cases/conformance/node/nodeModulesConditionalPackageExports.ts +++ b/tests/cases/conformance/node/nodeModulesConditionalPackageExports.ts @@ -113,7 +113,7 @@ export const cjsSource = true; "./types": { "types": { "import": "./index.d.mts", - "require": "./index.d.cts", + "require": "./index.d.cts" }, "node": { "import": "./index.mjs", @@ -121,4 +121,4 @@ export const cjsSource = true; } } } -} \ No newline at end of file +} diff --git a/tests/cases/conformance/node/nodeModulesPackagePatternExports.ts b/tests/cases/conformance/node/nodeModulesPackagePatternExports.ts index 66cc8dcb507..3bb9cd5bf12 100644 --- a/tests/cases/conformance/node/nodeModulesPackagePatternExports.ts +++ b/tests/cases/conformance/node/nodeModulesPackagePatternExports.ts @@ -53,7 +53,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } // @filename: node_modules/inner/package.json { @@ -64,4 +64,4 @@ export { type }; "./mjs/*": "./*.mjs", "./js/*": "./*.js" } -} \ No newline at end of file +} diff --git a/tests/cases/conformance/node/nodeModulesPackagePatternExportsTrailers.ts b/tests/cases/conformance/node/nodeModulesPackagePatternExportsTrailers.ts index e367cc8e25d..3eb68acc5e7 100644 --- a/tests/cases/conformance/node/nodeModulesPackagePatternExportsTrailers.ts +++ b/tests/cases/conformance/node/nodeModulesPackagePatternExportsTrailers.ts @@ -54,7 +54,7 @@ export { type }; { "name": "package", "private": true, - "type": "module", + "type": "module" } // @filename: node_modules/inner/package.json { @@ -65,4 +65,4 @@ export { type }; "./mjs/*.mjs": "./*.mjs", "./js/*.js": "./*.js" } -} \ No newline at end of file +} diff --git a/tests/cases/conformance/node/nodeModulesTypesVersionPackageExports.ts b/tests/cases/conformance/node/nodeModulesTypesVersionPackageExports.ts index f562c69ba06..706a47a7fea 100644 --- a/tests/cases/conformance/node/nodeModulesTypesVersionPackageExports.ts +++ b/tests/cases/conformance/node/nodeModulesTypesVersionPackageExports.ts @@ -35,7 +35,7 @@ export const futureVersionApplied = true; { "name": "package", "private": true, - "type": "module", + "type": "module" } // @filename: node_modules/inner/package.json { @@ -48,6 +48,6 @@ export const futureVersionApplied = true; "types": "./old-types.d.ts", "import": "./index.mjs", "node": "./index.js" - }, + } } -} \ No newline at end of file +} diff --git a/tests/cases/fourslash/pathCompletionsPackageJsonExportsBundlerNoNodeCondition.ts b/tests/cases/fourslash/pathCompletionsPackageJsonExportsBundlerNoNodeCondition.ts index 13134b69605..e6bd5dc3a64 100644 --- a/tests/cases/fourslash/pathCompletionsPackageJsonExportsBundlerNoNodeCondition.ts +++ b/tests/cases/fourslash/pathCompletionsPackageJsonExportsBundlerNoNodeCondition.ts @@ -9,7 +9,7 @@ //// "./only-for-node": { //// "node": "./something.js" //// }, -//// "./for-everywhere": "./other.js", +//// "./for-everywhere": "./other.js" //// } //// } diff --git a/tests/cases/fourslash/pathCompletionsPackageJsonExportsCustomConditions.ts b/tests/cases/fourslash/pathCompletionsPackageJsonExportsCustomConditions.ts index 6a29928fc62..6510e93c14e 100644 --- a/tests/cases/fourslash/pathCompletionsPackageJsonExportsCustomConditions.ts +++ b/tests/cases/fourslash/pathCompletionsPackageJsonExportsCustomConditions.ts @@ -9,7 +9,7 @@ //// "exports": { //// "./only-with-custom-conditions": { //// "custom-condition": "./something.js" -//// }, +//// } //// } //// } diff --git a/tests/cases/fourslash/pathCompletionsPackageJsonImportsBundlerNoNodeCondition.ts b/tests/cases/fourslash/pathCompletionsPackageJsonImportsBundlerNoNodeCondition.ts index 324c51f0a69..0b4f1179336 100644 --- a/tests/cases/fourslash/pathCompletionsPackageJsonImportsBundlerNoNodeCondition.ts +++ b/tests/cases/fourslash/pathCompletionsPackageJsonImportsBundlerNoNodeCondition.ts @@ -9,7 +9,7 @@ //// "#only-for-node": { //// "node": "./something.js" //// }, -//// "#for-everywhere": "./other.js", +//// "#for-everywhere": "./other.js" //// } //// } diff --git a/tests/cases/fourslash/pathCompletionsPackageJsonImportsCustomConditions.ts b/tests/cases/fourslash/pathCompletionsPackageJsonImportsCustomConditions.ts index 3a11faf9dae..82ffb4edeec 100644 --- a/tests/cases/fourslash/pathCompletionsPackageJsonImportsCustomConditions.ts +++ b/tests/cases/fourslash/pathCompletionsPackageJsonImportsCustomConditions.ts @@ -9,7 +9,7 @@ //// "imports": { //// "#only-with-custom-conditions": { //// "custom-condition": "./something.js" -//// }, +//// } //// } //// }