From e2eb319e72af041aa49cc1f99b1816a0a33f6653 Mon Sep 17 00:00:00 2001 From: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> Date: Fri, 7 Aug 2020 09:47:57 -0700 Subject: [PATCH] Just check all declarations, don't call isUncalledFunction --- src/compiler/checker.ts | 2 +- tests/cases/fourslash/jsdocDeprecated_suggestion9.ts | 11 +++++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) create mode 100644 tests/cases/fourslash/jsdocDeprecated_suggestion9.ts diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index f9c6a04324a..748cab985da 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -35323,7 +35323,7 @@ namespace ts { error(node, Diagnostics.Re_exporting_a_type_when_the_isolatedModules_flag_is_provided_requires_using_export_type); } - if (isImportSpecifier(node) && isUncalledFunctionReference(target.valueDeclaration, target)) { + if (isImportSpecifier(node) && every(target.declarations, d => !!(getCombinedNodeFlags(d) & NodeFlags.Deprecated))) { errorOrSuggestion(/* isError */ false, node.name, Diagnostics._0_is_deprecated, symbol.escapedName as string); } } diff --git a/tests/cases/fourslash/jsdocDeprecated_suggestion9.ts b/tests/cases/fourslash/jsdocDeprecated_suggestion9.ts new file mode 100644 index 00000000000..bf5ef1b12da --- /dev/null +++ b/tests/cases/fourslash/jsdocDeprecated_suggestion9.ts @@ -0,0 +1,11 @@ +/// + +// @Filename: first.ts +//// export class logger { } +// @Filename: second.ts +//// import { logger } from './first'; +//// new logger() + +goTo.file('second.ts') +verify.noErrors() +verify.getSuggestionDiagnostics([]);