Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix crash on duplicate default exports

Browse Source
This commit is contained in:
Andrew Branch
2020-04-30 10:45:04 -07:00
parent 10fc8c379f
commit d6477f9167
4 changed files with 67 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/compiler/binder.ts
+1 -1
View File
@@ -413,7 +413,7 @@ namespace ts {
function declareSymbol(symbolTable: SymbolTable, parent: Symbol | undefined, node: Declaration, includes: SymbolFlags, excludes: SymbolFlags, isReplaceableByMethod?: boolean): Symbol {
Debug.assert(!hasDynamicName(node));
const isDefaultExport = hasModifier(node, ModifierFlags.Default);
const isDefaultExport = hasModifier(node, ModifierFlags.Default) || isExportSpecifier(node) && node.name.escapedText === "default";
// The exported symbol for an export default function/class node is always named "default"
const name = isDefaultExport && parent ? InternalSymbolName.Default : getDeclarationName(node);
tests/baselines/reference/exportDefaultDuplicateCrash.errors.txt
+34
View File
@@ -0,0 +1,34 @@
tests/cases/compiler/exportDefaultDuplicateCrash.ts(3,1): error TS2323: Cannot redeclare exported variable 'default'.
tests/cases/compiler/exportDefaultDuplicateCrash.ts(3,1): error TS2528: A module cannot have multiple default exports.
tests/cases/compiler/exportDefaultDuplicateCrash.ts(4,10): error TS2323: Cannot redeclare exported variable 'default'.
tests/cases/compiler/exportDefaultDuplicateCrash.ts(4,10): error TS2528: A module cannot have multiple default exports.
tests/cases/compiler/exportDefaultDuplicateCrash.ts(4,25): error TS2307: Cannot find module './hi' or its corresponding type declarations.
tests/cases/compiler/exportDefaultDuplicateCrash.ts(5,16): error TS2528: A module cannot have multiple default exports.
tests/cases/compiler/exportDefaultDuplicateCrash.ts(5,31): error TS2307: Cannot find module './hi' or its corresponding type declarations.
==== tests/cases/compiler/exportDefaultDuplicateCrash.ts (7 errors) ====
// #38214
export default function () { }
~~~~~~
!!! error TS2323: Cannot redeclare exported variable 'default'.
~~~~~~
!!! error TS2528: A module cannot have multiple default exports.
!!! related TS2753 tests/cases/compiler/exportDefaultDuplicateCrash.ts:5:16: Another export default is here.
export { default } from './hi'
~~~~~~~
!!! error TS2323: Cannot redeclare exported variable 'default'.
~~~~~~~
!!! error TS2528: A module cannot have multiple default exports.
!!! related TS6204 tests/cases/compiler/exportDefaultDuplicateCrash.ts:5:16: and here.
~~~~~~
!!! error TS2307: Cannot find module './hi' or its corresponding type declarations.
export { aa as default } from './hi'
~~~~~~~
!!! error TS2528: A module cannot have multiple default exports.
!!! related TS2752 tests/cases/compiler/exportDefaultDuplicateCrash.ts:3:1: The first export default is here.
!!! related TS2752 tests/cases/compiler/exportDefaultDuplicateCrash.ts:4:10: The first export default is here.
~~~~~~
!!! error TS2307: Cannot find module './hi' or its corresponding type declarations.
tests/baselines/reference/exportDefaultDuplicateCrash.js
+25
View File
@@ -0,0 +1,25 @@
//// [exportDefaultDuplicateCrash.ts]
// #38214
export default function () { }
export { default } from './hi'
export { aa as default } from './hi'
//// [exportDefaultDuplicateCrash.js]
"use strict";
// #38214
var __createBinding = (this && this.__createBinding) || (Object.create ? (function(o, m, k, k2) {
if (k2 === undefined) k2 = k;
Object.defineProperty(o, k2, { enumerable: true, get: function() { return m[k]; } });
}) : (function(o, m, k, k2) {
if (k2 === undefined) k2 = k;
o[k2] = m[k];
}));
exports.__esModule = true;
function default_1() { }
exports["default"] = default_1;
var hi_1 = require("./hi");
__createBinding(exports, hi_1, "default");
var hi_2 = require("./hi");
__createBinding(exports, hi_2, "aa", "default");
tests/cases/compiler/exportDefaultDuplicateCrash.ts
+7
View File
@@ -0,0 +1,7 @@
// @noTypesAndSymbols: true
// #38214
export default function () { }
export { default } from './hi'
export { aa as default } from './hi'