Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix/jsx global preferred over config implicit (#41476) (#41583)

Browse Source 
* Add actual baselines for a problem with global namespace being preferred over config & pragma implicit ones

* Fixed an issue with global React namespace being preferred over config & pragma implicit ones

* Do not try to mark JSX classic runtime symbols as used when automatic runtime is used

Co-authored-by: Mateusz Burzyński <mateuszburzynski@gmail.com>
This commit is contained in:
Wesley Wigham
2020-11-18 15:57:32 -08:00
committed by GitHub
co-authored by Mateusz Burzyński
parent d72de70fbc
commit ca766df7e4
11 changed files with 897 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/cases/compiler/jsxNamespaceImplicitImportJSXNamespaceFromConfigPickedOverGlobalOne.tsx
+65
View File
@@ -0,0 +1,65 @@
// @strict: true
// @jsx: react-jsx
// @jsxImportSource: @emotion/react
// @filename: /node_modules/react/index.d.ts
export = React;
export as namespace React;
declare namespace React {}
declare global {
namespace JSX {
interface Element {}
interface ElementClass {}
interface ElementAttributesProperty {}
interface ElementChildrenAttribute {}
type LibraryManagedAttributes<C, P> = {}
interface IntrinsicAttributes {}
interface IntrinsicClassAttributes<T> {}
interface IntrinsicElements {
div: {}
}
}
}
// @filename: /node_modules/@emotion/react/jsx-runtime/index.d.ts
export { EmotionJSX as JSX } from './jsx-namespace'
// @filename: /node_modules/@emotion/react/jsx-runtime/jsx-namespace.d.ts
import 'react'
type WithConditionalCSSProp<P> = 'className' extends keyof P
? (P extends { className?: string } ? P & { css?: string } : P)
: P
type ReactJSXElement = JSX.Element
type ReactJSXElementClass = JSX.ElementClass
type ReactJSXElementAttributesProperty = JSX.ElementAttributesProperty
type ReactJSXElementChildrenAttribute = JSX.ElementChildrenAttribute
type ReactJSXLibraryManagedAttributes<C, P> = JSX.LibraryManagedAttributes<C, P>
type ReactJSXIntrinsicAttributes = JSX.IntrinsicAttributes
type ReactJSXIntrinsicClassAttributes<T> = JSX.IntrinsicClassAttributes<T>
type ReactJSXIntrinsicElements = JSX.IntrinsicElements
export namespace EmotionJSX {
interface Element extends ReactJSXElement {}
interface ElementClass extends ReactJSXElementClass {}
interface ElementAttributesProperty
extends ReactJSXElementAttributesProperty {}
interface ElementChildrenAttribute extends ReactJSXElementChildrenAttribute {}
type LibraryManagedAttributes<C, P> = WithConditionalCSSProp<P> &
ReactJSXLibraryManagedAttributes<C, P>
interface IntrinsicAttributes extends ReactJSXIntrinsicAttributes {}
interface IntrinsicClassAttributes<T>
extends ReactJSXIntrinsicClassAttributes<T> {}
type IntrinsicElements = {
[K in keyof ReactJSXIntrinsicElements]: ReactJSXIntrinsicElements[K] & {
css?: string
}
}
}
// @filename: /index.tsx
export const Comp = () => <div css="color: hotpink;"></div>;
tests/cases/compiler/jsxNamespaceImplicitImportJSXNamespaceFromPragmaPickedOverGlobalOne.tsx
+65
View File
@@ -0,0 +1,65 @@
// @strict: true
// @jsx: react
// @filename: /node_modules/react/index.d.ts
export = React;
export as namespace React;
declare namespace React { }
declare global {
namespace JSX {
interface Element { }
interface ElementClass { }
interface ElementAttributesProperty { }
interface ElementChildrenAttribute { }
type LibraryManagedAttributes<C, P> = {}
interface IntrinsicAttributes { }
interface IntrinsicClassAttributes<T> { }
interface IntrinsicElements {
div: {}
}
}
}
// @filename: /node_modules/@emotion/react/jsx-runtime/index.d.ts
export { EmotionJSX as JSX } from './jsx-namespace'
// @filename: /node_modules/@emotion/react/jsx-runtime/jsx-namespace.d.ts
import 'react'
type WithConditionalCSSProp<P> = 'className' extends keyof P
? (P extends { className?: string } ? P & { css?: string } : P)
: P
type ReactJSXElement = JSX.Element
type ReactJSXElementClass = JSX.ElementClass
type ReactJSXElementAttributesProperty = JSX.ElementAttributesProperty
type ReactJSXElementChildrenAttribute = JSX.ElementChildrenAttribute
type ReactJSXLibraryManagedAttributes<C, P> = JSX.LibraryManagedAttributes<C, P>
type ReactJSXIntrinsicAttributes = JSX.IntrinsicAttributes
type ReactJSXIntrinsicClassAttributes<T> = JSX.IntrinsicClassAttributes<T>
type ReactJSXIntrinsicElements = JSX.IntrinsicElements
export namespace EmotionJSX {
interface Element extends ReactJSXElement { }
interface ElementClass extends ReactJSXElementClass { }
interface ElementAttributesProperty
extends ReactJSXElementAttributesProperty { }
interface ElementChildrenAttribute extends ReactJSXElementChildrenAttribute { }
type LibraryManagedAttributes<C, P> = WithConditionalCSSProp<P> &
ReactJSXLibraryManagedAttributes<C, P>
interface IntrinsicAttributes extends ReactJSXIntrinsicAttributes { }
interface IntrinsicClassAttributes<T>
extends ReactJSXIntrinsicClassAttributes<T> { }
type IntrinsicElements = {
[K in keyof ReactJSXIntrinsicElements]: ReactJSXIntrinsicElements[K] & {
css?: string
}
}
}
// @filename: /index.tsx
/* @jsxImportSource @emotion/react */
export const Comp = () => <div css="color: hotpink;"></div>;