mirror of
https://github.com/microsoft/TypeScript.git
synced 2026-11-18 20:11:14 +00:00
Avoid getting undefined callSignatures/constructSignatures in getPropertyOfType
e350c357 (#40228) introduced a subtle bug: it switched the flags to an
alias, dropping `SymbolFlags.Property` --- and that makes
`symbolIsValue()` get to the `resolveAlias(symbol)` call, which leads to
`getPropertyOfType()` with`resolved.callSignatures`+`constructSignatures`
being `undefined`. So initialize them in `setStructuredTypeMembers`
before calling `getNamedMembers()`.
Fixes #42350
This commit is contained in:
1 parent
a3ead92046
commit
c7bac6f2e6
9 files changed
+108
-7
No files matched your search
+10
-7
@@ -3846,13 +3846,16 @@ namespace ts {
|
||||
}
|
||||
|
||||
function setStructuredTypeMembers(type: StructuredType, members: SymbolTable, callSignatures: readonly Signature[], constructSignatures: readonly Signature[], stringIndexInfo: IndexInfo | undefined, numberIndexInfo: IndexInfo | undefined): ResolvedType {
|
||||
(<ResolvedType>type).members = members;
|
||||
(<ResolvedType>type).properties = members === emptySymbols ? emptyArray : getNamedMembers(members);
|
||||
(<ResolvedType>type).callSignatures = callSignatures;
|
||||
(<ResolvedType>type).constructSignatures = constructSignatures;
|
||||
(<ResolvedType>type).stringIndexInfo = stringIndexInfo;
|
||||
(<ResolvedType>type).numberIndexInfo = numberIndexInfo;
|
||||
return <ResolvedType>type;
|
||||
const resolved = <ResolvedType>type;
|
||||
resolved.members = members;
|
||||
resolved.properties = emptyArray;
|
||||
resolved.callSignatures = callSignatures;
|
||||
resolved.constructSignatures = constructSignatures;
|
||||
resolved.stringIndexInfo = stringIndexInfo;
|
||||
resolved.numberIndexInfo = numberIndexInfo;
|
||||
// This can loop back to getPropertyOfType() which would crash if `callSignatures` & `constructSignatures` are not initialized.
|
||||
if (members !== emptySymbols) resolved.properties = getNamedMembers(members);
|
||||
return resolved;
|
||||
}
|
||||
|
||||
function createAnonymousType(symbol: Symbol | undefined, members: SymbolTable, callSignatures: readonly Signature[], constructSignatures: readonly Signature[], stringIndexInfo: IndexInfo | undefined, numberIndexInfo: IndexInfo | undefined): ResolvedType {
|
||||
|
||||
Reference in new issue
Block a user