From bab0c995849eff9d5617653de537b7f9103c7e10 Mon Sep 17 00:00:00 2001 From: Alexander T Date: Tue, 18 Feb 2020 23:00:31 +0200 Subject: [PATCH] =?UTF-8?q?fix(29565):=20Add=20missing=20super()=20quickFi?= =?UTF-8?q?x=20errors=20for=20constructo=E2=80=A6=20(#36601)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../fixConstructorForDerivedNeedSuperCall.ts | 2 +- .../fourslash/codeFixAddMissingSuperCall.ts | 22 +++++++++++++++++++ .../fourslash/codeFixAddMissingSuperCall1.ts | 22 +++++++++++++++++++ .../fourslash/codeFixAddMissingSuperCall2.ts | 22 +++++++++++++++++++ 4 files changed, 67 insertions(+), 1 deletion(-) create mode 100644 tests/cases/fourslash/codeFixAddMissingSuperCall.ts create mode 100644 tests/cases/fourslash/codeFixAddMissingSuperCall1.ts create mode 100644 tests/cases/fourslash/codeFixAddMissingSuperCall2.ts diff --git a/src/services/codefixes/fixConstructorForDerivedNeedSuperCall.ts b/src/services/codefixes/fixConstructorForDerivedNeedSuperCall.ts index 4fb14545a20..ce472f4f998 100644 --- a/src/services/codefixes/fixConstructorForDerivedNeedSuperCall.ts +++ b/src/services/codefixes/fixConstructorForDerivedNeedSuperCall.ts @@ -17,7 +17,7 @@ namespace ts.codefix { function getNode(sourceFile: SourceFile, pos: number): ConstructorDeclaration { const token = getTokenAtPosition(sourceFile, pos); - Debug.assert(token.kind === SyntaxKind.ConstructorKeyword, "token should be at the constructor keyword"); + Debug.assert(isConstructorDeclaration(token.parent), "token should be at the constructor declaration"); return token.parent as ConstructorDeclaration; } diff --git a/tests/cases/fourslash/codeFixAddMissingSuperCall.ts b/tests/cases/fourslash/codeFixAddMissingSuperCall.ts new file mode 100644 index 00000000000..6da7635074d --- /dev/null +++ b/tests/cases/fourslash/codeFixAddMissingSuperCall.ts @@ -0,0 +1,22 @@ +/// + +////class A {} +////class B extends A { +//// [|constructor|]() {} +////} + +verify.codeFixAvailable([ + { description: ts.Diagnostics.Add_missing_super_call.message } +]) + +verify.codeFix({ + description: ts.Diagnostics.Add_missing_super_call.message, + newFileContent: +`class A {} +class B extends A { + constructor() { + super(); + } +}` +}); + diff --git a/tests/cases/fourslash/codeFixAddMissingSuperCall1.ts b/tests/cases/fourslash/codeFixAddMissingSuperCall1.ts new file mode 100644 index 00000000000..1f6a9b037cb --- /dev/null +++ b/tests/cases/fourslash/codeFixAddMissingSuperCall1.ts @@ -0,0 +1,22 @@ +/// + +////class A {} +////class B extends A { +//// [|public constructor|]() {} +////} + +verify.codeFixAvailable([ + { description: ts.Diagnostics.Add_missing_super_call.message } +]) + +verify.codeFix({ + description: ts.Diagnostics.Add_missing_super_call.message, + newFileContent: +`class A {} +class B extends A { + public constructor() { + super(); + } +}` +}); + diff --git a/tests/cases/fourslash/codeFixAddMissingSuperCall2.ts b/tests/cases/fourslash/codeFixAddMissingSuperCall2.ts new file mode 100644 index 00000000000..119199c30f9 --- /dev/null +++ b/tests/cases/fourslash/codeFixAddMissingSuperCall2.ts @@ -0,0 +1,22 @@ +/// + +////class A {} +////class B extends A { +//// public [|constructor|]() {} +////} + +verify.codeFixAvailable([ + { description: ts.Diagnostics.Add_missing_super_call.message } +]) + +verify.codeFix({ + description: ts.Diagnostics.Add_missing_super_call.message, + newFileContent: +`class A {} +class B extends A { + public constructor() { + super(); + } +}` +}); +