From b99b0403841b209d9aaa22842e4e2fa648095377 Mon Sep 17 00:00:00 2001 From: Anders Hejlsberg Date: Mon, 17 Nov 2014 12:13:38 -0800 Subject: [PATCH] Addressing CR feedback --- src/compiler/checker.ts | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 2baa3d5b72e..9165cc6d8ba 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -3454,7 +3454,7 @@ module ts { if (!(expandingFlags & 1) && isDeeplyNestedGeneric(source, sourceStack)) expandingFlags |= 1; if (!(expandingFlags & 2) && isDeeplyNestedGeneric(target, targetStack)) expandingFlags |= 2; if (expandingFlags === 3) { - var result = Ternary.True; + var result = Ternary.Maybe; } else { var result = propertiesRelatedTo(source, target, reportErrors); @@ -3474,11 +3474,11 @@ module ts { expandingFlags = saveExpandingFlags; depth--; if (result) { - var sourceCache = maybeStack[depth]; + var maybeCache = maybeStack[depth]; // If result is definitely true, copy assumptions to global cache, else copy to next level up - var targetCache = result === Ternary.True || depth === 0 ? relation : maybeStack[depth - 1]; - for (var p in sourceCache) { - targetCache[p] = sourceCache[p]; + var destinationCache = result === Ternary.True || depth === 0 ? relation : maybeStack[depth - 1]; + for (var p in maybeCache) { + destinationCache[p] = maybeCache[p]; } } else {