From add6bbcfce5f2b317bcb8cbb82852012f4e6acff Mon Sep 17 00:00:00 2001 From: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com> Date: Thu, 30 Apr 2020 14:28:23 -0700 Subject: [PATCH] Use BindableStaticNameExpression not BindableStaticAccessExpression This type does allow identifiers, but those are ruled out earlier, so I added an assert for that case. --- src/compiler/binder.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler/binder.ts b/src/compiler/binder.ts index 8a79a57b464..cf9260cf6b7 100644 --- a/src/compiler/binder.ts +++ b/src/compiler/binder.ts @@ -2983,10 +2983,7 @@ namespace ts { addLateBoundAssignmentDeclarationToSymbol(node, sym); } else { - if (!isBindableStaticAccessExpression(node.left)) { - return Debug.fail(`Invalid cast. The supplied value ${getTextOfNode(node.left)} was not a BindableStaticAccessExpression.`); - } - bindStaticPropertyAssignment(node.left as BindableStaticAccessExpression); + bindStaticPropertyAssignment(cast(node.left, isBindableStaticNameExpression)); } } @@ -2994,7 +2991,8 @@ namespace ts { * For nodes like `x.y = z`, declare a member 'y' on 'x' if x is a function (or IIFE) or class or {}, or not declared. * Also works for expression statements preceded by JSDoc, like / ** @type number * / x.y; */ - function bindStaticPropertyAssignment(node: BindableStaticAccessExpression) { + function bindStaticPropertyAssignment(node: BindableStaticNameExpression) { + Debug.assert(!isIdentifier(node)); node.expression.parent = node; bindPropertyAssignment(node.expression, node, /*isPrototypeProperty*/ false, /*containerIsClass*/ false); }