From 8fd660bcba3f3ced8b707f67b5a6f88863b73055 Mon Sep 17 00:00:00 2001 From: Kanchalai Tanglertsampan Date: Tue, 21 Mar 2017 13:11:29 -0700 Subject: [PATCH] Report no implicit error when we return Promise --- src/compiler/checker.ts | 3 +++ src/compiler/diagnosticMessages.json | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index db2452625c3..86099ae6d0c 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -14875,6 +14875,9 @@ namespace ts { return createPromiseReturnType(node, getTypeOfSymbol(esModuleSymbol)); } } + if (noImplicitAny) { + error(node, Diagnostics.Cannot_resolve_dynamic_import_implicitly_has_a_Promise_any_type); + } return createPromiseReturnType(node, anyType); } diff --git a/src/compiler/diagnosticMessages.json b/src/compiler/diagnosticMessages.json index 402b1c30920..8e1ee767c55 100644 --- a/src/compiler/diagnosticMessages.json +++ b/src/compiler/diagnosticMessages.json @@ -3161,6 +3161,10 @@ "category": "Error", "code": 7034 }, + "Cannot resolve dynamic import, implicitly has a 'Promise' type.": { + "category": "Error", + "code": 7035 + }, "You cannot rename this element.": { "category": "Error", "code": 8000