From 6e5d75b58bda69506eabaf8a10d37687f50fef43 Mon Sep 17 00:00:00 2001
From: Nathan Shively-Sanders <293473+sandersn@users.noreply.github.com>
Date: Fri, 7 Aug 2020 09:14:04 -0700
Subject: [PATCH] Use isUncalledFunctionReference for aliases too

Fixes bogus deprecated notices on imports of functions with deprecated
overloads, but with some non-deprecated overloads.

Fixes microsoft/vscode#104238
---
 src/compiler/checker.ts                             |  4 +---
 .../cases/fourslash/jsdocDeprecated_suggestion8.ts  | 13 +++++++++++++
 2 files changed, 14 insertions(+), 3 deletions(-)
 create mode 100644 tests/cases/fourslash/jsdocDeprecated_suggestion8.ts

diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
index 98123d0275b..f9c6a04324a 100644
--- a/src/compiler/checker.ts
+++ b/src/compiler/checker.ts
@@ -35323,9 +35323,7 @@ namespace ts {
                     error(node, Diagnostics.Re_exporting_a_type_when_the_isolatedModules_flag_is_provided_requires_using_export_type);
                 }
 
-                if (isImportSpecifier(node) &&
-                    (target.valueDeclaration && target.valueDeclaration.flags & NodeFlags.Deprecated
-                        || every(target.declarations, d => !!(d.flags & NodeFlags.Deprecated)))) {
+                if (isImportSpecifier(node) && isUncalledFunctionReference(target.valueDeclaration, target)) {
                     errorOrSuggestion(/* isError */ false, node.name, Diagnostics._0_is_deprecated, symbol.escapedName as string);
                 }
             }
diff --git a/tests/cases/fourslash/jsdocDeprecated_suggestion8.ts b/tests/cases/fourslash/jsdocDeprecated_suggestion8.ts
new file mode 100644
index 00000000000..a1d519cb2e5
--- /dev/null
+++ b/tests/cases/fourslash/jsdocDeprecated_suggestion8.ts
@@ -0,0 +1,13 @@
+///<reference path="fourslash.ts" />
+
+// @Filename: first.ts
+//// /** @deprecated */
+//// export declare function tap<T>(next: null): void;
+//// export declare function tap<T>(next: T): T;
+// @Filename: second.ts
+//// import { tap } from './first';
+//// tap
+
+goTo.file('second.ts')
+verify.noErrors()
+verify.getSuggestionDiagnostics([]);