Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(50303): Using @linkcode in combination with private methods causes TS1003 in JavaScript files. (#56338)

Browse Source
This commit is contained in:
Oleksandr T
2023-11-28 15:07:31 -08:00
committed by GitHub
parent c250aed310
commit 4eae150282
4 changed files with 91 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/compiler/parser.ts
+19 -12
View File
@@ -9210,18 +9210,7 @@ namespace Parser {
}
nextTokenJSDoc(); // start at token after link, then skip any whitespace
skipWhitespace();
// parseEntityName logs an error for non-identifier, so create a MissingNode ourselves to avoid the error
const p2 = getNodePos();
let name: EntityName | JSDocMemberName | undefined = tokenIsIdentifierOrKeyword(token())
? parseEntityName(/*allowReservedWords*/ true)
: undefined;
if (name) {
while (token() === SyntaxKind.PrivateIdentifier) {
reScanHashToken(); // rescan #id as # id
nextTokenJSDoc(); // then skip the #
name = finishNode(factory.createJSDocMemberName(name, parseIdentifier()), p2);
}
}
const name = parseJSDocLinkName();
const text = [];
while (token() !== SyntaxKind.CloseBraceToken && token() !== SyntaxKind.NewLineTrivia && token() !== SyntaxKind.EndOfFileToken) {
text.push(scanner.getTokenText());
@@ -9233,6 +9222,24 @@ namespace Parser {
return finishNode(create(name, text.join("")), start, scanner.getTokenEnd());
}
function parseJSDocLinkName() {
if (tokenIsIdentifierOrKeyword(token())) {
const pos = getNodePos();
let name: EntityName | JSDocMemberName = parseIdentifierName();
while (parseOptional(SyntaxKind.DotToken)) {
name = finishNode(factory.createQualifiedName(name, token() === SyntaxKind.PrivateIdentifier ? createMissingNode<Identifier>(SyntaxKind.Identifier, /*reportAtCurrentPosition*/ false) : parseIdentifier()), pos);
}
while (token() === SyntaxKind.PrivateIdentifier) {
reScanHashToken();
nextTokenJSDoc();
name = finishNode(factory.createJSDocMemberName(name, parseIdentifier()), pos);
}
return name;
}
return undefined;
}
function parseJSDocLinkPrefix() {
skipWhitespaceOrAsterisk();
if (