From 4c90ba9456b3a89e9ba7176fc0dd171b8c2da3b2 Mon Sep 17 00:00:00 2001 From: Ron Buckton Date: Wed, 29 Jul 2020 18:13:27 -0700 Subject: [PATCH] Temporary revert to compare user test baselines --- src/compiler/binder.ts | 5 +++-- src/compiler/checker.ts | 10 +++++----- 2 files changed, 8 insertions(+), 7 deletions(-) diff --git a/src/compiler/binder.ts b/src/compiler/binder.ts index 7a6aaa18618..7f2b36ff7d4 100644 --- a/src/compiler/binder.ts +++ b/src/compiler/binder.ts @@ -837,8 +837,9 @@ namespace ts { function isNarrowableReference(expr: Expression): boolean { return expr.kind === SyntaxKind.Identifier || expr.kind === SyntaxKind.ThisKeyword || expr.kind === SyntaxKind.SuperKeyword || (isPropertyAccessExpression(expr) || isNonNullExpression(expr) || isParenthesizedExpression(expr)) && isNarrowableReference(expr.expression) || - isElementAccessExpression(expr) && isStringOrNumericLiteralLike(expr.argumentExpression) && isNarrowableReference(expr.expression) || - isAssignmentExpression(expr) && isNarrowableReference(expr.left); + isElementAccessExpression(expr) && isStringOrNumericLiteralLike(expr.argumentExpression) && isNarrowableReference(expr.expression); + // || + // isAssignmentExpression(expr) && isNarrowableReference(expr.left); } function containsNarrowableReference(expr: Expression): boolean { diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index badc8a5ed9b..d386adc352d 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -20131,11 +20131,11 @@ namespace ts { case SyntaxKind.ParenthesizedExpression: case SyntaxKind.NonNullExpression: return isMatchingReference(source, (target as NonNullExpression | ParenthesizedExpression).expression); - case SyntaxKind.BinaryExpression: - if (isAssignmentExpression(target)) { - return isMatchingReference(source, target.left); - } - break; + // case SyntaxKind.BinaryExpression: + // if (isAssignmentExpression(target)) { + // return isMatchingReference(source, target.left); + // } + // break; } switch (source.kind) { case SyntaxKind.Identifier: