From 3efeb1e27f60a95dad66c148295bfa5a65f56146 Mon Sep 17 00:00:00 2001 From: Anders Hejlsberg Date: Mon, 7 Aug 2017 13:59:52 -0700 Subject: [PATCH] Address CR feedback --- .../reference/indexSignatureAndMappedType.errors.txt | 2 +- tests/baselines/reference/indexSignatureAndMappedType.js | 4 ++-- tests/cases/compiler/indexSignatureAndMappedType.ts | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/baselines/reference/indexSignatureAndMappedType.errors.txt b/tests/baselines/reference/indexSignatureAndMappedType.errors.txt index c8ae0494015..623fcd11bd0 100644 --- a/tests/baselines/reference/indexSignatureAndMappedType.errors.txt +++ b/tests/baselines/reference/indexSignatureAndMappedType.errors.txt @@ -15,7 +15,7 @@ tests/cases/compiler/indexSignatureAndMappedType.ts(16,5): error TS2322: Type '{ !!! error TS2322: Type '{ [key: string]: T; }' is not assignable to type 'Record'. } - function f2(x: { [key: string]: T }, y: Record) { + function f2(x: { [key: string]: T }, y: Record) { x = y; y = x; } diff --git a/tests/baselines/reference/indexSignatureAndMappedType.js b/tests/baselines/reference/indexSignatureAndMappedType.js index c35da4f4931..be58286fb46 100644 --- a/tests/baselines/reference/indexSignatureAndMappedType.js +++ b/tests/baselines/reference/indexSignatureAndMappedType.js @@ -7,7 +7,7 @@ function f1(x: { [key: string]: T }, y: Record) { y = x; // Error } -function f2(x: { [key: string]: T }, y: Record) { +function f2(x: { [key: string]: T }, y: Record) { x = y; y = x; } @@ -55,7 +55,7 @@ function f3(x, y) { declare function f1(x: { [key: string]: T; }, y: Record): void; -declare function f2(x: { +declare function f2(x: { [key: string]: T; }, y: Record): void; declare function f3(x: { diff --git a/tests/cases/compiler/indexSignatureAndMappedType.ts b/tests/cases/compiler/indexSignatureAndMappedType.ts index 1070472a241..b5f9e8a0030 100644 --- a/tests/cases/compiler/indexSignatureAndMappedType.ts +++ b/tests/cases/compiler/indexSignatureAndMappedType.ts @@ -9,7 +9,7 @@ function f1(x: { [key: string]: T }, y: Record) { y = x; // Error } -function f2(x: { [key: string]: T }, y: Record) { +function f2(x: { [key: string]: T }, y: Record) { x = y; y = x; }