From 34f7f2caed8fe1198e095332500c6bb6f34de819 Mon Sep 17 00:00:00 2001
From: Sheetal Nandi <shkamat@microsoft.com>
Date: Fri, 22 Apr 2016 10:40:06 -0700
Subject: [PATCH] Handle the scenario when let [a=undefined]=[]

---
 src/compiler/checker.ts                                  | 6 +-----
 .../noImplicitAnyDestructuringVarDeclaration.errors.txt  | 9 +++++++--
 .../noImplicitAnyDestructuringVarDeclaration.js          | 5 ++++-
 .../compiler/noImplicitAnyDestructuringVarDeclaration.ts | 4 +++-
 4 files changed, 15 insertions(+), 9 deletions(-)

diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
index f84988e68ba..a6d1680a6e3 100644
--- a/src/compiler/checker.ts
+++ b/src/compiler/checker.ts
@@ -2885,11 +2885,7 @@ namespace ts {
         // pattern. Otherwise, it is the type any.
         function getTypeFromBindingElement(element: BindingElement, includePatternInType?: boolean, reportErrors?: boolean): Type {
             if (element.initializer) {
-                const type = checkExpressionCached(element.initializer);
-                if (reportErrors) {
-                    reportErrorsFromWidening(element, type);
-                }
-                return getWidenedType(type);
+                return checkExpressionCached(element.initializer);
             }
             if (isBindingPattern(element.name)) {
                 return getTypeFromBindingPattern(<BindingPattern>element.name, includePatternInType, reportErrors);
diff --git a/tests/baselines/reference/noImplicitAnyDestructuringVarDeclaration.errors.txt b/tests/baselines/reference/noImplicitAnyDestructuringVarDeclaration.errors.txt
index e54261b117f..f7e6475b971 100644
--- a/tests/baselines/reference/noImplicitAnyDestructuringVarDeclaration.errors.txt
+++ b/tests/baselines/reference/noImplicitAnyDestructuringVarDeclaration.errors.txt
@@ -19,9 +19,10 @@ tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts(9,6): error TS7
 tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts(9,26): error TS7031: Binding element 'b4' implicitly has an 'any' type.
 tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts(9,46): error TS7005: Variable 'c4' implicitly has an 'any' type.
 tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts(9,62): error TS7005: Variable 'd4' implicitly has an 'any' type.
+tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts(11,6): error TS7031: Binding element 'a5' implicitly has an 'any' type.
 
 
-==== tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts (21 errors) ====
+==== tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts (22 errors) ====
     var [a], {b}, c, d; // error
         ~~~
 !!! error TS1182: A destructuring declaration must have an initializer.
@@ -72,4 +73,8 @@ tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts(9,62): error TS
                                                  ~~
 !!! error TS7005: Variable 'c4' implicitly has an 'any' type.
                                                                  ~~
-!!! error TS7005: Variable 'd4' implicitly has an 'any' type.
\ No newline at end of file
+!!! error TS7005: Variable 'd4' implicitly has an 'any' type.
+    
+    var [a5 = undefined] = []; // error
+         ~~
+!!! error TS7031: Binding element 'a5' implicitly has an 'any' type.
\ No newline at end of file
diff --git a/tests/baselines/reference/noImplicitAnyDestructuringVarDeclaration.js b/tests/baselines/reference/noImplicitAnyDestructuringVarDeclaration.js
index 4e9606d9c53..85358df666e 100644
--- a/tests/baselines/reference/noImplicitAnyDestructuringVarDeclaration.js
+++ b/tests/baselines/reference/noImplicitAnyDestructuringVarDeclaration.js
@@ -7,7 +7,9 @@ var [a2]: [any], {b2}: { b2: any }, c2: any, d2: any;
 
 var {b3}: { b3 }, c3: { b3 }; // error in type instead
 
-var [a4] = [undefined], {b4} = { b4: null }, c4 = undefined, d4 = null; // error
+var [a4] = [undefined], {b4} = { b4: null }, c4 = undefined, d4 = null; // error
+
+var [a5 = undefined] = []; // error
 
 //// [noImplicitAnyDestructuringVarDeclaration.js]
 var a = (void 0)[0], b = (void 0).b, c, d; // error
@@ -15,3 +17,4 @@ var _a = (void 0)[0], a1 = _a === void 0 ? undefined : _a, _b = (void 0).b1, b1
 var a2 = (void 0)[0], b2 = (void 0).b2, c2, d2;
 var b3 = (void 0).b3, c3; // error in type instead
 var a4 = [undefined][0], b4 = { b4: null }.b4, c4 = undefined, d4 = null; // error
+var _c = [][0], a5 = _c === void 0 ? undefined : _c; // error
diff --git a/tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts b/tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts
index b9ecd8e72a8..ea99d03bd7c 100644
--- a/tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts
+++ b/tests/cases/compiler/noImplicitAnyDestructuringVarDeclaration.ts
@@ -7,4 +7,6 @@ var [a2]: [any], {b2}: { b2: any }, c2: any, d2: any;
 
 var {b3}: { b3 }, c3: { b3 }; // error in type instead
 
-var [a4] = [undefined], {b4} = { b4: null }, c4 = undefined, d4 = null; // error
\ No newline at end of file
+var [a4] = [undefined], {b4} = { b4: null }, c4 = undefined, d4 = null; // error
+
+var [a5 = undefined] = []; // error
\ No newline at end of file