From 3055018556eadea158c7231c1df819153e6e7de2 Mon Sep 17 00:00:00 2001
From: TypeScript Bot <ts_bot@rcavanaugh.com>
Date: Fri, 7 Aug 2020 13:40:44 -0400
Subject: [PATCH] Cherry-pick PR #39950 into release-4.0 (#39951)

Component commits:
6e5d75b58b Use isUncalledFunctionReference for aliases too
Fixes bogus deprecated notices on imports of functions with deprecated
overloads, but with some non-deprecated overloads.

Fixes microsoft/vscode#104238

e2eb319e72 Just check all declarations, don't call isUncalledFunction

Co-authored-by: Nathan Shively-Sanders <nathansa@microsoft.com>
---
 src/compiler/checker.ts                             |  4 +---
 .../cases/fourslash/jsdocDeprecated_suggestion8.ts  | 13 +++++++++++++
 .../cases/fourslash/jsdocDeprecated_suggestion9.ts  | 11 +++++++++++
 3 files changed, 25 insertions(+), 3 deletions(-)
 create mode 100644 tests/cases/fourslash/jsdocDeprecated_suggestion8.ts
 create mode 100644 tests/cases/fourslash/jsdocDeprecated_suggestion9.ts

diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts
index 98123d0275b..748cab985da 100644
--- a/src/compiler/checker.ts
+++ b/src/compiler/checker.ts
@@ -35323,9 +35323,7 @@ namespace ts {
                     error(node, Diagnostics.Re_exporting_a_type_when_the_isolatedModules_flag_is_provided_requires_using_export_type);
                 }
 
-                if (isImportSpecifier(node) &&
-                    (target.valueDeclaration && target.valueDeclaration.flags & NodeFlags.Deprecated
-                        || every(target.declarations, d => !!(d.flags & NodeFlags.Deprecated)))) {
+                if (isImportSpecifier(node) && every(target.declarations, d => !!(getCombinedNodeFlags(d) & NodeFlags.Deprecated))) {
                     errorOrSuggestion(/* isError */ false, node.name, Diagnostics._0_is_deprecated, symbol.escapedName as string);
                 }
             }
diff --git a/tests/cases/fourslash/jsdocDeprecated_suggestion8.ts b/tests/cases/fourslash/jsdocDeprecated_suggestion8.ts
new file mode 100644
index 00000000000..a1d519cb2e5
--- /dev/null
+++ b/tests/cases/fourslash/jsdocDeprecated_suggestion8.ts
@@ -0,0 +1,13 @@
+///<reference path="fourslash.ts" />
+
+// @Filename: first.ts
+//// /** @deprecated */
+//// export declare function tap<T>(next: null): void;
+//// export declare function tap<T>(next: T): T;
+// @Filename: second.ts
+//// import { tap } from './first';
+//// tap
+
+goTo.file('second.ts')
+verify.noErrors()
+verify.getSuggestionDiagnostics([]);
diff --git a/tests/cases/fourslash/jsdocDeprecated_suggestion9.ts b/tests/cases/fourslash/jsdocDeprecated_suggestion9.ts
new file mode 100644
index 00000000000..bf5ef1b12da
--- /dev/null
+++ b/tests/cases/fourslash/jsdocDeprecated_suggestion9.ts
@@ -0,0 +1,11 @@
+///<reference path="fourslash.ts" />
+
+// @Filename: first.ts
+//// export class logger { }
+// @Filename: second.ts
+//// import { logger } from './first';
+//// new logger()
+
+goTo.file('second.ts')
+verify.noErrors()
+verify.getSuggestionDiagnostics([]);