From 2be6aaf8137a5f901ecd3a8f2efc6bb30b8d4521 Mon Sep 17 00:00:00 2001 From: Andy Date: Thu, 10 May 2018 16:50:26 -0700 Subject: [PATCH] Support '/' as a trigger character in path completions (#24042) --- src/services/completions.ts | 4 +++- tests/cases/fourslash/completionsTriggerCharacter.ts | 11 ++++++++--- 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/services/completions.ts b/src/services/completions.ts index 749843a09b2..d8b0bbc138d 100644 --- a/src/services/completions.ts +++ b/src/services/completions.ts @@ -2218,7 +2218,9 @@ namespace ts.Completions { // Opening JSX tag return contextToken.kind === SyntaxKind.LessThanToken && contextToken.parent.kind !== SyntaxKind.BinaryExpression; case "/": - return isJsxClosingElement(contextToken.parent); + return isStringLiteralLike(contextToken) + ? !!tryGetImportFromModuleSpecifier(contextToken) + : contextToken.kind === SyntaxKind.SlashToken && isJsxClosingElement(contextToken.parent); default: return Debug.assertNever(triggerCharacter); } diff --git a/tests/cases/fourslash/completionsTriggerCharacter.ts b/tests/cases/fourslash/completionsTriggerCharacter.ts index fcd61c26c25..ea1abfdb3e4 100644 --- a/tests/cases/fourslash/completionsTriggerCharacter.ts +++ b/tests/cases/fourslash/completionsTriggerCharacter.ts @@ -9,6 +9,9 @@ ////// "/*quoteInComment*/ foo foo