diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index a60866b90f0..fc1c2c0a873 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -8416,7 +8416,10 @@ namespace ts { if (needToCaptureLexicalThis) { captureLexicalThis(node, container); } - if (isFunctionLike(container)) { + if (isFunctionLike(container) && + (!isInParameterInitializerBeforeContainingFunction(node) || getFunctionLikeThisParameter(container))) { + // Note: a parameter initializer should refer to class-this unless function-this is explicitly annotated. + // If this is a function in a JS file, it might be a class method. Check if it's the RHS // of a x.prototype.y = function [name]() { .... } if (container.kind === SyntaxKind.FunctionExpression && @@ -18507,6 +18510,14 @@ namespace ts { } } + function getFunctionLikeThisParameter(func: FunctionLikeDeclaration) { + if (func.parameters.length && + func.parameters[0].name.kind === SyntaxKind.Identifier && + (func.parameters[0].name).originalKeywordKind === SyntaxKind.ThisKeyword) { + return func.parameters[0]; + } + } + function checkGrammarForNonSymbolComputedProperty(node: DeclarationName, message: DiagnosticMessage) { if (isDynamicName(node)) { return grammarErrorOnNode(node, message); diff --git a/tests/baselines/reference/inferParameterWithMethodCallInitializer.js b/tests/baselines/reference/inferParameterWithMethodCallInitializer.js new file mode 100644 index 00000000000..5b33f78f766 --- /dev/null +++ b/tests/baselines/reference/inferParameterWithMethodCallInitializer.js @@ -0,0 +1,51 @@ +//// [inferParameterWithMethodCallInitializer.ts] +function getNumber(): number { + return 1; +} +class Example { + getNumber(): number { + return 1; + } + doSomething(a = this.getNumber()): typeof a { + return a; + } +} +function weird(this: Example, a = this.getNumber()) { + return a; +} +class Weird { + doSomething(this: Example, a = this.getNumber()) { + return a; + } +} + + +//// [inferParameterWithMethodCallInitializer.js] +function getNumber() { + return 1; +} +var Example = (function () { + function Example() { + } + Example.prototype.getNumber = function () { + return 1; + }; + Example.prototype.doSomething = function (a) { + if (a === void 0) { a = this.getNumber(); } + return a; + }; + return Example; +}()); +function weird(a) { + if (a === void 0) { a = this.getNumber(); } + return a; +} +var Weird = (function () { + function Weird() { + } + Weird.prototype.doSomething = function (a) { + if (a === void 0) { a = this.getNumber(); } + return a; + }; + return Weird; +}()); diff --git a/tests/baselines/reference/inferParameterWithMethodCallInitializer.symbols b/tests/baselines/reference/inferParameterWithMethodCallInitializer.symbols new file mode 100644 index 00000000000..e0734a4b39b --- /dev/null +++ b/tests/baselines/reference/inferParameterWithMethodCallInitializer.symbols @@ -0,0 +1,55 @@ +=== tests/cases/compiler/inferParameterWithMethodCallInitializer.ts === +function getNumber(): number { +>getNumber : Symbol(getNumber, Decl(inferParameterWithMethodCallInitializer.ts, 0, 0)) + + return 1; +} +class Example { +>Example : Symbol(Example, Decl(inferParameterWithMethodCallInitializer.ts, 2, 1)) + + getNumber(): number { +>getNumber : Symbol(Example.getNumber, Decl(inferParameterWithMethodCallInitializer.ts, 3, 15)) + + return 1; + } + doSomething(a = this.getNumber()): typeof a { +>doSomething : Symbol(Example.doSomething, Decl(inferParameterWithMethodCallInitializer.ts, 6, 5)) +>a : Symbol(a, Decl(inferParameterWithMethodCallInitializer.ts, 7, 16)) +>this.getNumber : Symbol(Example.getNumber, Decl(inferParameterWithMethodCallInitializer.ts, 3, 15)) +>this : Symbol(Example, Decl(inferParameterWithMethodCallInitializer.ts, 2, 1)) +>getNumber : Symbol(Example.getNumber, Decl(inferParameterWithMethodCallInitializer.ts, 3, 15)) +>a : Symbol(a, Decl(inferParameterWithMethodCallInitializer.ts, 7, 16)) + + return a; +>a : Symbol(a, Decl(inferParameterWithMethodCallInitializer.ts, 7, 16)) + } +} +function weird(this: Example, a = this.getNumber()) { +>weird : Symbol(weird, Decl(inferParameterWithMethodCallInitializer.ts, 10, 1)) +>this : Symbol(this, Decl(inferParameterWithMethodCallInitializer.ts, 11, 15)) +>Example : Symbol(Example, Decl(inferParameterWithMethodCallInitializer.ts, 2, 1)) +>a : Symbol(a, Decl(inferParameterWithMethodCallInitializer.ts, 11, 29)) +>this.getNumber : Symbol(Example.getNumber, Decl(inferParameterWithMethodCallInitializer.ts, 3, 15)) +>this : Symbol(Example, Decl(inferParameterWithMethodCallInitializer.ts, 2, 1)) +>getNumber : Symbol(Example.getNumber, Decl(inferParameterWithMethodCallInitializer.ts, 3, 15)) + + return a; +>a : Symbol(a, Decl(inferParameterWithMethodCallInitializer.ts, 11, 29)) +} +class Weird { +>Weird : Symbol(Weird, Decl(inferParameterWithMethodCallInitializer.ts, 13, 1)) + + doSomething(this: Example, a = this.getNumber()) { +>doSomething : Symbol(Weird.doSomething, Decl(inferParameterWithMethodCallInitializer.ts, 14, 13)) +>this : Symbol(this, Decl(inferParameterWithMethodCallInitializer.ts, 15, 16)) +>Example : Symbol(Example, Decl(inferParameterWithMethodCallInitializer.ts, 2, 1)) +>a : Symbol(a, Decl(inferParameterWithMethodCallInitializer.ts, 15, 30)) +>this.getNumber : Symbol(Example.getNumber, Decl(inferParameterWithMethodCallInitializer.ts, 3, 15)) +>this : Symbol(Example, Decl(inferParameterWithMethodCallInitializer.ts, 2, 1)) +>getNumber : Symbol(Example.getNumber, Decl(inferParameterWithMethodCallInitializer.ts, 3, 15)) + + return a; +>a : Symbol(a, Decl(inferParameterWithMethodCallInitializer.ts, 15, 30)) + } +} + diff --git a/tests/baselines/reference/inferParameterWithMethodCallInitializer.types b/tests/baselines/reference/inferParameterWithMethodCallInitializer.types new file mode 100644 index 00000000000..9aeccb2b2e0 --- /dev/null +++ b/tests/baselines/reference/inferParameterWithMethodCallInitializer.types @@ -0,0 +1,60 @@ +=== tests/cases/compiler/inferParameterWithMethodCallInitializer.ts === +function getNumber(): number { +>getNumber : () => number + + return 1; +>1 : number +} +class Example { +>Example : Example + + getNumber(): number { +>getNumber : () => number + + return 1; +>1 : number + } + doSomething(a = this.getNumber()): typeof a { +>doSomething : (a?: number) => number +>a : number +>this.getNumber() : number +>this.getNumber : () => number +>this : this +>getNumber : () => number +>a : number + + return a; +>a : number + } +} +function weird(this: Example, a = this.getNumber()) { +>weird : (this: Example, a?: number) => number +>this : Example +>Example : Example +>a : number +>this.getNumber() : number +>this.getNumber : () => number +>this : Example +>getNumber : () => number + + return a; +>a : number +} +class Weird { +>Weird : Weird + + doSomething(this: Example, a = this.getNumber()) { +>doSomething : (this: Example, a?: number) => number +>this : Example +>Example : Example +>a : number +>this.getNumber() : number +>this.getNumber : () => number +>this : Example +>getNumber : () => number + + return a; +>a : number + } +} + diff --git a/tests/cases/compiler/inferParameterWithMethodCallInitializer.ts b/tests/cases/compiler/inferParameterWithMethodCallInitializer.ts new file mode 100644 index 00000000000..392709ccdf6 --- /dev/null +++ b/tests/cases/compiler/inferParameterWithMethodCallInitializer.ts @@ -0,0 +1,20 @@ +// @noImplicitAny: true +function getNumber(): number { + return 1; +} +class Example { + getNumber(): number { + return 1; + } + doSomething(a = this.getNumber()): typeof a { + return a; + } +} +function weird(this: Example, a = this.getNumber()) { + return a; +} +class Weird { + doSomething(this: Example, a = this.getNumber()) { + return a; + } +}