From 2399bac377a6ba28f1b0648b987203d5badf3a84 Mon Sep 17 00:00:00 2001
From: Andy <anhans@microsoft.com>
Date: Fri, 22 Sep 2017 10:45:43 -0700
Subject: [PATCH] Make it a parse error for an `@type` jsdoc tag to not include
 a type (#18664)

* Make it a parse error for an `@type` jsdoc tag to not include a type

* Rename parameter
---
 src/compiler/parser.ts                | 10 +++++++---
 src/harness/unittests/jsDocParsing.ts | 11 +++++------
 2 files changed, 12 insertions(+), 9 deletions(-)

diff --git a/src/compiler/parser.ts b/src/compiler/parser.ts
index 98483823ec3..3809a071421 100644
--- a/src/compiler/parser.ts
+++ b/src/compiler/parser.ts
@@ -6135,10 +6135,14 @@ namespace ts {
             }
 
             // Parses out a JSDoc type expression.
-            export function parseJSDocTypeExpression(): JSDocTypeExpression {
+            export function parseJSDocTypeExpression(): JSDocTypeExpression;
+            export function parseJSDocTypeExpression(requireBraces: true): JSDocTypeExpression | undefined;
+            export function parseJSDocTypeExpression(requireBraces?: boolean): JSDocTypeExpression | undefined {
                 const result = <JSDocTypeExpression>createNode(SyntaxKind.JSDocTypeExpression, scanner.getTokenPos());
 
-                parseExpected(SyntaxKind.OpenBraceToken);
+                if (!parseExpected(SyntaxKind.OpenBraceToken) && requireBraces) {
+                    return undefined;
+                }
                 result.type = doInsideOfContext(NodeFlags.JSDoc, parseType);
                 parseExpected(SyntaxKind.CloseBraceToken);
 
@@ -6595,7 +6599,7 @@ namespace ts {
                     const result = <JSDocTypeTag>createNode(SyntaxKind.JSDocTypeTag, atToken.pos);
                     result.atToken = atToken;
                     result.tagName = tagName;
-                    result.typeExpression = tryParseTypeExpression();
+                    result.typeExpression = parseJSDocTypeExpression(/*mayBail*/ true);
                     return finishNode(result);
                 }
 
diff --git a/src/harness/unittests/jsDocParsing.ts b/src/harness/unittests/jsDocParsing.ts
index 0e6221567a2..209aaa48c19 100644
--- a/src/harness/unittests/jsDocParsing.ts
+++ b/src/harness/unittests/jsDocParsing.ts
@@ -139,6 +139,11 @@ namespace ts {
                         `/**
   * @param
   */`);
+
+                parsesIncorrectly("noType",
+`/**
+* @type
+*/`);
             });
 
             describe("parsesCorrectly", () => {
@@ -148,12 +153,6 @@ namespace ts {
   */`);
 
 
-                parsesCorrectly("noType",
-`/**
-  * @type
-  */`);
-
-
                 parsesCorrectly("noReturnType",
 `/**
   * @return