From 20c008ecab7c702627382e2d53a8319bcad7786b Mon Sep 17 00:00:00 2001 From: Anders Hejlsberg Date: Sat, 17 Mar 2018 12:02:19 -0700 Subject: [PATCH] Mark implied object destructuring patterns as object literal types --- src/compiler/checker.ts | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/compiler/checker.ts b/src/compiler/checker.ts index 82d6ec8b1ff..fe5a746a74d 100644 --- a/src/compiler/checker.ts +++ b/src/compiler/checker.ts @@ -4310,12 +4310,12 @@ namespace ts { function getTypeFromObjectBindingPattern(pattern: ObjectBindingPattern, includePatternInType: boolean, reportErrors: boolean): Type { const members = createSymbolTable(); let stringIndexInfo: IndexInfo; - let hasComputedProperties = false; + let objectFlags = ObjectFlags.ObjectLiteral; forEach(pattern.elements, e => { const name = e.propertyName || e.name; if (isComputedNonLiteralName(name)) { // do not include computed properties in the implied type - hasComputedProperties = true; + objectFlags |= ObjectFlags.ObjectLiteralPatternWithComputedProperties; return; } if (e.dotDotDotToken) { @@ -4331,12 +4331,11 @@ namespace ts { members.set(symbol.escapedName, symbol); }); const result = createAnonymousType(undefined, members, emptyArray, emptyArray, stringIndexInfo, undefined); + result.flags |= TypeFlags.ContainsObjectLiteral; + result.objectFlags |= objectFlags; if (includePatternInType) { result.pattern = pattern; } - if (hasComputedProperties) { - result.objectFlags |= ObjectFlags.ObjectLiteralPatternWithComputedProperties; - } return result; }