improve isRequireVariableDeclaration parameters (#42865)

One parameter is always called with `true`, so drop it.
This commit is contained in:
Nathan Shively-Sanders
2021-02-19 09:34:05 -08:00
committed by GitHub
parent 36d021ab9a
commit 0ce5c4a7ee
6 changed files with 11 additions and 14 deletions
+1 -1
View File
@@ -376,7 +376,7 @@ namespace ts.codefix {
// Can't use an es6 import for a type in JS.
return exportedSymbolIsTypeOnly && isSourceFileJS(sourceFile) ? emptyArray : mapDefined(sourceFile.imports, (moduleSpecifier): FixAddToExistingImportInfo | undefined => {
const i = importFromModuleSpecifier(moduleSpecifier);
if (isRequireVariableDeclaration(i.parent, /*requireStringLiteralLikeArgument*/ true)) {
if (isRequireVariableDeclaration(i.parent)) {
return checker.resolveExternalModuleName(moduleSpecifier) === moduleSymbol ? { declaration: i.parent, importKind } : undefined;
}
if (i.kind === SyntaxKind.ImportDeclaration || i.kind === SyntaxKind.ImportEqualsDeclaration) {
+1 -1
View File
@@ -232,7 +232,7 @@ namespace ts.GoToDefinition {
return declaration.parent.kind === SyntaxKind.NamedImports;
case SyntaxKind.BindingElement:
case SyntaxKind.VariableDeclaration:
return isInJSFile(declaration) && isRequireVariableDeclaration(declaration, /*requireStringLiteralLikeArgument*/ true);
return isInJSFile(declaration) && isRequireVariableDeclaration(declaration);
default:
return false;
}
+1 -1
View File
@@ -619,7 +619,7 @@ namespace ts.FindAllReferences {
Debug.assert((parent as ImportClause | NamespaceImport).name === node);
return true;
case SyntaxKind.BindingElement:
return isInJSFile(node) && isRequireVariableDeclaration(parent, /*requireStringLiteralLikeArgument*/ true);
return isInJSFile(node) && isRequireVariableDeclaration(parent);
default:
return false;
}