mirror of
https://github.com/microsoft/TypeScript.git
synced 2026-11-18 20:11:14 +00:00
Respond to code review comments:
* Change comment to say "noresolve=false" in shims.ts https://github.com/Microsoft/TypeScript/commit/05eeba5bc95f9a39ceb9c17b5674ed7135d74aed * Switch newline to "\r\n" https://github.com/Microsoft/TypeScript/commit/9395eeaedbb4279480c306f88e7916fa9694de31 * Use hasOwnProperty for Map types https://github.com/Microsoft/TypeScript/commit/212c18460281cac5b5be5239d45f7d04212f62d8 * Switch "s" to "S" in typescriptServices.ts filename https://github.com/Microsoft/TypeScript/commit/9061e58dffbeaf3f72cee1c6ca6d8fc0b98b1ea5 * Change method names in Node to be more detailed
This commit is contained in:
1 parent
990669972a
commit
0a206d8855
6 files changed
+68
-36
No files matched your search
@@ -34,7 +34,7 @@ module TypeScript.Services {
|
||||
var parentScope = this.currentScope;
|
||||
this.parentScopes.push(parentScope);
|
||||
|
||||
var scope = parentScope.childScopes[key];
|
||||
var scope = ts.lookUp(parentScope.childScopes, key);
|
||||
if (!scope) {
|
||||
scope = this.createScope()
|
||||
parentScope.childScopes[key] = scope;
|
||||
@@ -76,7 +76,7 @@ module TypeScript.Services {
|
||||
private createItem(node: TypeScript.ISyntaxNode, modifiers: ISyntaxToken[], kind: string, name: string): void {
|
||||
var key = kind + "+" + name;
|
||||
|
||||
if (this.currentScope.items[key] !== undefined) {
|
||||
if (ts.lookUp(this.currentScope.items, key) !== undefined) {
|
||||
this.addAdditionalSpan(node, key);
|
||||
return;
|
||||
}
|
||||
@@ -100,7 +100,7 @@ module TypeScript.Services {
|
||||
node: TypeScript.ISyntaxNode,
|
||||
key: string) {
|
||||
|
||||
var item = this.currentScope.items[key]
|
||||
var item = ts.lookUp(this.currentScope.items, key);
|
||||
Debug.assert(item !== undefined);
|
||||
|
||||
var start = TypeScript.start(node);
|
||||
|
||||
Reference in new issue
Block a user