Microsoft/TypeScript
1
0
Fork 0
mirror of https://github.com/microsoft/TypeScript.git synced 2025-11-18 17:21:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(52879): No autocompletions after the typeof keyword inside JSDoc comments. (#52973)

Browse Source
This commit is contained in:
Oleksandr T
2023-03-07 10:52:23 -08:00
committed by GitHub
parent 868331f2be
commit 02cf0b68b7
3 changed files with 147 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/services/completions.ts
+3 -3
View File
@@ -3005,8 +3005,7 @@ function getCompletionData(
// Since this is qualified name check it's a type node location
const isImportType = isLiteralImportTypeNode(node);
const isTypeLocation = insideJsDocTagTypeExpression
|| (isImportType && !(node as ImportTypeNode).isTypeOf)
const isTypeLocation = (isImportType && !(node as ImportTypeNode).isTypeOf)
|| isPartOfTypeNode(node.parent)
|| isPossiblyTypeArgumentPosition(contextToken, sourceFile, typeChecker);
const isRhsOfImportDeclaration = isInRightSideOfInternalImportEqualsDeclaration(node);
@@ -3029,7 +3028,7 @@ function getCompletionData(
: isRhsOfImportDeclaration ?
// Any kind is allowed when dotting off namespace in internal import equals declaration
symbol => isValidTypeAccess(symbol) || isValidValueAccess(symbol) :
isTypeLocation ? isValidTypeAccess : isValidValueAccess;
isTypeLocation || insideJsDocTagTypeExpression ? isValidTypeAccess : isValidValueAccess;
for (const exportedSymbol of exportedSymbols) {
if (isValidAccess(exportedSymbol)) {
symbols.push(exportedSymbol);
@@ -3038,6 +3037,7 @@ function getCompletionData(
// If the module is merged with a value, we must get the type of the class and add its propertes (for inherited static methods).
if (!isTypeLocation &&
!insideJsDocTagTypeExpression &&
symbol.declarations &&
symbol.declarations.some(d => d.kind !== SyntaxKind.SourceFile && d.kind !== SyntaxKind.ModuleDeclaration && d.kind !== SyntaxKind.EnumDeclaration)) {
let type = typeChecker.getTypeOfSymbolAtLocation(symbol, node).getNonOptionalType();