Might seem like a minor detail, but if somehow someone runs two
servers that think they are on the same IP & port, then the uptime
will tell us that something is wrong.
This adds `/geoip` which returns a json object with one key-value pair,
`continent` = `unknown` or one of `NA`, `SA` etc. plus a 200 exit code,
or a 500 code if things went south badly.
specificially, penalize servers that support both v4 and v5
Reasoning: We, as a project, have no interest in promoting servers
that intentionally restrict themselves to the feature set of an old,
potentially buggy version.
Using geolite2, we attempt to detect the continent of the server
and store the 'continent code' in the serverlist. This is reasonably
broad enough to help players in the client find truly "nearby" server.
The client will have to be changed to select a continent to change
ordering or filtering.
serverUp uses hex spaghetti to send and receive a short sequence of packets, to see whether a server is online.
The packet format is now annotated for easier cross-reference with minetest source.
Calls to save() in purgeOld() and update() were in race condition.
Race condition was eliminated by extending the lock scope within purgeOld().
Calls to load() were in race condition with themselves.
While current use of load() (called only during construction of class ServerList()) does not manifest the bug, any future change introducing concurrent use of load() would.
Race condition potential was eliminated by extending the lock scope within load().
sfan5
Buckaroo Banzai
sofar
nOOb3167