Lichess/mobile
1
0
Fork 0
mirror of https://github.com/lichess-org/mobile.git synced 2026-05-26 13:50:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

improve pgn loading speeds (#3188)

Browse Source
This commit is contained in:
Noah
2026-05-26 11:13:59 +02:00
committed by GitHub
parent 9b6c215fa4
commit 4869ab1992
4 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/src/view/analysis/pgn_games_list_screen.dart
+6 -6
View File
@@ -24,9 +24,9 @@ typedef _GameData = ({
class PgnGamesListScreen extends StatefulWidget {
const PgnGamesListScreen({required this.games, super.key});
final IList<PgnGame> games;
final IList<PgnLazyGame> games;
static Route<dynamic> buildRoute(IList<PgnGame> games) {
static Route<dynamic> buildRoute(IList<PgnLazyGame> games) {
return buildScreenRoute(screen: PgnGamesListScreen(games: games));
}
@@ -113,22 +113,22 @@ class _PgnGamesListScreenState extends State<PgnGamesListScreen> {
separatorBuilder: (context, index) =>
const Divider(height: 1, thickness: 1, indent: 16, endIndent: 16),
itemBuilder: (context, index) {
final game = widget.games[filteredIndices[index]];
final gameData = _gameData[filteredIndices[index]];
return ListTile(
title: Text(gameData.title, maxLines: 2, overflow: .ellipsis),
subtitle: Text(gameData.subtitle, overflow: .ellipsis, maxLines: 1),
onTap: () {
final game = widget.games[filteredIndices[index]];
Navigator.of(context, rootNavigator: true).push(
AnalysisScreen.buildRoute(
AnalysisOptions.pgn(
// TODO generate unique id for each game, maybe based on the PGN headers?
id: const StringId('pgn_import_game'),
orientation: .white,
pgn: game.makePgn(),
pgn: game.rawPgn,
variant: gameData.variant,
isComputerAnalysisAllowed: true,
initialMoveCursor: game.moves.mainline().isEmpty ? 0 : 1,
initialMoveCursor: 1,
),
),
);
@@ -148,7 +148,7 @@ bool _matchesSearchQuery(_GameData gameData, String query) {
gameData.subtitle.toLowerCase().contains(lowerQuery);
}
String _buildGameSubtitle(PgnGame game) {
String _buildGameSubtitle(PgnLazyGame game) {
final event = game.headers['Event'];
final round = game.headers['Round'];
final site = game.headers['Site'];
lib/src/view/more/import_pgn_screen.dart
+2 -2
View File
@@ -31,7 +31,7 @@ class ImportPgnScreen extends StatelessWidget {
static void handlePgnText(BuildContext context, String text) {
try {
final games = PgnGame.parseMultiGamePgn(text);
final games = PgnGame.parseMultiGameLazy(text);
if (games.isEmpty) {
showSnackBar(context, context.l10n.invalidPgn, type: .error);
@@ -49,7 +49,7 @@ class ImportPgnScreen extends StatelessWidget {
orientation: .white,
pgn: text,
isComputerAnalysisAllowed: true,
initialMoveCursor: game.moves.mainline().isEmpty ? 0 : 1,
initialMoveCursor: 1,
variant: rule != null ? Variant.fromRule(rule) : .standard,
),
),