mirror of
https://github.com/zitadel/zitadel.git
synced 2026-07-25 18:28:00 +00:00
6082e59d47
# Which Problems Are Solved - The eventstore did not support intentionally overwriting the resource owner when creating events for aggregates that may be reused across owners. - Resource owner handling was implicit and could not be controlled per command/event type. - We needed a safe way to distinguish between: - keeping the existing aggregate owner, and - explicitly setting a new owner for specific create-like events. # How the Problems Are Solved - Introduced a new eventstore command type with an explicit enforce_owner flag. - Updated eventstore.commands_to_events and eventstore.push so owner assignment is now explicit: - if enforce_owner is true, the command owner is written - if enforce_owner is false, the existing aggregate owner is retained when present - Added EnforceResourceOwnerCommand and wiring so command types can opt in to enforced owner behavior. - Wired the new behavior through the v3 eventstore push path, including compatibility fallback for older command type mapping. - Added migration/setup changes to register and use the new command type and SQL functions. - Added and updated tests for owner overwrite and aggregate ID reuse scenarios. # Additional Changes - Added small migration/setup robustness improvements related to eventstore setup ordering and helper reuse. - Added focused test coverage for enforced owner behavior and sequencing. - Events that currently allow owner changes (implement EnforceResourceOwner) are: - AddedEvent (action) - GroupAddedEvent - StartedEvent (idp intent) - ProjectAddedEvent - HumanAddedEvent - HumanRegisteredEvent - MachineAddedEvent - CreatedEvent (schema user) # Additional Context - Follow-up for eventstore owner-handling correctness in create flows and aggregate ID reuse cases. - No additional issue link was attached for this change. --------- Co-authored-by: abhishek kumar gupta <abhishek818t@gmail.com>
103 lines
2.8 KiB
Go
103 lines
2.8 KiB
Go
package command
|
|
|
|
import (
|
|
"slices"
|
|
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
"github.com/zitadel/zitadel/internal/repository/user"
|
|
)
|
|
|
|
type HumanRecoveryCodeWriteModel struct {
|
|
eventstore.WriteModel
|
|
|
|
State domain.MFAState
|
|
FailedAttempts uint64
|
|
codes []string
|
|
userLocked bool
|
|
}
|
|
|
|
func (wm *HumanRecoveryCodeWriteModel) Codes() []string {
|
|
if wm.codes == nil {
|
|
return make([]string, 0)
|
|
}
|
|
return wm.codes
|
|
}
|
|
|
|
func (wm *HumanRecoveryCodeWriteModel) UserLocked() bool {
|
|
return wm.userLocked
|
|
}
|
|
|
|
func NewHumanRecoveryCodeWriteModel(userID, resourceOwner string) *HumanRecoveryCodeWriteModel {
|
|
return &HumanRecoveryCodeWriteModel{
|
|
WriteModel: eventstore.WriteModel{
|
|
AggregateID: userID,
|
|
ResourceOwner: resourceOwner,
|
|
},
|
|
}
|
|
}
|
|
|
|
func (wm *HumanRecoveryCodeWriteModel) Reduce() error {
|
|
for _, event := range wm.Events {
|
|
switch e := event.(type) {
|
|
case *user.HumanRecoveryCodesAddedEvent:
|
|
wm.codes = append(wm.Codes(), e.Codes...)
|
|
wm.State = domain.MFAStateReady
|
|
case *user.HumanRecoveryCodeCheckSucceededEvent:
|
|
wm.FailedAttempts = 0
|
|
codeCheckedIndex := slices.Index(wm.codes, e.CodeChecked)
|
|
if codeCheckedIndex == -1 {
|
|
// NB: this should typically never happen, but a race-condition could
|
|
// possibly lead to inconsistent state and duplicate code checks
|
|
continue
|
|
}
|
|
wm.codes = slices.Delete(wm.codes, codeCheckedIndex, codeCheckedIndex+1)
|
|
case *user.HumanRecoveryCodeCheckFailedEvent:
|
|
wm.FailedAttempts += 1
|
|
case *user.HumanRecoveryCodesRemovedEvent:
|
|
wm.codes = make([]string, 0)
|
|
wm.State = domain.MFAStateRemoved
|
|
case *user.UserLockedEvent:
|
|
wm.userLocked = true
|
|
case *user.UserUnlockedEvent:
|
|
wm.userLocked = false
|
|
wm.FailedAttempts = 0
|
|
case *user.UserRemovedEvent:
|
|
wm.FailedAttempts = 0
|
|
wm.codes = nil
|
|
wm.userLocked = false
|
|
wm.State = domain.MFAStateRemoved
|
|
case *user.HumanAddedEvent, *user.HumanRegisteredEvent, *user.MachineAddedEvent:
|
|
wm.FailedAttempts = 0
|
|
wm.codes = nil
|
|
wm.userLocked = false
|
|
wm.State = domain.MFAStateUnspecified
|
|
}
|
|
}
|
|
return wm.WriteModel.Reduce()
|
|
}
|
|
|
|
func (wm *HumanRecoveryCodeWriteModel) Query() *eventstore.SearchQueryBuilder {
|
|
query := eventstore.NewSearchQueryBuilder(eventstore.ColumnsEvent).
|
|
AddQuery().
|
|
AggregateTypes(user.AggregateType).
|
|
AggregateIDs(wm.AggregateID).
|
|
EventTypes(
|
|
user.HumanAddedType,
|
|
user.HumanRegisteredType,
|
|
user.MachineAddedEventType,
|
|
user.HumanRecoveryCodesAddedType,
|
|
user.HumanRecoveryCodesRemovedType,
|
|
user.HumanRecoveryCodeCheckSucceededType,
|
|
user.HumanRecoveryCodeCheckFailedType,
|
|
user.UserLockedType,
|
|
user.UserUnlockedType,
|
|
user.UserRemovedType).
|
|
Builder()
|
|
|
|
if wm.ResourceOwner != "" {
|
|
query.ResourceOwner(wm.ResourceOwner)
|
|
}
|
|
return query
|
|
}
|