mirror of
https://github.com/zitadel/zitadel.git
synced 2026-07-25 18:28:00 +00:00
# Which Problems Are Solved Currently, to delete an Organization metadata key, callers must use a separate [DeleteMetadata](https://zitadel.com/docs/reference/api/org/zitadel.org.v2.OrganizationService.DeleteOrganizationMetadata) API. This increases the complexity on client-side for operations where metadata need to be synchronized. # How the Problems Are Solved Introduce deletion behavior to [SetOrganizationMetadata](https://zitadel.com/docs/reference/api/org/zitadel.org.v2.OrganizationService.SetOrganizationMetadata): When a metadata entry is passed with an empty value ("" / empty bytes): - If the key exists → delete the key - If the key does not exist → no-op (idempotent, no error) # Additional Changes n/a # Additional Context Relates to #11776 --------- Co-authored-by: Gayathri Vijayan <66356931+grvijayan@users.noreply.github.com> Co-authored-by: Gayathri Vijayan <gayathri+github@zitadel.com>
225 lines
6.3 KiB
Go
225 lines
6.3 KiB
Go
package command
|
|
|
|
import (
|
|
"bytes"
|
|
"context"
|
|
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
"github.com/zitadel/zitadel/internal/repository/org"
|
|
"github.com/zitadel/zitadel/internal/zerrors"
|
|
)
|
|
|
|
func (c *Commands) SetOrgMetadata(ctx context.Context, orgID string, metadata *domain.Metadata) (_ *domain.Metadata, err error) {
|
|
err = c.checkOrgExists(ctx, orgID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
setMetadata := NewOrgMetadataWriteModel(orgID, metadata.Key)
|
|
orgAgg := OrgAggregateFromWriteModel(&setMetadata.WriteModel)
|
|
event, err := c.setOrgMetadata(ctx, orgAgg, metadata)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
pushedEvents, err := c.eventstore.Push(ctx, event)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
err = AppendAndReduce(setMetadata, pushedEvents...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return writeModelToOrgMetadata(setMetadata), nil
|
|
}
|
|
|
|
func (c *Commands) BulkSetOrgMetadata(ctx context.Context, orgID string, permissionCheck OrganizationPermissionCheck, metadatas ...*domain.Metadata) (_ *domain.ObjectDetails, err error) {
|
|
if len(metadatas) == 0 {
|
|
return nil, zerrors.ThrowPreconditionFailed(nil, "META-9mm2d", "Errors.Metadata.NoData")
|
|
}
|
|
if permissionCheck != nil {
|
|
if err := permissionCheck(ctx, orgID); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
err = c.checkOrgExists(ctx, orgID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
events := make([]eventstore.Command, 0)
|
|
setMetadata, err := c.getOrgMetadataListModelByID(ctx, orgID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
orgAgg := OrgAggregateFromWriteModel(&setMetadata.WriteModel)
|
|
for _, data := range metadatas {
|
|
existingValue, keyExists := setMetadata.metadataList[data.Key]
|
|
|
|
// if value is empty, a metadata remove event has to be pushed
|
|
if len(data.Value) == 0 {
|
|
// Ignore deletion if key does not exist
|
|
if !keyExists {
|
|
continue
|
|
}
|
|
|
|
event := org.NewMetadataRemovedEvent(ctx, orgAgg, data.Key)
|
|
events = append(events, event)
|
|
continue
|
|
}
|
|
|
|
// if no change to metadata no event has to be pushed
|
|
if keyExists && bytes.Equal(existingValue, data.Value) {
|
|
continue
|
|
}
|
|
|
|
event, err := c.setOrgMetadata(ctx, orgAgg, data)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
events = append(events, event)
|
|
}
|
|
|
|
// no changes for the metadata
|
|
if len(events) == 0 {
|
|
return writeModelToObjectDetails(&setMetadata.WriteModel), nil
|
|
}
|
|
|
|
pushedEvents, err := c.eventstore.Push(ctx, events...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
err = AppendAndReduce(setMetadata, pushedEvents...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return writeModelToObjectDetails(&setMetadata.WriteModel), nil
|
|
}
|
|
|
|
func (c *Commands) setOrgMetadata(ctx context.Context, orgAgg *eventstore.Aggregate, metadata *domain.Metadata) (command eventstore.Command, err error) {
|
|
if !metadata.IsValid() {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "META-2ml0f", "Errors.Metadata.Invalid")
|
|
}
|
|
return org.NewMetadataSetEvent(
|
|
ctx,
|
|
orgAgg,
|
|
metadata.Key,
|
|
metadata.Value,
|
|
), nil
|
|
}
|
|
|
|
func (c *Commands) RemoveOrgMetadata(ctx context.Context, orgID, metadataKey string) (_ *domain.ObjectDetails, err error) {
|
|
if metadataKey == "" {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "META-2n0f1", "Errors.Metadata.Invalid")
|
|
}
|
|
err = c.checkOrgExists(ctx, orgID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
removeMetadata, err := c.getOrgMetadataModelByID(ctx, orgID, metadataKey)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if !removeMetadata.State.Exists() {
|
|
return nil, zerrors.ThrowNotFound(nil, "META-mcnw3", "Errors.Metadata.NotFound")
|
|
}
|
|
orgAgg := OrgAggregateFromWriteModel(&removeMetadata.WriteModel)
|
|
event, err := c.removeOrgMetadata(ctx, orgAgg, metadataKey)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
pushedEvents, err := c.eventstore.Push(ctx, event)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
err = AppendAndReduce(removeMetadata, pushedEvents...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return writeModelToObjectDetails(&removeMetadata.WriteModel), nil
|
|
}
|
|
|
|
func (c *Commands) BulkRemoveOrgMetadata(ctx context.Context, orgID string, permissionCheck OrganizationPermissionCheck, metadataKeys ...string) (_ *domain.ObjectDetails, err error) {
|
|
if len(metadataKeys) == 0 {
|
|
return nil, zerrors.ThrowPreconditionFailed(nil, "META-9mw2d", "Errors.Metadata.NoData")
|
|
}
|
|
if permissionCheck != nil {
|
|
if err := permissionCheck(ctx, orgID); err != nil {
|
|
return nil, err
|
|
}
|
|
}
|
|
err = c.checkOrgExists(ctx, orgID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
events := make([]eventstore.Command, len(metadataKeys))
|
|
removeMetadata, err := c.getOrgMetadataListModelByID(ctx, orgID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
orgAgg := OrgAggregateFromWriteModel(&removeMetadata.WriteModel)
|
|
for i, key := range metadataKeys {
|
|
if key == "" {
|
|
return nil, zerrors.ThrowInvalidArgument(nil, "COMMAND-m19ds", "Errors.Metadata.Invalid")
|
|
}
|
|
if _, found := removeMetadata.metadataList[key]; !found {
|
|
return nil, zerrors.ThrowNotFound(nil, "META-2npds", "Errors.Metadata.KeyNotExisting")
|
|
}
|
|
event, err := c.removeOrgMetadata(ctx, orgAgg, key)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
events[i] = event
|
|
}
|
|
|
|
pushedEvents, err := c.eventstore.Push(ctx, events...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
err = AppendAndReduce(removeMetadata, pushedEvents...)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return writeModelToObjectDetails(&removeMetadata.WriteModel), nil
|
|
}
|
|
|
|
func (c *Commands) removeOrgMetadata(ctx context.Context, orgAgg *eventstore.Aggregate, metadataKey string) (command eventstore.Command, err error) {
|
|
command = org.NewMetadataRemovedEvent(
|
|
ctx,
|
|
orgAgg,
|
|
metadataKey,
|
|
)
|
|
return command, nil
|
|
}
|
|
|
|
func (c *Commands) getOrgMetadataModelByID(ctx context.Context, orgID, key string) (*OrgMetadataWriteModel, error) {
|
|
orgMetadataWriteModel := NewOrgMetadataWriteModel(orgID, key)
|
|
err := c.eventstore.FilterToQueryReducer(ctx, orgMetadataWriteModel)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return orgMetadataWriteModel, nil
|
|
}
|
|
|
|
func (c *Commands) getOrgMetadataListModelByID(ctx context.Context, orgID string) (*OrgMetadataListWriteModel, error) {
|
|
orgMetadataWriteModel := NewOrgMetadataListWriteModel(orgID)
|
|
err := c.eventstore.FilterToQueryReducer(ctx, orgMetadataWriteModel)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return orgMetadataWriteModel, nil
|
|
}
|
|
|
|
func writeModelToOrgMetadata(wm *OrgMetadataWriteModel) *domain.Metadata {
|
|
return &domain.Metadata{
|
|
ObjectRoot: writeModelToObjectRoot(wm.WriteModel),
|
|
Key: wm.Key,
|
|
Value: wm.Value,
|
|
State: wm.State,
|
|
}
|
|
}
|