mirror of
https://github.com/zitadel/zitadel.git
synced 2026-07-25 18:28:00 +00:00
6082e59d47
# Which Problems Are Solved - The eventstore did not support intentionally overwriting the resource owner when creating events for aggregates that may be reused across owners. - Resource owner handling was implicit and could not be controlled per command/event type. - We needed a safe way to distinguish between: - keeping the existing aggregate owner, and - explicitly setting a new owner for specific create-like events. # How the Problems Are Solved - Introduced a new eventstore command type with an explicit enforce_owner flag. - Updated eventstore.commands_to_events and eventstore.push so owner assignment is now explicit: - if enforce_owner is true, the command owner is written - if enforce_owner is false, the existing aggregate owner is retained when present - Added EnforceResourceOwnerCommand and wiring so command types can opt in to enforced owner behavior. - Wired the new behavior through the v3 eventstore push path, including compatibility fallback for older command type mapping. - Added migration/setup changes to register and use the new command type and SQL functions. - Added and updated tests for owner overwrite and aggregate ID reuse scenarios. # Additional Changes - Added small migration/setup robustness improvements related to eventstore setup ordering and helper reuse. - Added focused test coverage for enforced owner behavior and sequencing. - Events that currently allow owner changes (implement EnforceResourceOwner) are: - AddedEvent (action) - GroupAddedEvent - StartedEvent (idp intent) - ProjectAddedEvent - HumanAddedEvent - HumanRegisteredEvent - MachineAddedEvent - CreatedEvent (schema user) # Additional Context - Follow-up for eventstore owner-handling correctness in create flows and aggregate ID reuse cases. - No additional issue link was attached for this change. --------- Co-authored-by: abhishek kumar gupta <abhishek818t@gmail.com>
66 lines
1.7 KiB
Go
66 lines
1.7 KiB
Go
package command
|
|
|
|
import (
|
|
"github.com/zitadel/zitadel/internal/domain"
|
|
"github.com/zitadel/zitadel/internal/eventstore"
|
|
"github.com/zitadel/zitadel/internal/repository/metadata"
|
|
"github.com/zitadel/zitadel/internal/repository/org"
|
|
"github.com/zitadel/zitadel/internal/repository/user"
|
|
)
|
|
|
|
type MetadataWriteModel struct {
|
|
eventstore.WriteModel
|
|
|
|
Key string
|
|
Value []byte
|
|
State domain.MetadataState
|
|
}
|
|
|
|
func (wm *MetadataWriteModel) Reduce() error {
|
|
for _, event := range wm.Events {
|
|
switch e := event.(type) {
|
|
case *user.HumanAddedEvent, *user.HumanRegisteredEvent, *user.MachineAddedEvent, *user.UserRemovedEvent,
|
|
*org.OrgAddedEvent, *org.OrgRemovedEvent:
|
|
wm.Value = nil
|
|
wm.State = domain.MetadataStateUnspecified
|
|
case *metadata.SetEvent:
|
|
if wm.Key != e.Key {
|
|
continue
|
|
}
|
|
wm.Value = e.Value
|
|
wm.State = domain.MetadataStateActive
|
|
case *metadata.RemovedEvent:
|
|
if wm.Key != e.Key {
|
|
continue
|
|
}
|
|
wm.State = domain.MetadataStateRemoved
|
|
case *metadata.RemovedAllEvent:
|
|
wm.State = domain.MetadataStateRemoved
|
|
}
|
|
}
|
|
return wm.WriteModel.Reduce()
|
|
}
|
|
|
|
type MetadataListWriteModel struct {
|
|
eventstore.WriteModel
|
|
|
|
metadataList map[string][]byte
|
|
}
|
|
|
|
func (wm *MetadataListWriteModel) Reduce() error {
|
|
for _, event := range wm.Events {
|
|
switch e := event.(type) {
|
|
case *user.HumanAddedEvent, *user.HumanRegisteredEvent, *user.MachineAddedEvent, *user.UserRemovedEvent,
|
|
*org.OrgAddedEvent, *org.OrgRemovedEvent:
|
|
wm.metadataList = make(map[string][]byte)
|
|
case *metadata.SetEvent:
|
|
wm.metadataList[e.Key] = e.Value
|
|
case *metadata.RemovedEvent:
|
|
delete(wm.metadataList, e.Key)
|
|
case *metadata.RemovedAllEvent:
|
|
wm.metadataList = make(map[string][]byte)
|
|
}
|
|
}
|
|
return wm.WriteModel.Reduce()
|
|
}
|