mirror of
https://github.com/trufflesecurity/trufflehog.git
synced 2026-05-16 13:20:35 +00:00
ef9a56c33b
* added gitlab oauth detector * addressed comments; embed detectors.DefaultMultiPartCredentialProvider and use available ctx in tests * made comments more meaningful and break loop when secret is verified against one client id * switch from detectorspb to detector_typepb * populate secretparts * add secretparts to results in gitlaboauth2 detector --------- Co-authored-by: Charlie Gunyon <camgunz@users.noreply.github.com>
186 lines
4.7 KiB
Go
186 lines
4.7 KiB
Go
//go:build detectors
|
|
// +build detectors
|
|
|
|
package gitlaboauth2
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
"time"
|
|
|
|
"github.com/google/go-cmp/cmp"
|
|
"github.com/google/go-cmp/cmp/cmpopts"
|
|
|
|
"github.com/trufflesecurity/trufflehog/v3/pkg/common"
|
|
"github.com/trufflesecurity/trufflehog/v3/pkg/detectors"
|
|
"github.com/trufflesecurity/trufflehog/v3/pkg/pb/detector_typepb"
|
|
)
|
|
|
|
func TestGitlabOauth_FromChunk(t *testing.T) {
|
|
ctx, cancel := context.WithTimeout(context.Background(), time.Second*5)
|
|
defer cancel()
|
|
testSecrets, err := common.GetSecret(ctx, "trufflehog-testing", "detectors6")
|
|
if err != nil {
|
|
t.Fatalf("could not get test secrets from GCP: %s", err)
|
|
}
|
|
|
|
clientId := testSecrets.MustGetField("GITLABOAUTH_CLIENT_ID")
|
|
clientSecret := testSecrets.MustGetField("GITLABOAUTH_CLIENT_SECRET")
|
|
inactiveClientId := testSecrets.MustGetField("GITLABOAUTH_CLIENT_ID_INACTIVE")
|
|
inactiveClientSecret := testSecrets.MustGetField("GITLABOAUTH_CLIENT_SECRET_INACTIVE")
|
|
|
|
type args struct {
|
|
ctx context.Context
|
|
data []byte
|
|
verify bool
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
s Scanner
|
|
args args
|
|
want []detectors.Result
|
|
wantErr bool
|
|
wantVerificationErr bool
|
|
}{
|
|
{
|
|
name: "found, verified",
|
|
s: Scanner{},
|
|
args: args{
|
|
ctx: ctx,
|
|
data: []byte(fmt.Sprintf(`
|
|
gitlab:
|
|
client_id: %s
|
|
client_secret: %s
|
|
`, clientId, clientSecret)),
|
|
verify: true,
|
|
},
|
|
want: []detectors.Result{
|
|
{
|
|
DetectorType: detector_typepb.DetectorType_GitLabOauth2,
|
|
Verified: true,
|
|
},
|
|
},
|
|
wantErr: false,
|
|
wantVerificationErr: false,
|
|
},
|
|
{
|
|
name: "found, unverified",
|
|
s: Scanner{},
|
|
args: args{
|
|
ctx: ctx,
|
|
data: []byte(fmt.Sprintf(`
|
|
gitlab:
|
|
client_id: %s
|
|
client_secret: %s
|
|
`, inactiveClientId, inactiveClientSecret)),
|
|
verify: true,
|
|
},
|
|
want: []detectors.Result{
|
|
{
|
|
DetectorType: detector_typepb.DetectorType_GitLabOauth2,
|
|
Verified: false,
|
|
},
|
|
},
|
|
wantErr: false,
|
|
wantVerificationErr: false,
|
|
},
|
|
{
|
|
name: "not found",
|
|
s: Scanner{},
|
|
args: args{
|
|
ctx: ctx,
|
|
data: []byte("You cannot find the secret within"),
|
|
verify: true,
|
|
},
|
|
want: nil,
|
|
wantErr: false,
|
|
wantVerificationErr: false,
|
|
},
|
|
{
|
|
name: "found, would be verified if not for timeout",
|
|
s: Scanner{client: common.SaneHttpClientTimeOut(1 * time.Microsecond)},
|
|
args: args{
|
|
ctx: ctx,
|
|
data: []byte(fmt.Sprintf(`
|
|
gitlab:
|
|
client_id: %s
|
|
client_secret: %s
|
|
`, clientId, clientSecret)),
|
|
verify: true,
|
|
},
|
|
want: []detectors.Result{
|
|
{
|
|
DetectorType: detector_typepb.DetectorType_GitLabOauth2,
|
|
Verified: false,
|
|
},
|
|
},
|
|
wantErr: false,
|
|
wantVerificationErr: true,
|
|
},
|
|
{
|
|
name: "found, verified but unexpected api surface",
|
|
s: Scanner{client: common.ConstantResponseHttpClient(404, "")},
|
|
args: args{
|
|
ctx: ctx,
|
|
data: []byte(fmt.Sprintf(`
|
|
gitlab:
|
|
client_id: %s
|
|
client_secret: %s
|
|
`, clientId, clientSecret)),
|
|
verify: true,
|
|
},
|
|
want: []detectors.Result{
|
|
{
|
|
DetectorType: detector_typepb.DetectorType_GitLabOauth2,
|
|
Verified: false,
|
|
},
|
|
},
|
|
wantErr: false,
|
|
wantVerificationErr: true,
|
|
},
|
|
}
|
|
for _, tt := range tests {
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
tt.s.SetCloudEndpoint(tt.s.CloudEndpoint())
|
|
tt.s.UseCloudEndpoint(true)
|
|
got, err := tt.s.FromData(tt.args.ctx, tt.args.verify, tt.args.data)
|
|
if (err != nil) != tt.wantErr {
|
|
t.Errorf("GitlabOauth.FromData() error = %v, wantErr %v", err, tt.wantErr)
|
|
return
|
|
}
|
|
for i := range got {
|
|
if len(got[i].Raw) == 0 {
|
|
t.Fatalf("no raw secret present: \n %+v", got[i])
|
|
}
|
|
if (got[i].VerificationError() != nil) != tt.wantVerificationErr {
|
|
t.Fatalf("wantVerificationError = %v, verification error = %v", tt.wantVerificationErr, got[i].VerificationError())
|
|
}
|
|
}
|
|
ignoreOpts := cmpopts.IgnoreFields(detectors.Result{},
|
|
"Raw", "RawV2", "verificationError", "ExtraData", "primarySecret", "SecretParts")
|
|
if diff := cmp.Diff(got, tt.want, ignoreOpts); diff != "" {
|
|
t.Errorf("GitlabOauth.FromData() %s diff: (-got +want)\n%s", tt.name, diff)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func BenchmarkFromData(benchmark *testing.B) {
|
|
ctx := context.Background()
|
|
s := Scanner{}
|
|
s.SetCloudEndpoint(s.CloudEndpoint())
|
|
s.UseCloudEndpoint(true)
|
|
for name, data := range detectors.MustGetBenchmarkData() {
|
|
benchmark.Run(name, func(b *testing.B) {
|
|
b.ResetTimer()
|
|
for n := 0; n < b.N; n++ {
|
|
_, err := s.FromData(ctx, false, data)
|
|
if err != nil {
|
|
b.Fatal(err)
|
|
}
|
|
}
|
|
})
|
|
}
|
|
}
|