* Start moving user agent utils into shared package
* Remove inobounce and stop exporting isIosSafari
Based on some quick testing on my phone, inobounce is no longer needed. Both
local and Community:
1. Let you overscroll on the landing and login pages
2. Don't overscroll in a channel, a thread, or the LHS while fully zoomed out
3. Do let you overscroll when zoomed in
That also lets me reduce the size of the interface for utils/user_agent.
* Remove unneeded exports and unused functions
* Remove outdated workarounds from FileUpload component
These were only needed to support a 10 year old version of iOS Chrome and the classic app.
* Remove useOrientationHandler
This was added in https://github.com/mattermost/mattermost-webapp/pull/2504,
but I don't think the extra complexity is worth keeping it around
when we mostly support mobile view for desktop accessibility reasons.
* Replace isIosWeb/isAndroidWeb with isIos/isAndroid
These were previously needed to differentiate between the mobile web app
and the classic app.
* Replace isMobileApp with isMobile
Similar to the last commit, we used to need to differentiate
between the mobile web and the classic app. For most places,
I just replaced isMobileApp with isMobile, but I removed the
check in ProductMenuList because we want to show that link
on mobile web.
* Move isInternetExplorer and isEdge out of the shared package
Those should be removed, so I don't want to include them in
the shared package at all. I also renamed isChromiumEdge to
just isEdge since that should be its name once the old ones
are removed.
* Change how functions are re-exported to fix tests
* Update web app code to use shared user agent utils directly
* Removed useless mock
* Fix how tests mock utils/user_agent now that it's fully moved
* Actually export user_agent utils from shared package
* removes direct jaytaylor/html2text dependency
there is still some indirect dependency on the library preventing
to use latest tablewriter with a PR made to the outdated library
that should be monitored as stated in go.mod comments.
* makes variable not shadow outer one
* fixes typo and makes test fail on error
* uses current docconv dependency to generate plain text email content
* MM-64486: Remove telemetry
Remove telemetry from Mattermost. We're no longer relying on Rudder upstream, and no longer making use of this information.
* recover mock for SystemStore.Get
* Fix TestClearPushNotificationSync by adding missing SystemStore mock
The test was failing because the SystemStore mock was missing the Get()
method that's required by the ServerId() function. Added the missing mock
to return a StringMap with SystemServerId.
* fix mocking issue
* Remove now-unused telemetry and constants
* Remove "Disable telemetry events" debug setting
* Remove empty functions
* Remove most "Telemetry tracking removed" comments
* Remove remains of DataPrefetch telemetry
* Remove now-unused prop from InviteMembersButton
* Remove trackDotMenuEvent
* Remove some more leftover comments
* Remove lingering logic related to trackingLocation
* Remove now-unused argument from useCopyText
* Remove lingering telemetry references from PreparingWorkspace
* fixup Remove trackDotMenuEvent
* Remove lingering telemetry references from signup page and password check
* Update snapshots and fix test broken by my changes
* Fix unintended behavior change in thread list filtering
Remove handleSetFilter wrapper that was accidentally modified during
telemetry removal. The function was calling clear() when switching to
unread filter, which was not the original behavior. Use setFilter
directly instead, restoring the original functionality.
* Remove unused useOpenDowngradeModal hook
The useOpenDowngradeModal hook was not being used anywhere in the codebase.
* Remove unused expandableLink from useExpandOverageUsersCheck
The expandableLink return value was not being used by any components.
* Re-add missing TeamLinkClicked performance telemetry
The mark(Mark.TeamLinkClicked) call was accidentally removed from the
handleSwitch function. This telemetry is needed for Looker-based
performance tracking.
* drop LogSettings.VerboseDiagnostics
---------
Co-authored-by: Harrison Healey <harrisonmhealey@gmail.com>
Co-authored-by: Mattermost Build <build@mattermost.com>
* Add simplebar-react at latest version supported by React 17
* Prevent sidebars and centre channel from overflowing the page vertically
* Add Scrollbars component and replace react-custom-scrollbars
* Remove react-custom-scrollbars
* Fix usage of Scrollbars in modals
The various way we reuse .more-modal, .more-modal__list, and
.filtered-user-list in slightly different ways really made painful. We
should revisit that at some point when we get the chance since those
classes are used in a bunch of contradictory ways like using
.more-modal__list in a popover list in Multiselect versus as part of the
modal in the Browse Channel modal. It also doesn't help that some modals
use Scrollbars and others just use `overflow: auto` on either the whole
modal or on the .more-modal__list.
* Fix dragging the LHS scrollbar also dragging the channel behind it
* Fix scrolling in Browse Channels modal
* Fix results in user group modals not scrolling
* Update snapshots and fix tests
* Prevent focusing simplebar divs (accessibility_sidebar_spec.ts)
* Fix admin LHS still being able to scroll (openid_spec.ts)
* Migrate Team Members modal to GenericModal and the new menu (manage_members_spec.js)
The menu was being cut off yet again by the contents of the modal, so I
migrated that to the new menu to portal it out of that. Unfortunately,
that caused the infinite recursion bug between MUI and React Bootstrap's
focus trap logic, so I had to also migrate the modal to GenericModal to
fix that.
* Update snapshot and fix test
* Update snapshot and fix test
* Fix another E2E test
* More snapshots
* Remove Flex component
* Remove Heading component
* Remove StatusIcon component
* Migrate IconButton from Compass Components repo
* Remove unused variants of IconButton and move into GlobalHeader
We only actually used IconButton in a limited set of locations (all
currently in the global header), and if I tried to test other
variations, they seemed to often have issues (like white text on a white
background). Most of those seemed to be because the theme in the
CompassThemeProvider was missing fields and fell back to defaults that
didn't make sense, but there were also enough errors in IconButtonRoot
(like invalid transitions or other logical errors) that lead me to just
rip out everything we don't currently use.
* Remove CompassThemeProvider
* Remove remaining references to @mattermost/compass-components
* Remove prop that's no longer needed
unified-ci-app[bot]
Harrison Healey
Christopher Poile
Carlos Garcia
Jesse Hallam
Eva Sarafianou
Jesús Espino
Takuya N
Amy Blais
Jian Lim
Mattermod