flutter-docker-image/openspec/changes/p2-release-windows-image/proposal.md at 792b91c4451caf2d0034fc35441afd1bb20ee90d

mirror of https://github.com/gmeligio/flutter-docker-image.git synced 2026-05-24 12:30:34 +00:00

Files

T

Eligio Mariño 792b91c445 ci: test windows image (#339 )

- **`windows.Dockerfile`** — fixes the `COPY` source path from
`./test/Windows.Tests.ps1` to `./test/windows/Windows.Tests.ps1` (root
cause of the 12-month "in_progress forever" state); adds `COPY
./config/version.json` to the `test` stage; replaces the commented `CMD`
with a real `CMD` so `docker run`/`docker compose run` invokes Pester
without arguments.
- **`test/windows/Windows.Tests.ps1`** — fixes the `VC.CMake.Project`
pattern typo (`,versiona*` → `,version=*`) and standardises all three
VS-component patterns to `,version=*`; adds a `Flutter version` test
that reads `config/version.json` and asserts `flutter --version` inside
the container reports the same version; adds a `Flutter doctor` test
with a per-line parser (skip disabled platforms, fail on any non-`[✓]`
for Windows toolchain lines, fail on `[✗]` elsewhere).
- **`script/RunPester.ps1`** — forces `[Console]::OutputEncoding = UTF8`
so the `[✓]`/`[!]`/`[✗]` doctor glyphs survive the `windows-2025`
runner's default OEM codepage.
- **`test/windows/`** — deletes the dead `ory/dockertest` Go skeleton
(`main.go`, `main_test.go`, `go.mod`, `go.sum`) that was never wired
into CI and had its only meaningful assertion commented out.
- **`.github/workflows/windows.yml`** — deletes three commented-out
blocks (`Scan with Docker Scout`, `Push to Docker Hub`,
`validate_version` job referencing the deleted `config/version.cue`);
drops the now-unused elevated permissions (`packages: write`,
`pull-requests: write`, `security-events: write`).

---------

Co-authored-by: verified-commit[bot] <180343340+verified-commit[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-10 16:15:33 +02:00

3.2 KiB

Raw Blame History

Why

release.yml only builds and publishes the flutter-android image on tag. The Windows Dockerfile, the windows-2025 test workflow, and the IMAGE_REPOSITORY_NAME: flutter-windows env var in windows.yml all imply a flutter-windows image is shipped — but no release path actually pushes it. Once p1-fix-windows-ci-tests lands and CI verifies the image, users still cannot docker pull <org>/flutter-windows:<flutter-version>. This change adds a release_windows job to release.yml that mirrors release_android for the Windows artifact, so cutting a tag publishes both images.

What Changes

Add a new release_windows job to .github/workflows/release.yml that runs on windows-2025, builds windows.Dockerfile with --target flutter, and pushes the resulting image to Docker Hub, GitHub Container Registry, and Quay.io with the <flutter-version> tag (matching the existing Android tagging convention).
Reuse script/setEnvironmentVariables.js and docker/metadata-action exactly as release_android does, so the tag/label conventions stay identical across architectures.
Login steps reuse the existing DOCKER_HUB_*, QUAY_*, and GHCR credentials. No new secrets are introduced.
The new job runs in parallel with release_android (no needs: dependency between them) so a Windows build failure does not block Android publishing and vice versa.
The downstream update_description, record_image, set_bootstrap_image, and create_github_release jobs that currently needs: release_android are NOT changed: they remain Android-scoped because the Docker Hub description, Scout environment, bootstrap-image variable, and changelog all currently reference Android only. Generalizing them is out of scope.
The test_windows PR check from p1 SHALL be a required check before tags can be cut, but the actual gating is repository-settings-only and not in this PR's diff.

Capabilities

New Capabilities

windows-image-release: defines what release.yml must do on a tag push so that a flutter-windows:<flutter-version> image is published to the same set of registries as the Android image.

Modified Capabilities

None. The existing flutter-version-update and actions-version-tracking specs are unaffected. release_android is unchanged.

Impact

Affected files: .github/workflows/release.yml (one new job added), .github/gx.toml and .github/gx.lock (new entries if any new actions are introduced — none expected; the new job uses actions already pinned via the Android job).
Depends on: p1-fix-windows-ci-tests landed (so the image is verified before publishing), but does not depend on p3-windows-version-schema (versioning of the Windows artifact follows the existing flutter.version convention).
Operational impact: every tag push triggers an additional windows-2025 run, which currently takes 30–60 minutes. Tag-push to first-Windows-image-published wall-clock time grows by that amount.
Cost: windows-2025 runner minutes are billed; the budget impact should be reviewed before this lands.
Risk: a flaky Windows build will block release tags. Mitigation is captured in the design (manual workflow_dispatch fallback already exists in release.yml and continues to work for Android).

3.2 KiB Raw Blame History Unescape Escape

Why