From ede23a9990d5b5ea837d72edd85261d9f13759ca Mon Sep 17 00:00:00 2001 From: man-y Date: Fri, 21 Jun 2024 11:44:43 +0300 Subject: [PATCH] Remove dispose from public div-context 9f09d0c46966e63b6612f45fec82592beb8ca7f3 --- client/flutter/divkit/CHANGELOG.md | 1 + client/flutter/divkit/example/ios/Podfile.lock | 4 ++-- client/flutter/divkit/lib/src/core/divkit.dart | 2 +- client/flutter/divkit/lib/src/core/protocol/div_context.dart | 3 --- 4 files changed, 4 insertions(+), 6 deletions(-) diff --git a/client/flutter/divkit/CHANGELOG.md b/client/flutter/divkit/CHANGELOG.md index d585a5c64..5c665a3a7 100644 --- a/client/flutter/divkit/CHANGELOG.md +++ b/client/flutter/divkit/CHANGELOG.md @@ -1,6 +1,7 @@ ## 0.1.6-pre * Correct interpretation of dict in variables context * Add support of longtap actions +* Remove dispose from public div-context ## 0.1.5 * Templater support: templates can be inherited, composited, links and transitive links to fields. diff --git a/client/flutter/divkit/example/ios/Podfile.lock b/client/flutter/divkit/example/ios/Podfile.lock index eb8efa592..a127150ee 100644 --- a/client/flutter/divkit/example/ios/Podfile.lock +++ b/client/flutter/divkit/example/ios/Podfile.lock @@ -1,5 +1,5 @@ PODS: - - div_expressions_resolver (0.4.1): + - div_expressions_resolver (0.4.2): - DivKit (~> 29.0) - Flutter - DivKit (29.15.1): @@ -76,7 +76,7 @@ EXTERNAL SOURCES: :path: ".symlinks/plugins/sqflite/darwin" SPEC CHECKSUMS: - div_expressions_resolver: 6734959e5feaf44241ea4d4888274eeca9557586 + div_expressions_resolver: cfd6eedb1a599d16fbfed6b25d2709cf8b3807da DivKit: 96a1189bbb1286544119551819db721237edc49a DivKit_LayoutKit: d8cd3826a2d004b159517d514e1580467f89efc3 DivKit_LayoutKitInterface: 805245d61e6525632171de529592afb880692cae diff --git a/client/flutter/divkit/lib/src/core/divkit.dart b/client/flutter/divkit/lib/src/core/divkit.dart index 0bcd8c2e9..92878b4a2 100644 --- a/client/flutter/divkit/lib/src/core/divkit.dart +++ b/client/flutter/divkit/lib/src/core/divkit.dart @@ -247,7 +247,7 @@ class _DivKitViewState extends State<_DivKitView> { @override void dispose() { - divContext.dispose(); + divRootContext.dispose(); triggerManager.dispose(); loggerUse(loggerContext).debug("Dispose DivKitView $hashCode"); diff --git a/client/flutter/divkit/lib/src/core/protocol/div_context.dart b/client/flutter/divkit/lib/src/core/protocol/div_context.dart index a25c1f094..fd056fa9a 100644 --- a/client/flutter/divkit/lib/src/core/protocol/div_context.dart +++ b/client/flutter/divkit/lib/src/core/protocol/div_context.dart @@ -14,8 +14,6 @@ abstract class DivContext { DivTimerManager get timerManager; FocusNode? getFocusNode(String divId); - - Future dispose(); } class DivRootContext extends DivContext { @@ -61,7 +59,6 @@ class DivRootContext extends DivContext { return null; } - @override Future dispose() async { _stateManager?.dispose(); await _timerManager?.dispose();