* Added test for when includes contain relative paths with the same name.
* Updated mergedDictionary to handle includes with the same file path.
* Removed the need to multiple places to pass in cachedSpecFiles.
* Converts the projectRoot into a absolute path before loading a project.
* Updated changelog.
* Fix recursive include path when relativePath is not set
If relativePath is not set on a particular include, the first level of
include will currently work, but starting at the second level of
iteration, the computed include path will fail as relativePath will be
appended over and over onto the filePath. We're fixing that recursion
problem here and adding the corresponding tests to make sure it doesn't
happen again.
* Include projectRoot in include paths
The projectRoot setting (when specified) is currently ignored when
computing the include paths. We're fixing that in that commit.
* Use memoization during recursive SpecFiles creation
SpecFile objects are created by recursive through includes. On a large
project with programatically generated SpecFile, it is not rare to have
hundreds of SpecFiles, creating a large web of include dependencies.
In such a case, it is not rare either for a particular SpecFile to be
included by multiple other SpecFiles. When that happens, XcodeGen
currently creates a SpecFile object every time a SpecFile gets included,
which can lead to an exponential growth of includes.
I have seen hundreds of files being turned into hundred of thousands of
SpecFile object creations, which leads to an impractical XcodeGen run of
tens of minutes.
This change adds memoization during SpecFile recursion, in order to
reuse the previously created SpecFiles, if available, instead of
re-creating them.
* Update CHANGELOG.md
Add the following changes to the changelog:
* b97bdc4 - Use memoization during recursive SpecFiles creation
* a6b96ad - Include projectRoot in include paths
* 557b074 - Fix recursive include path when relativePath is not set
* add new option enable for include of spec
* fix to see the environment variable when parsing include
* add test for include with environment variable
* fix how to parse boolean value
* add spec about enable for include
* add Change Log
* fix the number of PR in changelog
* fix include test to make more clear
* fix test to focus enable option more
* fix english error
* fix to expand variable only one time
* add new test case by setting environment object as NO
* Failing test for #975
* fixes#975
* chore: refactor to properly select a config from a collection with specific variant and config type
chore: updated changelog
* fix: lowercase compare on config variant names
* fix CI
* fix missing scheme for CI
* fix schemes for CI
* Update CHANGELOG.md
Co-authored-by: Yonas Kolb <yonaskolb@users.noreply.github.com>
* Update Sources/ProjectSpec/Config.swift
Co-authored-by: Yonas Kolb <yonaskolb@users.noreply.github.com>
* - fix compilation issue
- duplicated test for config variant name (uppercase/lowercase)
Co-authored-by: Yonas Kolb <yonaskolb@users.noreply.github.com>
* Improving variable expansion runtime
The current implementation of variable expansion is O(n x m) with n being the
number of strings in the project spec and m being the number of project variables.
This implementation is now O(n).
Also, this effectively deprecates the support for $legacy_variables in favor of the
${new_variables} making this whole patch possible.
* Adding option to disable variable expansion
* Adding performance test for spec loading
* Updating changelog
Marcos Griselli
Wendy Liga
Craig Siemens
Mathieu Olivari
freddi(Yuki Aki)
Stefano Mondino
Joseph Colicchio
ionutivan
Kohki Miki
Romuald Cari
Miles Hollingsworth
yonaskolb
Rogerio de Paula Assis