From 5bf1678e1fc3bc538eeda7598bb72b136b367938 Mon Sep 17 00:00:00 2001 From: Andras Kadar Date: Fri, 17 May 2019 09:29:30 +0200 Subject: [PATCH] Remove default empty array & add changelog --- CHANGELOG.md | 1 + Sources/ProjectSpec/Scheme.swift | 5 ++--- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 30115b27..c43c8b13 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,7 @@ #### Added - Added ability to encode ProjectSpec to JSON [#545](https://github.com/yonaskolb/XcodeGen/pull/545) @ryohey +- Added ability to skip tests [#582](https://github.com/yonaskolb/XcodeGen/pull/582) @kadarandras ## 2.5.0 diff --git a/Sources/ProjectSpec/Scheme.swift b/Sources/ProjectSpec/Scheme.swift index 4630e5ea..29ee1241 100644 --- a/Sources/ProjectSpec/Scheme.swift +++ b/Sources/ProjectSpec/Scheme.swift @@ -102,7 +102,6 @@ public struct Scheme: Equatable { public struct TestTarget: Equatable, ExpressibleByStringLiteral { public static let randomExecutionOrderDefault = false public static let parallelizableDefault = false - public static let skippedTestsDefault: [String] = [] public let name: String public var randomExecutionOrder: Bool @@ -113,7 +112,7 @@ public struct Scheme: Equatable { name: String, randomExecutionOrder: Bool = randomExecutionOrderDefault, parallelizable: Bool = parallelizableDefault, - skippedTests: [String] = skippedTestsDefault + skippedTests: [String] = [] ) { self.name = name self.randomExecutionOrder = randomExecutionOrder @@ -311,7 +310,7 @@ extension Scheme.Test.TestTarget: JSONObjectConvertible { name = try jsonDictionary.json(atKeyPath: "name") randomExecutionOrder = jsonDictionary.json(atKeyPath: "randomExecutionOrder") ?? Scheme.Test.TestTarget.randomExecutionOrderDefault parallelizable = jsonDictionary.json(atKeyPath: "parallelizable") ?? Scheme.Test.TestTarget.parallelizableDefault - skippedTests = jsonDictionary.json(atKeyPath: "skippedTests") ?? Scheme.Test.TestTarget.skippedTestsDefault + skippedTests = jsonDictionary.json(atKeyPath: "skippedTests") ?? [] } }