From 43177dec49ef8a8097ea994e3b08f0ac27880ee9 Mon Sep 17 00:00:00 2001
From: Cody Vandermyn <721474+codeman9@users.noreply.github.com>
Date: Mon, 28 Sep 2020 23:44:53 -0700
Subject: [PATCH] Select the first runnable target (#957)

* Select the first runnable target, if there is one

Instead of just selecting the first target as the scheme target, instead search for and select the first runnable target. If there are no runnables found, then select the first target.

* update docs
---
 CHANGELOG.md                                   |  1 +
 Docs/ProjectSpec.md                            |  2 +-
 Sources/XcodeGenKit/SchemeGenerator.swift      |  3 ++-
 .../SchemeGeneratorTests.swift                 | 18 ++++++++++++++++++
 4 files changed, 22 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 7ff0a575..286cf2b4 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -12,6 +12,7 @@
 - Updates CI to run on Xcode 12 beta. [#936](https://github.com/yonaskolb/XcodeGen/pull/936) @dflems
 
 #### Fixed
+- Select the first runnable build target, if present. [#957](https://github.com/yonaskolb/XcodeGen/pull/957) @codeman9
 - Allow SDK dependencies to be embedded. [#922](https://github.com/yonaskolb/XcodeGen/pull/922) @k-thorat
 - Allow creating intermediary groups outside of the project directory. [#892](https://github.com/yonaskolb/XcodeGen/pull/892) @segiddins
 - Fix appex's Runpath Search Paths under macOS target. [#952](https://github.com/yonaskolb/XcodeGen/pull/952) @rinsuki
diff --git a/Docs/ProjectSpec.md b/Docs/ProjectSpec.md
index e8b13677..aec3502a 100644
--- a/Docs/ProjectSpec.md
+++ b/Docs/ProjectSpec.md
@@ -783,7 +783,7 @@ Scheme run scripts added via **preActions** or **postActions**. They run before
 A multiline script can be written using the various YAML multiline methods, for example with `|`. See [Build Script](#build-script).
 
 ### Run Action
-- [ ] **executable**: **String** - the name of the target to launch as an executable. Defaults to the first build target in the scheme
+- [ ] **executable**: **String** - the name of the target to launch as an executable. Defaults to the first runnable build target in the scheme, or the first build target if a runnable build target is not found
 - [ ] **customLLDBInit**: **String** - the absolute path to the custom `.lldbinit` file
 
 ### Test Action
diff --git a/Sources/XcodeGenKit/SchemeGenerator.swift b/Sources/XcodeGenKit/SchemeGenerator.swift
index 3d1686cc..94ba4ffa 100644
--- a/Sources/XcodeGenKit/SchemeGenerator.swift
+++ b/Sources/XcodeGenKit/SchemeGenerator.swift
@@ -165,7 +165,8 @@ public class SchemeGenerator {
         if let targetName = scheme.run?.executable {
             schemeTarget = project.getTarget(targetName)
         } else {
-            schemeTarget = target ?? project.getTarget(scheme.build.targets.first!.target.name)
+            let name = scheme.build.targets.first { $0.buildTypes.contains(.running) }?.target.name ?? scheme.build.targets.first!.target.name
+            schemeTarget = target ?? project.getTarget(name)
         }
 
         let shouldExecuteOnLaunch = schemeTarget?.shouldExecuteOnLaunch == true
diff --git a/Tests/XcodeGenKitTests/SchemeGeneratorTests.swift b/Tests/XcodeGenKitTests/SchemeGeneratorTests.swift
index 85481d63..0d4e1701 100644
--- a/Tests/XcodeGenKitTests/SchemeGeneratorTests.swift
+++ b/Tests/XcodeGenKitTests/SchemeGeneratorTests.swift
@@ -104,6 +104,24 @@ class SchemeGeneratorTests: XCTestCase {
                 try expect(xcscheme.testAction?.customLLDBInitFile) == "/test/.lldbinit"
             }
 
+            let frameworkTarget = Scheme.BuildTarget(target: .local(framework.name), buildTypes: [.archiving])
+            $0.it("generates a scheme with the first runnable selected") {
+                let scheme = Scheme(
+                    name: "MyScheme",
+                    build: Scheme.Build(targets: [frameworkTarget, buildTarget])
+                )
+                let project = Project(
+                    name: "test",
+                    targets: [framework, app],
+                    schemes: [scheme]
+                )
+                let xcodeProject = try project.generateXcodeProject()
+                let xcscheme = try unwrap(xcodeProject.sharedData?.schemes.first)
+
+                let buildableReference = xcscheme.launchAction?.runnable?.buildableReference
+                try expect(buildableReference?.buildableName) == "MyApp.app"
+            }
+
             $0.it("generates scheme with multiple configs") {
                 let configs: [Config] = [
                     Config(name: "Beta", type: .debug),