mirror of
https://github.com/TextureGroup/Texture.git
synced 2026-04-07 19:17:39 +00:00
rqueue
9b2e3532ea
This experiment makes sure a ASCollectionView's `rangeController` updates when a changeset WITH updates is applied. Currently it is possible for nodes inserted into the preload range to not get preloaded when performing a batch update. For example, suppose a collection node has: - Tuning parameters with a preload range of 1 screenful for the given range mode. - Nodes A and B where A is visible and B is off screen. Currently if node B is deleted and a new node C is inserted in its place, node C will not get preloaded until the collection node is scrolled. This is because the preloading mechanism relies on a `setNeedsUpdate` call on the range controller as part of the `-collectionView:willDisplayCell:forItemAtIndexPath:` delegate method when the batch update is submitted. However, in the example outlined above, this sometimes doesn't happen automtically, causing the range update to be delayed until the next the view scrolls.
53 lines
1.9 KiB
Plaintext
53 lines
1.9 KiB
Plaintext
//
|
|
// ASExperimentalFeatures.mm
|
|
// Texture
|
|
//
|
|
// Copyright (c) Pinterest, Inc. All rights reserved.
|
|
// Licensed under Apache 2.0: http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
|
|
#import <AsyncDisplayKit/ASExperimentalFeatures.h>
|
|
|
|
#import <AsyncDisplayKit/ASCollections.h>
|
|
|
|
NSArray<NSString *> *ASExperimentalFeaturesGetNames(ASExperimentalFeatures flags)
|
|
{
|
|
NSArray *allNames = ASCreateOnce((@[@"exp_text_node",
|
|
@"exp_interface_state_coalesce",
|
|
@"exp_infer_layer_defaults",
|
|
@"exp_collection_teardown",
|
|
@"exp_framesetter_cache",
|
|
@"exp_skip_clear_data",
|
|
@"exp_did_enter_preload_skip_asm_layout",
|
|
@"exp_dispatch_apply",
|
|
@"exp_drawing_global",
|
|
@"exp_optimize_data_controller_pipeline",
|
|
@"exp_disable_global_textkit_lock",
|
|
@"exp_main_thread_only_data_controller",
|
|
@"exp_range_update_on_changeset_update"]));
|
|
if (flags == ASExperimentalFeatureAll) {
|
|
return allNames;
|
|
}
|
|
|
|
// Go through all names, testing each bit.
|
|
NSUInteger i = 0;
|
|
return ASArrayByFlatMapping(allNames, NSString *name, ({
|
|
(flags & (1 << i++)) ? name : nil;
|
|
}));
|
|
}
|
|
|
|
// O(N^2) but with counts this small, it's probably faster
|
|
// than hashing the strings.
|
|
ASExperimentalFeatures ASExperimentalFeaturesFromArray(NSArray<NSString *> *array)
|
|
{
|
|
NSArray *allNames = ASExperimentalFeaturesGetNames(ASExperimentalFeatureAll);
|
|
ASExperimentalFeatures result = kNilOptions;
|
|
for (NSString *str in array) {
|
|
NSUInteger i = [allNames indexOfObject:str];
|
|
if (i != NSNotFound) {
|
|
result |= (1 << i);
|
|
}
|
|
}
|
|
return result;
|
|
}
|