mirror of
https://github.com/TextureGroup/Texture.git
synced 2026-04-07 19:17:39 +00:00
Christos Gkekas
17d4d13463
* Exposes a new option in ASImageDownloaderProtocol to retry image downloads At the moment the ASBasicImageDownloader does not automatically retry image downloads if the remote host is unreachable. On the contrary the ASPINRemoteImageDownloader automatically retries. Retrying is something that ultimately clients need to be able to control, for example to fail fast to an alternative image rather than keep retrying for more than one minute while not displaying any image. This change exposes a new option in the ASImageDownloaderProtocol to retry image downloads. It also uses this new option in both ASNetworkImageNode and also ASMultiplexImageNode, setting it to YES to preserve the current behaviour. * Fixes a failing test in ASMultiplexImageNodeTests * Fixes ScreenNode.m ScreenNode.m is implementing ASImageDownloaderProtocol and needs to be fixed to reflect changes in the latter.
37 lines
1.4 KiB
Objective-C
37 lines
1.4 KiB
Objective-C
//
|
|
// ASBasicImageDownloader.h
|
|
// Texture
|
|
//
|
|
// Copyright (c) Facebook, Inc. and its affiliates. All rights reserved.
|
|
// Changes after 4/13/2017 are: Copyright (c) Pinterest, Inc. All rights reserved.
|
|
// Licensed under Apache 2.0: http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
|
|
#import <AsyncDisplayKit/ASImageProtocols.h>
|
|
|
|
NS_ASSUME_NONNULL_BEGIN
|
|
|
|
/**
|
|
* @abstract Simple NSURLSession-based image downloader.
|
|
*/
|
|
@interface ASBasicImageDownloader : NSObject <ASImageDownloaderProtocol>
|
|
|
|
/**
|
|
* A shared image downloader which can be used by @c ASNetworkImageNodes and @c ASMultiplexImageNodes.
|
|
* The userInfo provided by this downloader is `nil`.
|
|
*
|
|
* This is a very basic image downloader. It does not support caching, retrying, progressive downloading and likely
|
|
* isn't something you should use in production. If you'd like something production ready, see @c ASPINRemoteImageDownloader
|
|
*
|
|
* @note It is strongly recommended you include PINRemoteImage and use @c ASPINRemoteImageDownloader instead.
|
|
*/
|
|
@property (class, readonly) ASBasicImageDownloader *sharedImageDownloader;
|
|
+ (ASBasicImageDownloader *)sharedImageDownloader NS_RETURNS_RETAINED;
|
|
|
|
+ (instancetype)new __attribute__((unavailable("+[ASBasicImageDownloader sharedImageDownloader] must be used.")));
|
|
- (instancetype)init __attribute__((unavailable("+[ASBasicImageDownloader sharedImageDownloader] must be used.")));
|
|
|
|
@end
|
|
|
|
NS_ASSUME_NONNULL_END
|