* Fix references of ASViewController (non-existent) to ASDKViewController
* More references changes to old ASViewController
* Also update ASNavigationController -> ASDKNavigationController
Having a semi-colon between a method parameters list and a method
body is not not correct and is usually caused by a copy and paste
error while creating the method definition from its declaration.
Fixes the following compilation warnings when building with
-Wsemicolon-before-method-body (which is part of -Wextra):
ASPINRemoteImageDownloader.mm:230:85: error: semicolon before method body is ignored [-Werror,-Wsemicolon-before-method-body]
- (id <ASImageContainerProtocol>)synchronouslyFetchedCachedImageWithURL:(NSURL *)URL;
^
ASPINRemoteImageDownloader.mm:275:76: error: semicolon before method body is ignored [-Werror,-Wsemicolon-before-method-body]
completion:(ASImageDownloaderCompletion)completion;
^
2 errors generated.
Fixes applied to both code, examples and samples in documentation.
* Remove background deallocation helper code
Last use removed in Texture with #1840, now PINS no longer uses it either. Less OOMs is so nice.
* remove methods from docs
* Renames AS_EXTERN and ASViewController
To ASDK_EXTERN and ASDKViewController.
This is to avoid conflicting with AuthenticationServices in
Xcode 12
* Fix up examples and docs
* Add bit about updating ASViewController rename
Our pages are organized in 2 dirs: /docs/ and /development/.
Within a dir, prevPage and nextPage are relative (to the dir) so its path should be appended to their href links (see docs/_layouts/docs.html). The dir is available in the page's permalink var.
Some prevPage and nextPage point to a page in a different dir in which case they must not be relative. Instead they must include the other dir's path and thus their links won't be modified.
Also removed some pages that are no longer needed and fixed some prevPage and nextPage values.
I tested this diff locally and all links worked fine.
* [Dev docs] Node Lifecycle
Here is my draft on a new documentation aims at people interested in learning about technical details of the lifecycle of ASDisplayNode, as well as its interface and loading states. Hopefully it'd be useful for others who want to ramp up and hopefully start contributing to the framework.
Let me know if there are other topics I should cover, or anything I should explain more/dig deeper, or something that is wrong/no longer valid (imposter syndrome much!). Cheers!
* Update node-lifecycle.md
* Address comments
* Getting started on adding threading by example
* writing writing writing
* more info
* More threading
* More more more
* Threading
* self lock
* Some language fixes
* Update docs/_docs/development/threading.md
Co-Authored-By: mikezucc <mikezuccarino@gmail.com>
* fix image references
* Update containers-overview.md
* Update subclassing.md
* Update node-overview.md
ASImageNode, ASNetworkImageNode and ASMultiplexImageNode are in place of UIImageView, not UIImage.
Seeing a warning from GitHub that suggests to update Jekyll because of this vulnerability:
> Jekyll through 3.6.2, 3.7.x through 3.7.3, and 3.8.x through 3.8.3 allows attackers to access arbitrary files by specifying a symlink in the "include" key in the "_config.yml" file.
[CVE-2018-17567](https://nvd.nist.gov/vuln/detail/CVE-2018-17567)
Joe Ferrucci
Sylvain Defresne
Andrew Yates
Joseph Price
Greg Bolsinga
Garrett Moon
Alexander Telegin
vovasty
Hanton Yang
Huy Nguyen
Chetan Garg
Michael Zuccarino
Michael Zuccarino
Andrew Monshizadeh
Wu Zhong
dirtmelon
Dmitry Gridnev
dirtmelon
Sudhanshu
Jay Xie
wxyong
Shihab
Orkhan Huseynov
Huy Nguyen