Scott Goodson
8f914f8430
Fix logic error in handling enablement of beta display range.
2015-12-31 15:38:32 -08:00
Scott Goodson
aee7b3b77a
Remove padding workaround from old CoreText days.
...
This is a vestige from Paper. Discussion: https://github.com/facebook/AsyncDisplayKit/issues/1013
2015-12-31 01:52:08 -08:00
Scott Goodson
df9f433353
Prevent calling unsupported UICollectionViewDelegate methods (supplementary view appearance)
2015-12-31 00:21:20 -08:00
appleguy
50c97b2636
Revert "[ASCellNode] Forward pointInside to node implementation from UITableViewCell."
2015-12-30 23:42:18 -08:00
Scott Goodson
ffcddf36e2
Ensure that ASRangeController immediately removes any deleted nodes from its range state.
2015-12-30 22:42:11 -08:00
appleguy
9b9d8bc9b6
Merge pull request #1016 from facebook/RasterizationUnloadingNodes
...
Ensure that the uncommon __unloadNode codepath does not unintentionally trigger node removal.
2015-12-30 00:23:06 -08:00
appleguy
cc15d74e67
Merge pull request #1008 from yury/bridge-uitableviewcell-pointinside
...
[ASCellNode] Forward pointInside to node implementation from UITableViewCell.
2015-12-29 23:25:48 -08:00
Scott Goodson
df3ce787f7
Ensure that the uncommon __unloadNode codepath does not unintentionally trigger node removal.
2015-12-29 23:11:33 -08:00
Scott Goodson
051f1f6cdd
Use _ASDisplayLayer for both ASTableView and ASCollectionView. zeroContentInsets to fix UIKit.
2015-12-29 22:24:44 -08:00
Scott Goodson
1870208153
[ASPagerNode] Ensure delegate property can be set before the view is loaded and is not overwritten.
2015-12-29 20:46:42 -08:00
yury
83960065ed
Code style fix
2015-12-29 12:10:08 +03:00
yury
382326ea84
Bridge UITableViewCell pointInside to ASNodeCell
...
Allow ASNodeCell to specify pointInside of UITableViewCell.
This is very usefull, if ASNodeCell is presented as bubble aligned to
left or right (like Messages.app) and we need to be able to select row
only if user taps on bubble.
2015-12-28 16:11:50 +03:00
appleguy
4c4f0c8932
Merge pull request #1006 from facebook/ASNetworkImageFileURLs
...
[ASNetworkImageNode] Improve handling of file URLs for images.
2015-12-27 17:11:59 -08:00
appleguy
9264496939
Merge pull request #1005 from facebook/ASDisplayNodeContentsPreservation
...
[ASDisplayNode] Preserve contents after non-range-managed nodes are removed from superviews or windows.
2015-12-27 17:11:49 -08:00
Scott Goodson
b75b72c660
Improve handling of file URLs for ASNetworkImageNode.
...
Details discussed in https://github.com/facebook/AsyncDisplayKit/pull/1003 . This PR supercedes that one.
2015-12-27 16:38:34 -08:00
Scott Goodson
55861b3de1
Update the expectations of the tests now that the clearContents behavior is corrected.
2015-12-27 16:37:33 -08:00
Scott Goodson
93498d8240
[ASDisplayNode] Preserve contents after non-range-managed nodes are removed from superviews or windows.
...
This behavior changed in 1.9.3 and introduced flickering in some cases. Preserving the contents is closer to UIKit behavior.
2015-12-27 15:35:43 -08:00
Scott Goodson
690f90a899
Supplementary nodes must be added to the completed nodes after their measurement completes following individual section reloads.
2015-12-27 15:34:26 -08:00
Scott Goodson
44feece701
Implement node-backing for ASTableView and ASCollectionView, with a strong back-pointer in these cases.
2015-12-26 23:05:34 -08:00
Scott Goodson
4b560a703a
PR #1000 on GitHub! Provide a Beta API to enable the new, high efficiency render-ahead mechanism.
2015-12-26 16:34:44 -08:00
Scott Goodson
a1429ea23b
Add ability to enable new rendering range with a class method in ASDisplayNode+Beta.h
2015-12-26 14:22:24 -08:00
Scott Goodson
7dff6ffa14
Re-enable program flow instrumentation for Coveralls. More null-specifiers.
...
This does cause tests to crash at the end, which unfortunately seems like a known Xcode 7 bug.
2015-12-25 22:13:35 -08:00
Scott Goodson
a2cf2a88e6
Overhaul header files / includes to eliminate circular references that Xcode 7 is angry about.
2015-12-25 19:22:00 -08:00
Scott Goodson
c6fa897dc2
Add nullability annotations to newer APIs that lacked it from the original PR.
2015-12-25 15:35:52 -08:00
Scott Goodson
882d4b336e
Merge branch 'master' into pr/664
2015-12-25 14:32:41 -08:00
Scott Goodson
af74f4a1c2
Fix the AsyncDisplayKit tests under Xcode 7! Workaround for unfixed Apple bug with @dynamic on CALayer.
2015-12-25 14:01:18 -08:00
Scott Goodson
99fbc97bda
Optimizations for ASTextNode handling of renderer allocation and deallocation.
...
Optimizations for ASDisplayNode handling of bridged property "contentMode", especially for layer-backed nodes.
2015-12-25 01:36:32 -08:00
Scott Goodson
4ca97e2f4d
Optimize string handling for CALayer gravity & UIView content mode. Finally fix protocol rename.
2015-12-24 23:13:50 -08:00
Scott Goodson
f902b4bdc7
Replace property declaration with method overrides for -dataSource.
2015-12-24 22:47:54 -08:00
Scott Goodson
a0e4484ef7
Declare ASPagerNode dataSource property as @dynamic so that it can be a different type than ASCollectionNode.
2015-12-24 22:27:52 -08:00
Scott Goodson
7ece41ff64
Delegate definition tweaks for Table and Collection; ensure Table tests run with ARC enabled.
2015-12-24 21:41:12 -08:00
Scott Goodson
c1640c7f59
Implement getter methods for new table / collection delegate / dataSource. Make ASTableView node-backed.
2015-12-24 18:02:52 -08:00
Scott Goodson
27c151095b
[ASPagerNode] New API tweaks. Support setting delegate + dataSource on ASCollectionNode and ASTableNode without triggering view creation.
2015-12-24 17:06:57 -08:00
Scott Goodson
15826b58e4
Remove extra logging for build server debugging.
2015-12-23 22:24:17 -08:00
Scott Goodson
8b3f3351ab
Logging for test failures that are only occurring on build server with iOS 8.1 simulator...
2015-12-23 21:53:42 -08:00
Scott Goodson
ca57059322
New ASDelegateProxy class to unify logic for Table & Collection forwarding. Fix dealloc-during-animation crash.
2015-12-23 20:01:52 -08:00
Scott Goodson
928c440b4c
Several small optimizations, especially to _ASPendingState and other hot paths.
2015-12-23 16:38:33 -08:00
appleguy
dd6ddfc0a2
Merge pull request #976 from facebook/CollectionRefactoring
...
Make ASCollectionView always create an ASCollectionNode. Add visibility and interfaceState change notifications.
2015-12-23 13:09:42 -08:00
appleguy
c968b8dd9e
Merge pull request #978 from aaronschubert0/ASMapNode
...
[ASMapNode] Greatly improve the internal logic of ASMapNode. Also fixes bug #971
2015-12-23 12:55:58 -08:00
Scott Goodson
38d9ceb230
Fix corrupted project file from merge.
2015-12-23 12:52:38 -08:00
Aaron Schubert
e35697d162
Greatly improve the internal logic of ASMapNode. Also fixes bug #971
2015-12-23 10:19:05 +00:00
Scott Goodson
fa4308ba7c
Merge branch 'master' into CollectionRefactoring
2015-12-22 23:38:01 -08:00
Scott Goodson
9944305cfd
Fix tests to avoid newly deprecated ASCollectionView init variant with asyncDataFetching argument.
2015-12-22 23:36:29 -08:00
Scott Goodson
065625f246
Make ASCollectionView always create an ASCollectionNode. Add visibilityDidChange:, interfaceStateDidChange:fromState:
2015-12-22 21:46:46 -08:00
Rajinder Ramgarhia
108ce6d8fc
Set horizontal & vertical alignment default to center. Use ivar to set layout.
2015-12-22 14:23:21 -05:00
Rajinder Ramgarhia
d7b128e19b
ASButtonNode content alignement properties
2015-12-22 14:23:21 -05:00
Adlai Holler
69767d558e
Merge branch 'master' into update-objc
...
Conflicts:
AsyncDisplayKit/Private/ASDisplayNode+FrameworkPrivate.h
2015-12-22 00:28:21 -05:00
appleguy
d7492b331f
Merge pull request #968 from facebook/LockHandlingOnRemoveFromSupernode
...
[ASDisplayNode] Release the lock before setting supernode pointer to nil, in case we are deallocated.
2015-12-21 20:55:54 -08:00
appleguy
af9f8dfea7
Merge pull request #931 from lappp9/cells-with-view-controllers
...
[ASCellNode] Support for wrapping UIViewControllers
2015-12-21 20:55:28 -08:00
Scott Goodson
06688f7061
Release the lock before setting supernode pointer to nil, in case we are deallocated.
2015-12-21 19:57:39 -08:00
Scott Goodson
appleguy
yury
Aaron Schubert
Rajinder Ramgarhia
Adlai Holler