9 Commits
Author SHA1 Message Date
ricky fc0d9a67e5 [ASTextNode2] Fix centered text shorter than container size (#1977) 2021-03-25 12:15:30 -07:00
ricky c3070cfb5c [ASTextNode2] Scale the truncation token via pointScaleFactors (#1974)
If we need to scale text in order to fit in our size, don’t forget to also scale the truncation token!

(disabled carthage so the builds will pass)
2021-03-12 16:18:46 -08:00
ricky 16978e33c3 [ASTextNode2] Fixed truncation for centered text (#1968)
* [ASTextNode2] Fixed truncation for centered text

A lot of this came from the to-be merged changes that YouTube has made to ASTextNode2. My contribution was really just the line adjusting the position of the truncated line when the line is centered.

* added test

* see if this builds without carthage

* trying to skip carthage again

* snapshot changed since we properly expand textBoundingRect for additional characters
2021-03-08 15:22:05 -08:00
Rahul Malik 4caf9511f4 Avoid querying for NSAttributedString attributes on empty string (#1614) 2019-08-13 14:39:27 -07:00
Michael Schneider d7239baaa4 Fix ASTextNode2 supportsLayerBacking (#1545)
`[NSAttributedString enumerateAttribute:inRange:options:usingBlock]` can be called multiple times with a value of nil. The current logic didn't consider this to find out if a links is present within the attributed string.
2019-06-25 15:03:12 -07:00
Eric Scheers d55fd47b88 [ASTextNode] Maintain isAccessibilityElement setting on text nodes when updating text (#1326) 2019-04-09 08:14:36 -07:00
Michael Schneider 5d2524be2c Update test imports (#1279) 2018-12-15 18:45:56 -08:00
Michael Schneider 758afabde3 Fix isTruncated logic in ASTextNode2 (#1259)
* Fix isTruncated logic in ASTextNode2

* Add truncation tests
2018-12-04 13:40:24 -08:00
Adlai Holler d0ba092a77 Convert the codebase to Objective-C++ (#1206)
* Convert the codebase to Objective-C++ throughout. One language is better than two.

* Put it back

* Fix linker

* Point explicitly to updated Weaver to unblock build

* Revert "Point explicitly to updated Weaver to unblock build"

This reverts commit fdc25296e8794d4e6e56c35f5fe6da2be3f71dbc.

* Revert "Fix linker"

This reverts commit 7be25f91519b8497ef42de79f115bcfbdb965c39.

* Add in the frameworks

* no message

* Address spec lint warnings

* Fix tvos build

* Put that back

* Address Michael's review

* Add comment to kick CI
2018-11-02 12:04:14 -07:00