Commit Graph
4532 Commits
Author SHA1 Message Date
Levi McCallum 73ddebed81 Implement UICollectionViewFlowLayout heuristics in a default inspector 2015-10-15 11:40:49 -07:00
Levi McCallum a659ce7bf8 Cleanup setup of default flow layout inspector 2015-10-15 11:40:49 -07:00
Levi McCallum 4c6585d3b3 Fix build errors from bad merge 2015-10-15 11:40:49 -07:00
Levi McCallum d76544420b Add new files to xcodeproj 2015-10-15 11:40:49 -07:00
Levi McCallum 5dee3f62cc Extract number of supplementary sections into the inspector 2015-10-15 11:40:49 -07:00
Levi McCallum da7a2a5d48 Further implement data controller support and layout introspection 2015-10-15 11:40:49 -07:00
Levi McCallum 658b78d552 Use objective-c++ for subclass 2015-10-15 11:40:49 -07:00
Levi McCallum ed1b737ead Define initial supplementary node creation behavior 2015-10-15 11:40:48 -07:00
Levi McCallum e9eadac4ae Stub out ASCollectionDataController subclass 2015-10-15 11:40:48 -07:00
Levi McCallum e492770aed Expose collection view supplementary node data source method 2015-10-15 11:38:48 -07:00
Levi McCallum 0d2332bd82 Allow ASCollectionView to register for supplementary container 2015-10-15 11:38:48 -07:00
Levi McCallum 4e32c075d4 Add launch storyboard to collection view example to fix screen size 2015-10-15 11:38:47 -07:00
Levi McCallum 2956c0cd8a Extract flow layout methods into a separate delegate 2015-10-15 11:38:47 -07:00
Levi McCallum cefbcef831 Documentation updates 2015-10-15 11:38:47 -07:00
appleguy 57badd9e89 Merge pull request #745 from vitalybaev/ASCellNodeSelectedHighlighted
ASCellNode selected/highlighted properties
2015-10-15 11:09:36 -07:00
Vitaly Baev 1a78cd2e66 ASCellNode selected/highlighted properties in ASCollectionView 2015-10-15 20:27:42 +03:00
Vitaly Baev 03542c5436 Bump the bracket down 2015-10-15 20:01:55 +03:00
Vitaly Baev 8557d65104 ASCellNode selected/highlighted properties 2015-10-15 13:25:12 +03:00
appleguy 281a355ffd Merge pull request #743 from facebook/Podfile
Bump podspec version to 1.9 in preparation for release.
2015-10-14 19:28:12 -07:00
Scott Goodson 58a880eaea Bump podspec version to 1.9 in preparation for release. 2015-10-14 19:27:23 -07:00
appleguy 1850238242 Merge pull request #738 from Adlai-Holler/DeprioritizeImageRequests
Demote Photos.framework image request QoS
2015-10-14 12:49:47 -07:00
appleguy d48455672e Merge pull request #740 from Adlai-Holler/ImageNodeErrorHandling
Improve Error Handling in ASMultiplexImageNode
2015-10-14 12:47:56 -07:00
Adlai Holler a53c8a3c34 Improve error handling in ASMultiplexImageNode 2015-10-14 11:00:56 -07:00
Adlai Holler fb0341215f Fix nullability in MultiplexImageNodeDataSource 2015-10-13 21:27:18 -07:00
Adlai Holler b1e60a95e6 Merge branch 'master' into update-objc 2015-10-13 21:26:20 -07:00
Adlai Holler b09d6a3602 Demote Photos.framework image requests to UserInitiated quality of service 2015-10-13 21:22:03 -07:00
Huy Nguyen 210a89e83c Animate subnodes swap in Kitten example. 2015-10-12 22:24:19 +03:00
Huy Nguyen 91f3ba1f49 Don't invalidateCalculatedLayout when ASTextCellNode's text is changed
Because calling -invalidateCalculatedLayout removes the current constrained size and therefore any -setNeedsLayout calls in the future won't have a valid constrained size to proceed.

Instead, cell nodes should be relaid-out using the new APIs introduced in ASTableView and ASCollectionView, which are -relayoutRowAtIndexPath:withRowAnimation and -relayoutItemAtIndexPath, respectively.
2015-10-12 21:48:01 +03:00
Huy Nguyen 12c087d967 Merge branch 'master' into RelayoutCellAPI 2015-10-12 21:31:49 +03:00
appleguy 55c9167e7f Merge pull request #736 from Adlai-Holler/DocumentCellLayoutPasses
Document Cell Layout Passes
2015-10-11 10:30:03 -07:00
Adlai Holler fbd3c77fec Finish that thought 2015-10-11 08:43:43 -07:00
Adlai Holler d964364cd5 Add some documentation in DataController, plus use Fast Enumeration more 2015-10-11 08:39:29 -07:00
appleguy 090a12bdd1 Merge pull request #735 from Adlai-Holler/MeasureCellNodesOnMain
[ASDataController] Allow reusing ASCellNodes by measuring on main thread for .nodeLoaded = YES
2015-10-10 20:20:36 -07:00
Adlai Holler 595891629c Remove pointless assertion 2015-10-10 10:33:56 -07:00
Adlai Holler 0c361894ac Remove comment 2015-10-09 21:17:11 -07:00
Adlai Holler 1e232561f4 Whitespace 2015-10-09 21:16:28 -07:00
Adlai Holler 0eb3490363 Finish removing needsMeasure 2015-10-09 21:15:32 -07:00
Adlai Holler 7f42b37dec Remove needsMeasure 2015-10-09 21:13:00 -07:00
Adlai Holler 0848aac186 Revert prior change 2015-10-09 20:28:42 -07:00
Adlai Holler d8e99e00bd Remove public needsMeasure 2015-10-09 20:27:38 -07:00
Adlai Holler fdb11275db Put back the frame-setting behavior when measuring cell nodes 2015-10-09 20:23:54 -07:00
Adlai Holler 06b7897bc1 Finish measuring on main thread when possible 2015-10-09 20:06:59 -07:00
Adlai Holler 93cdc0f2f5 Don't set cell node frames during measurement 2015-10-09 19:55:14 -07:00
Adlai Holler 223e9ff504 Merge branch 'DontSetCellNodeFramesDuringMeasure' into MeasureCellNodesOnMain
Conflicts:
	AsyncDisplayKit/Details/ASDataController.mm
2015-10-09 19:53:46 -07:00
Adlai Holler e716ccb580 Don't set cell node frames during measure, set them just before returning the cell size to UITableView/UICollectionView 2015-10-09 19:51:12 -07:00
Adlai Holler e92a6ce9e3 Initial work on measuring loaded cell nodes on the main thread 2015-10-09 19:37:36 -07:00
appleguy ca5780f6f4 Merge pull request #714 from Adlai-Holler/WorkaroundPhotosDeadlock
Workaround Photos.framework deadlock by locking
2015-10-07 17:20:52 -07:00
appleguy 5eb5e431c4 Merge pull request #726 from facebook/RestoreTableAndCollectionDelegates
Revert "Properly support operating with nil asyncDelegate for Table & Collection."
2015-10-07 14:50:00 -07:00
Scott Goodson a8435b494c Revert "Properly support operating with nil asyncDelegate for Table & Collection."
This reverts commit 77745c55b0.

Bug was found / reported in https://github.com/facebook/AsyncDisplayKit/issues/721

Attempting resolution here, but need to fix for current clients now:
https://github.com/facebook/AsyncDisplayKit/pull/724
2015-10-07 14:48:37 -07:00
appleguy ba951d139c Merge pull request #725 from nguyenhuy/CodeStyleInASDisplayNode
Clean up #723 - indentation and thread affinity / lock enforcement
2015-10-07 13:35:06 -07:00