Commit Graph
4957 Commits
Author SHA1 Message Date
Dasmer Singh 7fedfdd757 [README.md] Add Coveralls badge 2015-04-22 12:23:11 -04:00
Dasmer Singh 9006f7c356 Ignore .gcov files in git 2015-04-22 12:20:37 -04:00
Dasmer Singh f8c02147fb [.slather.yml] Add newline to end of file 2015-04-21 17:02:04 -04:00
Dasmer Singh 9cf056f6d5 Set GENERATE_TEST_COVERAGE_FILES & INSTRUMENT_PROGRAM_FLOW_ARCS to YES in Life Without CocoaPods.xcodeproj 2015-04-21 16:39:21 -04:00
Dasmer Singh de04da843f Update Podfile.lock 2015-04-21 16:38:39 -04:00
dasmer 1c8b425a44 Generate coverage stats using slather/Coveralls 2015-04-20 23:48:49 -04:00
Tobias Klonk 2a29f81b3a ASTextNode expose exclusion paths
expose NSTextContainer's exclusionPaths property on ASTextNode to be able to exclude view areas from typesetting.

This implements #394
2015-04-20 10:21:01 +02:00
Ethan Nagel 68e2e068c3 Bug Fix - ASTableVie sometimes fails to render cell contents when scrolling programatically. Root cause is because we assume UITableView's indexPathsForVisibleRows return the new item to be displayed after tableView:willDisplayCell:forRowAtIndexPath: is called. This is not always true, especially when we are scrolling programmatically. Fix is to track this "pending" visible index path and return it along with the UITableView's indexPathsForVisibleRows in rangeControllerVisibleNodeIndexPaths:. 2015-04-17 16:09:44 -07:00
Onha Choe 74d2433d60 change ASMutableAttributedStringBuilderTests so that it is safe against different MAX macro
when MAX macro is defined in such a way in "sys/params.h", this test will become flaky,
fix so that it doesn't happen
2015-04-14 13:57:54 -07:00
Nadine Salter 1316389f10 New patent grant.
https://code.facebook.com/posts/1639473982937255/updating-our-open-source-patent-grant/
2015-04-10 12:15:09 -07:00
Ryan Nystrom 24bb0926bc Merge pull request #421 from facebook/xcode-6-3
Xcode 6.3 support
2015-04-08 16:44:50 -07:00
Ryan Nystrom 7eed85a7f0 Merge pull request #418 from spicyj/kittens
Add new kittens after last row
2015-04-08 16:36:33 -07:00
Ryan Nystrom 300724388b Merge pull request #420 from facebook/swolchok-patch-1
s/assign/strong/ on an object-typed ivar
2015-04-08 16:36:02 -07:00
Ryan Nystrom 527a6228a9 Xcode 6.3 support 2015-04-08 16:35:10 -07:00
Ryan Nystrom 6d8d7aeece Passing the torch 2015-04-07 16:09:17 -07:00
Scott Wolchok 15dfd25aff s/assign/strong/ on an object-typed ivar
It caused a zombie in tests.
2015-04-06 14:47:42 -07:00
Ryan Nystrom 01e7d09a26 Merge pull request #412 from mikee179/master
Adds property for long press touch cancellation
2015-04-03 14:12:32 -07:00
Ben Alpert a8c484119b Add new kittens after last row
New kittens were being added before the last kitten instead of after it
because we weren't taking into account the first (header) row.
2015-04-03 12:40:53 -07:00
Michael Kuntscher a92dd3189b Adds property for long press touch cancellation 2015-04-01 16:38:29 -07:00
Ian Cloutier 8699ab8ed7 Fix handling of pending nodes and placeholder layer 2015-03-30 18:59:40 -04:00
Ethan Nagel abd725d8c1 update documentation for reloadData:completion 2015-03-27 18:14:05 -07:00
Ryan Nystrom 6ae17e55bc Merge pull request #403 from facebook/touch-forwarding
Forward touches to super instead of the superview
2015-03-26 21:11:53 -07:00
Ryan Nystrom b6715b5cf9 Forward touches to super instead of the superview
fixes #402
2015-03-26 21:11:13 -07:00
Nadine Salter d3a8f44068 Merge pull request #404 from facebook/textnode-tapping
Allow double-tap gestures on text nodes
2015-03-26 18:01:36 -07:00
Ryan Nystrom 29a360d562 Allow double-tap gestures on text nodes 2015-03-26 17:22:22 -07:00
Ethan Nagel 3f509dbd2f add completion block to reloadData methods 2015-03-26 16:32:44 -07:00
Nadine Salter dd10fda42c Fix ASSnapshotTestCase #import. 2015-03-23 16:39:21 -07:00
Nadine Salter eeb96e662c Merge pull request #396 from facebook/ASSnapshotTestCase
[tests] ASSnapshotTestCase.
2015-03-23 16:08:32 -07:00
Nadine Salter ad3f3b5fdc Disable flakey test. 2015-03-23 15:59:29 -07:00
Ryan Nystrom 50eccabac8 Merge pull request #389 from facebook/issue-380
Fix ASImageNode -measure: / -setImage: deadlock.
2015-03-23 14:48:12 -07:00
Nadine Salter ecd6872814 [tests] AsyncDisplayKitTestHost. 2015-03-23 14:06:38 -07:00
Nadine Salter b869d025ff [tests] ASSnapshotTestCase. 2015-03-23 14:06:38 -07:00
Nadine Salter 13e1c65d03 Fix ASImageNode -measure: / -setImage: deadlock.
Speculative fix for #380.  Calling `-[ASImageNode setImage:]` on a
background queue will take the image lock, then trampoline to the main
queue to invalidate calculatedSize and set needsDisplay without
releasing the lock.  Any other method call that takes the image lock on
the main queue can block on the trampoline completing -- deadlock.

Note that the trampoline is itself a clowny workaround for thread
affinity (#134) and should be removed.  With this patch applied,
ASImageNode's `-setImage:` and `-calculateSizeThatFits:` can still race:

1.  -setImage changes _image, then trampolines to main
2.  -calculateSizeThatFits measures _image
3.  trampoline completes, invalidates calculated size
4.  ???
5.  ~~profit!~~ 💥
2015-03-23 14:05:15 -07:00
Ryan Nystrom 814aff5a6d Merge pull request #388 from facebook/issue-383
Remove ASImageNode's tint property.
2015-03-23 13:59:20 -07:00
Ryan Nystrom 66624fa4e6 Merge pull request #387 from facebook/issue-89
Fix ASTextNode positioning for non-left alignment, part deux.
2015-03-23 13:58:30 -07:00
Nadine Salter 4ca527c24f Merge pull request #393 from facebook/life-without-cocoapods
[travis] Add "Life Without CocoaPods" smoke test.
2015-03-20 16:50:44 -07:00
Nadine Salter ad73c86c64 [travis] Life Without CocoaPods. 2015-03-20 16:44:01 -07:00
Nadine Salter dd0ad80889 Add smoke-tests/ and Life Without CocoaPods.
See the README.md files for details.
2015-03-20 16:44:01 -07:00
Nadine Salter 4ae20aa11b Merge pull request #391 from facebook/new-build-script
[travis] New build script.
2015-03-20 16:07:32 -07:00
Nadine Salter 65fe805ecb [travis] Disable Travis CI automatic pod install. 2015-03-20 15:55:29 -07:00
Nadine Salter a9d555d225 [travis] New build script.
In addition to building & testing AsyncDisplayKit, this new build script
can ensure that all example projects still compile.  This will prevent
breaking API changes from landing without updating sample projects that
use them.  It's also extensible, so we can add additional integration
tests in future (e.g., non-CocoaPods framework integration).
2015-03-20 15:45:33 -07:00
Nadine Salter 9eff356a61 [travis] Shared schemes for all example projects. 2015-03-20 15:36:31 -07:00
Nadine Salter 8164d63d29 Fix ASTextNode positioning for non-left alignment, part deux.
Apply the fix from #329 to `-setFrame:`.  Fixes #89.
2015-03-20 12:45:06 -07:00
Nadine Salter 7344cb98bb Remove ASImageNode's tint property.
ASImageNodeTint is inflexible (your options are "no tint" and "use
`[UIColor grayColor]`") and needlessly complicates the ASImageNode
implementation.  Use ASImageNodeTintColorModificationBlock() instead.
Closes #383.
2015-03-20 12:37:27 -07:00
Nadine Salter 1dc4b42dce Merge pull request #382 from facebook/longer-async-wait
Longer timeout for async tests
2015-03-17 12:01:39 -07:00
Ryan Nystrom 7117548bc1 Longer timeout for async tests 2015-03-17 11:44:10 -07:00
Nadine Salter 1a39f412d5 Merge pull request #381 from facebook/suspended-range
Enable nodes entering the visible range to display
2015-03-17 11:20:18 -07:00
Ryan Nystrom cd3ad1c86f Enable nodes entering the visible range to display 2015-03-17 10:52:32 -07:00
Ryan Nystrom fa2f36004b Merge pull request #375 from facebook/issue-374
Stretchy or mod block images
2015-03-15 15:59:38 -07:00
Ryan Nystrom 59c9fc8819 Stretchy or mod block images
fixes #374
2015-03-12 14:41:11 -07:00