Commit Graph
4957 Commits
Author SHA1 Message Date
Scott Goodson 051f1f6cdd Use _ASDisplayLayer for both ASTableView and ASCollectionView. zeroContentInsets to fix UIKit. 2015-12-29 22:24:44 -08:00
appleguy b1b9ad23d6 Merge pull request #1014 from facebook/PagerProxy
[ASPagerNode] Ensure delegate property can be set before the view is loaded.
2015-12-29 21:18:21 -08:00
Scott Goodson 1870208153 [ASPagerNode] Ensure delegate property can be set before the view is loaded and is not overwritten. 2015-12-29 20:46:42 -08:00
yury 83960065ed Code style fix 2015-12-29 12:10:08 +03:00
appleguy 0dc017918d Merge pull request #1012 from NatashaTheRobot/master
[Swift] Add Readme code snippet with example usage of an ASDisplayNode.
2015-12-28 23:06:10 -08:00
Natasha Murashev 90af0d393b Update README.md 2015-12-29 16:55:48 +13:00
Natasha Murashev 2ff683bc0b Added Swift example to README 2015-12-29 16:54:20 +13:00
yury 382326ea84 Bridge UITableViewCell pointInside to ASNodeCell
Allow ASNodeCell to specify pointInside of UITableViewCell.
This is very usefull, if ASNodeCell is presented as bubble aligned to
left or right (like Messages.app) and we need to be able to select row
only if user taps on bubble.
2015-12-28 16:11:50 +03:00
appleguy 4c4f0c8932 Merge pull request #1006 from facebook/ASNetworkImageFileURLs
[ASNetworkImageNode] Improve handling of file URLs for images.
2015-12-27 17:11:59 -08:00
appleguy 9264496939 Merge pull request #1005 from facebook/ASDisplayNodeContentsPreservation
[ASDisplayNode] Preserve contents after non-range-managed nodes are removed from superviews or windows.
2015-12-27 17:11:49 -08:00
Scott Goodson b75b72c660 Improve handling of file URLs for ASNetworkImageNode.
Details discussed in https://github.com/facebook/AsyncDisplayKit/pull/1003.  This PR supercedes that one.
2015-12-27 16:38:34 -08:00
Scott Goodson 55861b3de1 Update the expectations of the tests now that the clearContents behavior is corrected. 2015-12-27 16:37:33 -08:00
appleguy e56315dba9 Merge pull request #1004 from facebook/SupplementaryNodeSectionReloading
Supplementary nodes must be added to the completed nodes after their measurement completes.
2015-12-27 16:03:14 -08:00
Scott Goodson 93498d8240 [ASDisplayNode] Preserve contents after non-range-managed nodes are removed from superviews or windows.
This behavior changed in 1.9.3 and introduced flickering in some cases.  Preserving the contents is closer to UIKit behavior.
2015-12-27 15:35:43 -08:00
Scott Goodson 690f90a899 Supplementary nodes must be added to the completed nodes after their measurement completes following individual section reloads. 2015-12-27 15:34:26 -08:00
appleguy f87b915162 Merge pull request #1002 from facebook/TableCollectionNodes
[ASTableView, ASCollectionView] Implement node-backing for ASTableView and ASCollectionView, with a strong back-pointer in these cases.
2015-12-26 23:29:31 -08:00
Scott Goodson 44feece701 Implement node-backing for ASTableView and ASCollectionView, with a strong back-pointer in these cases. 2015-12-26 23:05:34 -08:00
appleguy 02ab9e230f Merge pull request #1000 from facebook/EnsureDisplay
PR #1000 on GitHub!  Provide a Beta API to enable the new, high efficiency render-ahead mechanism.
2015-12-26 22:59:59 -08:00
Scott Goodson 4b560a703a PR #1000 on GitHub! Provide a Beta API to enable the new, high efficiency render-ahead mechanism. 2015-12-26 16:34:44 -08:00
appleguy e5988138e9 Merge pull request #999 from facebook/BetaSwitchRangeController
Add ability to enable new rendering range with a class method in ASDisplayNode+Beta.h
2015-12-26 14:24:26 -08:00
Scott Goodson a1429ea23b Add ability to enable new rendering range with a class method in ASDisplayNode+Beta.h 2015-12-26 14:22:24 -08:00
appleguy 830659b561 Merge pull request #998 from facebook/TestCoverageXcode7
Disable "intrument program flow" to fix error spew after running tests.  Enable Xcode 7 UI for code coverage.
2015-12-26 14:12:11 -08:00
Scott Goodson ffeb514802 Disable "intrument program flow" to fix error spew after running tests. Enable Xcode 7 UI for code coverage. 2015-12-26 13:35:48 -08:00
Luke Parham 5fbf39644b merged upstream 2015-12-26 01:33:34 -06:00
appleguy b50d7427f8 Merge pull request #996 from facebook/ReenableCodeCoverage
Re-enable program flow instrumentation for Coveralls.  More null-specifiers.
2015-12-25 22:41:51 -08:00
Scott Goodson 7dff6ffa14 Re-enable program flow instrumentation for Coveralls. More null-specifiers.
This does cause tests to crash at the end, which unfortunately seems like a known Xcode 7 bug.
2015-12-25 22:13:35 -08:00
appleguy 88bfd3e460 Merge pull request #995 from facebook/pr/664
[Refactoring] Adopt Objective-C Nullability, Lightweight Generics Annotations
2015-12-25 19:57:01 -08:00
Scott Goodson 7b0c82b0ac Update to use iOS 9.2 simulator for testing, as Xcode 7.2 Travis apparently lacks 9.0. 2015-12-25 19:34:45 -08:00
Scott Goodson a2cf2a88e6 Overhaul header files / includes to eliminate circular references that Xcode 7 is angry about. 2015-12-25 19:22:00 -08:00
Scott Goodson 89f9fc551f Update Travis build server to use Xcode 7.2. 2015-12-25 15:59:46 -08:00
Scott Goodson be3371ea69 Merge branch 'master' into pr/664 2015-12-25 15:57:11 -08:00
appleguy 406bcfaa0d Merge pull request #671 from Adlai-Holler/xcode-7
Enable Xcode 7 by default for Travis build server.
2015-12-25 15:55:49 -08:00
Scott Goodson c6fa897dc2 Add nullability annotations to newer APIs that lacked it from the original PR. 2015-12-25 15:35:52 -08:00
Scott Goodson 882d4b336e Merge branch 'master' into pr/664 2015-12-25 14:32:41 -08:00
appleguy e1add1cdce Merge pull request #994 from facebook/FixXcode7Tests
[Tests] Fix the AsyncDisplayKit tests under Xcode 7!  Workaround for unfixed Apple bug with @dynamic on CALayer.
2015-12-25 14:27:00 -08:00
Scott Goodson af74f4a1c2 Fix the AsyncDisplayKit tests under Xcode 7! Workaround for unfixed Apple bug with @dynamic on CALayer. 2015-12-25 14:01:18 -08:00
appleguy d6289d5187 Merge pull request #993 from facebook/OptimizingTextAndBridge
Optimizations for ASTextNode renderer; Optimizations for ASDisplayNode Bridge.
2015-12-25 01:46:34 -08:00
Scott Goodson 99fbc97bda Optimizations for ASTextNode handling of renderer allocation and deallocation.
Optimizations for ASDisplayNode handling of bridged property "contentMode", especially for layer-backed nodes.
2015-12-25 01:36:32 -08:00
appleguy 1ec1957b44 Merge pull request #990 from facebook/ASPagerNodeAndCollectionAndTable
[ASPagerNode] New API tweaks.  Support setting delegate + dataSource on ASCollectionNode and ASTableNode without triggering view creation.
2015-12-24 23:53:11 -08:00
Scott Goodson 4ca97e2f4d Optimize string handling for CALayer gravity & UIView content mode. Finally fix protocol rename. 2015-12-24 23:13:50 -08:00
Scott Goodson f902b4bdc7 Replace property declaration with method overrides for -dataSource. 2015-12-24 22:47:54 -08:00
Scott Goodson a0e4484ef7 Declare ASPagerNode dataSource property as @dynamic so that it can be a different type than ASCollectionNode. 2015-12-24 22:27:52 -08:00
Scott Goodson 7ece41ff64 Delegate definition tweaks for Table and Collection; ensure Table tests run with ARC enabled. 2015-12-24 21:41:12 -08:00
Scott Goodson c1640c7f59 Implement getter methods for new table / collection delegate / dataSource. Make ASTableView node-backed. 2015-12-24 18:02:52 -08:00
Scott Goodson 27c151095b [ASPagerNode] New API tweaks. Support setting delegate + dataSource on ASCollectionNode and ASTableNode without triggering view creation. 2015-12-24 17:06:57 -08:00
appleguy 985e47a7b7 Merge pull request #987 from facebook/CollectionAndTableProxies
New ASDelegateProxy class to unify logic for Table & Collection forwarding.  Fix dealloc-during-animation crash.
2015-12-23 22:53:33 -08:00
Scott Goodson 15826b58e4 Remove extra logging for build server debugging. 2015-12-23 22:24:17 -08:00
Scott Goodson 8b3f3351ab Logging for test failures that are only occurring on build server with iOS 8.1 simulator... 2015-12-23 21:53:42 -08:00
Scott Goodson ca57059322 New ASDelegateProxy class to unify logic for Table & Collection forwarding. Fix dealloc-during-animation crash. 2015-12-23 20:01:52 -08:00
Scott Goodson 928c440b4c Several small optimizations, especially to _ASPendingState and other hot paths. 2015-12-23 16:38:33 -08:00