Commit Graph
5092 Commits
Author SHA1 Message Date
appleguy fed1fdb96c Merge pull request #1603 from maicki/ASPagerNodeRotationSupport
[ASPagerNode] Add ASPagerNode rotation support
2016-06-09 22:38:55 -07:00
Michael Schneider 389fd4b15d Further improvements for ASPagerNode rotation 2016-06-09 20:11:21 -07:00
Michael Schneider 3e8ea64a1b Update to latest state 2016-06-09 15:46:08 -07:00
Michael Schneider 1f55ef8945 Improve PagerNode sample project 2016-06-09 15:46:08 -07:00
Michael Schneider 1c6686e5d6 Improve rotation support for ASPagerNode 2016-06-09 15:46:08 -07:00
Eric Jensen fdc57410ee Move the default animated image runloop mode to a constant, and fallback to the constant if the runloop mode is set to nil 2016-06-09 10:53:37 -07:00
Eric Jensen 91e6df0af9 Add a way to check if data is in a format supported by a class implementing ASAnimatedImageProtocol 2016-06-09 10:36:18 -07:00
Eric Jensen 1fb3ffc6f8 Replace usage of imageWithData: with imageWithContentsOfFile: 2016-06-09 10:01:59 -07:00
appleguy 1847b5e947 Merge pull request #1727 from ejensen/video-poster-fix
[ASVideoNode] Prevent setting old poster image if the asset was set to nil
2016-06-08 22:41:30 -07:00
appleguy 6632b4ec5f Merge pull request #1722 from rcancro/layoutSpecTraitObject
[ASLayoutSpec] Remove cached ASTraitCollection
2016-06-08 22:29:47 -07:00
appleguy 2cf9e62df6 Merge pull request #1692 from maicki/ASLayoutValidation
[ASLayout] Add basic infrastructure for layout validation
2016-06-08 19:32:20 -07:00
appleguy bbffc86040 Merge pull request #1729 from levi/reverseFlatten
[Tests] Update FBSnapshotTestCase and generate @3x images
2016-06-08 19:21:18 -07:00
Michael Schneider 434102f988 Address comments from review
- Remove public NSMutableArray header for validators
- Add ASDISPLAYNODE_EXTERN_C_BEGIN/END
- Rename isRootLayout to isFinalLayoutable
2016-06-08 18:42:32 -07:00
Michael Schneider 9ff7223b77 Move validation code to ASLayoutValidation and add validation flag 2016-06-08 16:59:46 -07:00
Michael Schneider f9e13545bf Improve layout validation
- Asserts if layout is invalid
- Add better help messages if layout is invalid
2016-06-08 16:39:03 -07:00
Levi McCallum ca2fb0bc74 Update FBSnapshotTestCase and generate @3x images 2016-06-08 13:33:03 -07:00
Eric Jensen 5cc25686ff Correct documentation comment 2016-06-08 12:37:46 -07:00
Eric Jensen 001d3ea624 Use a strong reference to the current asset in order to prevent setting a placeholder image if the asset is set to nil while the placeholder image is generating 2016-06-08 12:37:32 -07:00
Eric Jensen 7de82b0b5b Support loading animated images from the local filesystem 2016-06-08 11:34:56 -07:00
Eric Jensen 370e5f1006 Allow configuration of ASImageNode's animation runloop 2016-06-08 10:38:43 -07:00
Michael Schneider 197950f39b Add basic infrastructure for layout validation 2016-06-08 10:35:28 -07:00
ricky 3c34d51a19 [ASLayoutSpec] Remove cached ASTraitCollection 2016-06-07 10:50:42 -07:00
appleguy cb67671f1d Merge pull request #1719 from garrettmoon/fixParentManagesVisibilityDepth
Reset the parentManagesVisibilityDepth flag so it's checked again
2016-06-06 23:13:18 -07:00
Scott Goodson 1e3e5a56b9 [Cocoapods] Use 1.9.80 instead... 1.9.80 2016-06-06 14:56:40 -07:00
Garrett Moon 1e51569538 Reset the parentManagesVisibilityDepth flag so it's checked again 2016-06-06 14:38:03 -07:00
appleguy e0abb706b7 Merge pull request #1718 from levi/fixFix
Fix boolean logic that prevents layout
2016-06-06 14:00:36 -07:00
Levi McCallum e5d7d29eb6 Fix boolean logic that prevents layout 2016-06-06 13:57:17 -07:00
appleguy 1b07cab87b Merge pull request #1717 from levi/revertAutomaticMeasure
Revert "Merge pull request #1673 from maicki/AddAutomaticMeasureBeforeLayout"
2016-06-06 13:23:22 -07:00
Levi McCallum 20523821f9 Revert "Merge pull request #1673 from maicki/AddAutomaticMeasureBeforeLayout"
This reverts commit 2e384a32e1, reversing
changes made to b8618d3151.
2016-06-06 13:12:10 -07:00
appleguy dfaf3b9495 Merge pull request #1716 from garrettmoon/removeRequirementForPINRemoteImage
Missed #def ing out the header I guess?
2016-06-06 12:53:34 -07:00
Garrett Moon 7358fa9182 Missed #def ing out the header I guess? 2016-06-06 12:33:50 -07:00
Scott Goodson 4890777dcb [Cocoapods] Fix podspec for 1.9.8 to ensure the dependency on PINRemoteImage is fully defined. 2016-06-06 11:20:35 -07:00
Scott Goodson 58d7a18dd4 [Build] Tag __unused for variable only needed by an assertion. 1.9.8 2016-06-06 00:45:23 -07:00
Luke Parham fc5467b110 fixed typo and added backwards compatibility for 'visibilityDidChange' 2016-06-06 02:02:23 -05:00
Scott Goodson 252508e33c [Cocoapods] Update podspec for the 1.9.8 release. 2016-06-05 23:59:55 -07:00
Luke Parham e510120031 changed '-visibilityDidChange:' to '-visiblieStateDidChange:' to match the others 2016-06-06 00:56:21 -05:00
Luke Parham d47059dffe updated load and display did change methods 2016-06-06 00:56:21 -05:00
Luke Parham 8526171b30 reenabled new tests 2016-06-06 00:56:21 -05:00
Luke Parham 4b2aa1fc59 added comments to header and cleaned up interface state did change 2016-06-06 00:56:21 -05:00
Luke Parham 449a2cc517 added callbacks for entering and exiting fetch data and display ranges 2016-06-06 00:56:21 -05:00
appleguy 4c1f88e51a Merge pull request #1629 from erichoracek/recalculate-supplementaries-on-item-changes
[ASCollectionView] Repopulate supplementary views on item-level changes
2016-06-05 22:36:54 -07:00
Eric Horacek 70fbbe00a3 Whitespace 2016-06-05 21:55:57 -07:00
Eric Horacek ed9fcdc2d7 Rebase 2016-06-05 21:53:04 -07:00
Eric Horacek 30dba283e2 Remove _pendingContexts dictionary mutation during enumeration 2016-06-05 21:43:05 -07:00
Eric Horacek dc7f67c478 Populate more aggresively 2016-06-05 21:38:08 -07:00
Eric Horacek d89504e345 Fix index path arithmetic error 2016-06-05 21:38:08 -07:00
Eric Horacek 8f3e511b22 Fix warning 2016-06-05 21:38:08 -07:00
Eric Horacek fc5eef3269 Repopulate supplementary views on item-level changes
Currently within `ASCollectionView`, there is an assumption that there will always be a static number of supplementary views per section—even when additional items are added or removed from that section. This is evidenced by the fact that when you invoke -[ASCollectionView insertItemsAtIndexPaths:], the data source method -[ASCollectionDataSource collectionView:nodeForSupplementaryElementOfKind:atIndexPath:] is not invoked, preventing consumers from specifying a new number of supplementary nodes for the new set of items.

With this change, the set of supplementary nodes for a section is now recalculated not only on section-level mutations, but also on item-level mutations as well. This adds item-level counterparts to the section-level `-prepareFor...` subclassing hooks in `ASDataController+Subclasses.h` to make this possible.

This should fix #1278 and #1322

This has been tested in my project and seen to fix the assertion. Open to suggestions on how to test in a more universal way.
2016-06-05 21:38:08 -07:00
appleguy 3725e53fe9 Merge pull request #1687 from levi/constrainedSize
[ASDisplayNode] Move constrained size to ASLayout
2016-06-05 18:26:03 -07:00
Hannah Troisi 52d58992da [ASVideoNode] Change superclass to ASNetworkImageNode so that it can be its own placeholder (#1710)
* [ASVideoNode] Change superclass to ASNetworkImageNode so that ASVideoNode can be its own placeholder
- remove _placeholderImageNode property of ASVideoNode (use self.image now instead)
- move layoutSpecThatFits: code to calculateSizeThatFits: & layout: methods as ASImageNode uses calculateSizeThatFits:

* [ASVideoNode] Tweaks to the definition of the delegate protocols to integrate with ASNetworkImageNode (superclass)
2016-06-05 18:18:52 -07:00