4973 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
ricky cancro	b58e8344c0	Add expectedSize to ASNetworkImageNode ... ASNetworkImageNode defers to ASImageNode to return its calculatedSize. ASImageNode returns the size of its image. There is a good chance that ASNetworkImageNode hasn't downloaded its image yet when calculatedSize is called, so it returns a size of CGSizeZero. On top of that, it is possible that the size of the image is not actually the size that we wish to display in our node. I've added an "expectedImageSize" property that can be used to determine the calculatedSize of an ASNetworkImageNode.	2015-08-09 16:34:44 -07:00
appleguy	d401b0e5f6	Merge pull request #593 from shannonma/merge_fork ... Fixes for ASTextNode test, setNeedsDisplay and font loading failures	2015-08-08 18:55:00 -07:00
appleguy	368d3af21a	Merge pull request #595 from nguyenhuy/external_relayout ... Support relayout of cells in ASTableView and ASCollectionView after their size changes. This allows rotation and cell editing modes to work correctly, as is now supported in the Kittens demo app.	2015-08-08 18:27:18 -07:00
Huy Nguyen	219b659b38	- Automatically relayout cells when editing mode is used. ... - Add editing mode to Kitten sample.	2015-08-09 00:45:54 +03:00
Huy Nguyen	e657bedd40	Automatically relayout cells after orientation changed.	2015-08-09 00:36:58 +03:00
Shannon Ma	6275219f79	Revert Cocoapod version update	2015-08-07 09:26:53 -07:00
appleguy	8da9ddd884	Merge pull request #598 from nguyenhuy/wrong_implementsInsetSection ... Fix _implementsInsetSection of ASCollectionView being check before the asyncDelegate is set	2015-08-05 16:45:56 -07:00
Huy Nguyen	60ed2bca47	Fix _implementsInsetSection of ASCollectionView being check before the asyncDelegate is set.	2015-08-05 17:33:56 +03:00
appleguy	f97af9cb26	Merge pull request #594 from nguyenhuy/relayout_same_constrained_size ... Support internal relayout	2015-08-04 12:27:30 -07:00
appleguy	936bc2534d	Merge pull request #596 from levi/master ... Add support for sectionInset in ASCollectionView in property and delegate form	2015-08-04 12:06:04 -07:00
ricky cancro	c03ed9a8f4	ASDisplayNode returns requestedLayoutSize by default	2015-08-04 08:12:32 -07:00
appleguy	a8ad21e850	Merge pull request #597 from marmelroy/issue-591 ... Fixing build issues for framework target - Issue #591	2015-08-03 22:32:44 -07:00
rcancro	496cc43337	Updates to expectedImageSize ... * renamed property to requestedLayoutSize * moved property to ASDisplayNode	2015-08-03 22:09:50 -07:00
Roy Marmelstein	26202865ac	Adding files that were missing from the framework target	2015-08-04 00:07:30 +02:00
Roy Marmelstein	76e5f794da	Fixing framework target build issues - missing info plist and headers	2015-08-03 23:47:53 +02:00
Levi McCallum	5eb75d6bc7	Add support for sectionInset in ASCollectionView in property and delegate form	2015-08-03 14:36:29 -07:00
Huy Nguyen	77b586a7e6	Improvements on internal relayout.	2015-08-03 06:25:23 +03:00
Huy Nguyen	0acfea234f	Update comments of setNeedsLayout and setNeedsDisplay of ASDisplayNode.	2015-08-03 02:30:08 +03:00
Huy Nguyen	56768a837a	- Support internal relayout, that is a relayout caused by internal layout changes, like subnodes re-arrangement and/or subnodes' size change. The constrained size applied to root node is unchanged. ... - Update Kittens example to show how internal relayout is done.	2015-08-02 17:18:45 +03:00
Shannon Ma	d5de2a22fd	Text node to gracefully fail upon font failure	2015-07-31 12:24:04 -07:00
Shannon Ma	15133fdbf7	setNeedsDisplay must be called on main	2015-07-31 12:11:19 -07:00
Shannon Ma	f7a4ca45db	Fix ASTextNodeWordKernerTests for Xcode 7/iOS 9	2015-07-31 11:31:10 -07:00
appleguy	16ed66c3a1	Merge pull request #550 from marmelroy/issue-549 ... Access to underlying UITextView for more configuration options.	2015-07-30 22:04:30 -07:00
ricky cancro	eae76d26b7	Add expectedSize to ASNetworkImageNode ... ASNetworkImageNode defers to ASImageNode to return its calculatedSize. ASImageNode returns the size of its image. There is a good chance that ASNetworkImageNode hasn't downloaded its image yet when calculatedSize is called, so it returns a size of CGSizeZero. On top of that, it is possible that the size of the image is not actually the size that we wish to display in our node. I've added an "expectedImageSize" property that can be used to determine the calculatedSize of an ASNetworkImageNode.	2015-07-30 16:50:11 -07:00
appleguy	e76fa2794f	Merge pull request #589 from connor/returnKeyType ... Add support for configuring `returnKeyType` on ASEditableTextNode.	2015-07-30 15:23:48 -07:00
Connor Montgomery	ca5e9e7dc3	Add support for configuring on ASEditableTextNode.	2015-07-30 15:19:00 -04:00
appleguy	5482213e2e	Merge pull request #584 from facebook/AssertionsAndTesting ... Implement warning assertion for supplementary views in ASCollectionView.	2015-07-25 21:47:16 -07:00
Scott Goodson	46bbe479ae	Implement warning assertion for supplementary views in ASCollectionView. ... Make sure ASTableViewStressTest passes. It was sometimes testing a scenario UITableView itself doesn't support.	2015-07-25 21:25:40 -07:00
appleguy	f3b8216a10	Merge pull request #582 from eanagel/fix-travis ... Attempt to fix travis by specifying cocoapods 0.37.2 explicitly	2015-07-25 09:36:58 -07:00
Ethan Nagel	9b427576f2	Attempt to fix travis by specifying cocoapods 0.37.2 explicitly	2015-07-24 23:22:57 -07:00
Ethan Nagel	6e13c3ebab	Attempt to fix travis by specifying cocoapods 0.37.2 explicitly	2015-07-24 23:05:14 -07:00
Roy Marmelstein	6b38000941	A simpler, cleaner implementation	2015-07-22 11:05:27 +02:00
appleguy	5dae5dffb6	Merge pull request #578 from eanagel/update-podfile-lock ... Update Podfile.lock to match earlier changes to Podfile.	2015-07-21 18:56:49 -07:00
Ethan Nagel	451beda238	Update Podfile.lock to match earlier changes to Podfile.	2015-07-21 09:38:40 -07:00
appleguy	2ddfbefaab	Merge pull request #575 from eanagel/new-auto-adjust-content ... Take 2: Automatically adjust content offset for insertion/deletion	2015-07-20 22:21:41 -07:00
Ethan Nagel	bf0766169b	PR Feedback: Require main thread for all edit commands, various cleanup.	2015-07-20 22:08:19 -07:00
Ethan Nagel	f497639124	Add support automatically adjusting the content offset to UITableView as well as support for performing endUpdates with no animations. Additionally, there are critical bug fixes for ASDataController (begin/end updates delegates not called in correct order) and ASRangeController (failure to fully refresh internal state when inserts or delete are made.)	2015-07-20 14:05:56 -07:00
Roy Marmelstein	3c71289927	lazy creation of textview in accessor after assert	2015-07-18 16:31:13 +02:00
Roy Marmelstein	6b970e0e4a	Display node assert	2015-07-18 16:29:25 +02:00
Roy Marmelstein	36b92205ed	Brace style	2015-07-18 16:10:32 +02:00
appleguy	d5086bd64f	Merge pull request #568 from eanagel/update-astable-test ... Update ASTableView test	2015-07-17 18:48:43 -07:00
appleguy	36884cc53e	Merge pull request #573 from eanagel/fix-endUpdates-async-when-invalid ... Prevent making async updates to UITable|CollectionView when asycDataSource is cleared	2015-07-17 17:54:10 -07:00
Ethan Nagel	c14ecd7e99	short-circuit editing calls after the asyncDataSource has been set to nil (ASCollectionView)	2015-07-16 20:26:45 -07:00
Ethan Nagel	9762e7cfe6	short-circuit editing calls after the asyncDataSource has been set to nil (ASTableView)	2015-07-16 20:26:28 -07:00
Ethan Nagel	3da7305abb	Wait to begin thrashing until we have completed reloading the data so we aren't trying to do both operations concurrently.	2015-07-15 16:31:01 -07:00
Ethan Nagel	8c72118e69	Don't abuse the CI servers so much. Note - With this configuration we will often pass with a known race issue we currently have. Making ASTableViewStressTest more interesting so we can reliably reproduce the issue there.	2015-07-15 10:19:03 -07:00
appleguy	cfbf03f4e0	Merge pull request #567 from eanagel/FBSnapshotTestCase-version ... Fb snapshot test case version	2015-07-14 13:56:04 -07:00
Ethan Nagel	98bdae8690	Merge branch 'master' into update-astable-test	2015-07-13 14:39:28 -07:00
Ethan Nagel	f1f124f8ac	Merge branch 'master' into FBSnapshotTestCase-version	2015-07-13 14:36:51 -07:00
Ethan Nagel	13f71d6672	update Podfile to require FBSnapshotCase 1.8.1 because v2.0+ requires frameworks and we haven't tried enabling them yet.	2015-07-13 14:35:54 -07:00